Commit graph

2904 commits

Author SHA1 Message Date
Thiemo Kreuz f2b247cb2f Add missing type hints to hook handler functions
This patch also removes some & from function parameters that are not
meant to be passed "by reference". These & are from a time when PHP 4
passed objects by creating expensive copies. They are not needed any
more, but create the wrong impression the hook handler function would be
allowed to replace these objects with other ones.

Change-Id: If91c6d963150f909735f2c06f98a446ae1fb2047
2019-05-11 13:44:05 +02:00
Thiemo Kreuz 0fe650ce08 Add @see links pointing to the MediaWiki hooks manual
Change-Id: I1980f488f8516fe8700ffdae4905e09446b322de
2019-05-10 19:18:49 +00:00
jenkins-bot ac1cc30d8a Merge "Rename all hook handler functions to follow on<HookName> scheme" 2019-05-10 15:53:07 +00:00
Thiemo Kreuz f733d8bbd1 Fix typos in JSDocs type hint
Change-Id: Id590ba6a587dbe5b38bd998d93f07221cfcfeae2
2019-05-10 15:42:20 +00:00
Thiemo Mättig f8bf849430 Allow partial selection in text fields
Really, why should this be forbidden? These onclick handlers do waaaaay
to much. They do not only block what they should block, they block way
more stuff, like resizing the textarea and interacting with it in any
way that involves the mouse. This is not the intention of this code.
I'm sorry to say that, but this code is the equivalent of "disable
right click to prevent stealing images" on 1990s web pages. Please,
please let's not do this. Let the user do what he expectes and is used
to do.

Bug: T110579
Change-Id: Ia89faea678606d5c382539f726e2edaa745c904e
2019-05-10 14:33:08 +02:00
Thiemo Kreuz 44457ec926 Rename all hook handler functions to follow on<HookName> scheme
Change-Id: Ic770a9dd0a708a670a8658d3be037c7b73ebea83
2019-05-10 14:26:15 +02:00
Thiemo Kreuz 7c67c4ba81 Remove all default "return true" from hook handlers
This is the default for many years now. Returning true is not different
from returning nothing.

Change-Id: If05c82d4a534d21269934aebb48786a97246ac88
2019-05-10 14:18:37 +02:00
Translation updater bot 17848c4add Localisation updates from https://translatewiki.net.
Change-Id: Iae064c7a174f3381155503beb2472e6e795e84ac
2019-05-10 09:20:10 +02:00
jenkins-bot a6e1a69a69 Merge "Fix browser test failures" 2019-05-08 22:27:35 +00:00
jenkins-bot cd8090511a Merge "build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint" 2019-05-08 22:21:56 +00:00
jenkins-bot d0c446c9b8 Merge "Remove the BetaFeatures integration" 2019-05-08 21:52:39 +00:00
Mark Holmquist 93d948b21c Fix browser test failures
Sauce labs removed support for OSX 10.9, so we've seen failures in the
browser tests for a while apparently.

The generic "macos" should just work, and is sufficient for our testing
needs.

Bug: T214389
Change-Id: I01c1e9e03dc5b658aa3e2b3ee6a7b5f503488f97
2019-05-08 14:40:17 -07:00
James D. Forrester 342b02035d build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Change-Id: I422d5ea3a8939247aa8a4bd521ec05636caaa13f
2019-05-08 21:34:56 +00:00
James D. Forrester 9b826f022e build: Lint the rest of our JS, and make pass
Change-Id: I660bba75d2637ac67a1f7920d40e051ed67d1d45
2019-05-08 14:28:06 -07:00
James D. Forrester 23b2f78642 Remove the BetaFeatures integration
Not used in years. Sadly $wgMediaViewerEnableByDefault has to remain
for now.

Change-Id: If2d90627de230b9b36e7b24abe0d4bdee8a2ef35
2019-05-08 11:22:35 -07:00
Translation updater bot 72a96534dd Localisation updates from https://translatewiki.net.
Change-Id: I1047fd1bac168e286507543383f10d8341965bfa
2019-04-30 22:18:22 +02:00
Translation updater bot 8cb0ec5639 Localisation updates from https://translatewiki.net.
Change-Id: Ia8c6b99e61cb21b335c83a9f005b3a59d3eeb942
2019-04-22 09:23:45 +02:00
Timo Tijhof c520b76978 Rename MakeGlobalVariablesScript hook for consistency
Given case-sensitive search, the callback didn't show up
when searching for "MakeGlobalVariablesScript", unlike for
almost every other deployed extension.

Change-Id: Ib9138446a898802150a123e140a14bfba08709e6
2019-04-16 22:59:25 +00:00
Translation updater bot 6ab5878cfc Localisation updates from https://translatewiki.net.
Change-Id: I381785b741c4da73451ab9760a1badbb7343a299
2019-04-14 22:30:00 +02:00
Translation updater bot f07cc570b6 Localisation updates from https://translatewiki.net.
Change-Id: I74a9638810cd9306d9e66bf9333131547b4883c2
2019-04-10 09:23:14 +02:00
Translation updater bot c80e3115cf Localisation updates from https://translatewiki.net.
Change-Id: I809aff5246d3c824af088a062565baaaa4e579e8
2019-04-08 08:39:09 +02:00
Translation updater bot 0fae0db433 Localisation updates from https://translatewiki.net.
Change-Id: I1a58c720beafe8164ed797e91f0a873877f358bc
2019-03-23 10:23:15 +01:00
Translation updater bot 09d4eefdc5 Localisation updates from https://translatewiki.net.
Change-Id: Ie9f6d9d8b5be5d33bd2d3c37962cdb547764bd79
2019-03-19 22:17:00 +01:00
Kunal Mehta 60d08ba00b Upgrade to newer phan
Bug: T216928
Change-Id: I2b812745176550616c8d37859f2ad29cdf8fd4c3
2019-03-17 16:14:02 -07:00
jenkins-bot 8ec3cc3895 Merge "Always load MMV on Flow pages" 2019-03-14 17:39:30 +00:00
Ed Sanders 551a0561fe Always load MMV on Flow pages
We can't tell if there are images on the page, so just always
load. The code will likely be in the client cache anyway.

Bug: T62014
Change-Id: Idaec22c3fd7126c1818c5febbccd6a0cfac7b721
2019-03-13 21:56:02 +00:00
Translation updater bot 17366a8821 Localisation updates from https://translatewiki.net.
Change-Id: I5acac0d91ce2431cd296bb027454c2abdfcb1e8c
2019-03-12 22:29:27 +01:00
Translation updater bot 3bddab489d Localisation updates from https://translatewiki.net.
Change-Id: I97364ef3ee0ade32b554e28558f49d3818fd8485
2019-03-10 22:27:47 +01:00
Translation updater bot 06e80d3078 Localisation updates from https://translatewiki.net.
Change-Id: I6bbcea611de38c3c526ba4615ed2e0cdd4660777
2019-03-05 22:42:50 +01:00
jenkins-bot a68bd2a10b Merge "Replace use of deprecated ResourceLoaderTestModules hook" 2019-03-05 13:06:05 +00:00
Translation updater bot 682471de56 Localisation updates from https://translatewiki.net.
Change-Id: I94464b107f2013f5ab49e7850f63820e5b27984f
2019-03-04 22:16:11 +01:00
Translation updater bot 255ba527d2 Localisation updates from https://translatewiki.net.
Change-Id: I005b9a3d145291f91a942cc435a4b1feb72b39a1
2019-03-03 22:17:42 +01:00
Umherirrender 0312e465ed Use ExtensionRegistry rather than class_exists
Change-Id: I99d0207aaf193ab2aa4e27c7f12a5cefc2dc4da9
2019-03-03 02:05:12 +01:00
Translation updater bot cee3fa6899 Localisation updates from https://translatewiki.net.
Change-Id: I5777d99ca38904c4bf37939c8f5a38b2445df765
2019-03-02 22:42:38 +01:00
James D. Forrester c6008c7844 build: Be more aggressive in fixing old bad JS code style
Change-Id: I7f734f1440a4a3216e774d2bddbc39b34f4125d2
2019-02-20 19:28:25 +00:00
James D. Forrester 1b21470703 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I66788a2c1fa59b617abd13b7c8e8fb59ad74130c
2019-02-20 19:22:21 +00:00
Translation updater bot 9a27ccebdf Localisation updates from https://translatewiki.net.
Change-Id: I49c507bb3ccbc8f29ebe1f5988e6b8c738b1b9ad
2019-02-19 22:20:03 +01:00
Translation updater bot bd69d66952 Localisation updates from https://translatewiki.net.
Change-Id: I270a4697d4587217419d452dd50d7489ce1750e6
2019-02-18 22:23:16 +01:00
James D. Forrester 8ec4150af0 Replace use of deprecated ResourceLoaderTestModules hook
Use the new extension.json attribute instead.

Bug: T214211
Depends-On: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
Change-Id: Iacb68ce9a7bab864720ef9a56f8702a4f02c129d
2019-02-13 15:05:33 -08:00
Translation updater bot 3ee18bdf93 Localisation updates from https://translatewiki.net.
Change-Id: Ide4cd94fd393e6f9ba26b8d567c5fce13b6df029
2019-02-11 22:28:12 +01:00
Translation updater bot 7a172a0ca7 Localisation updates from https://translatewiki.net.
Change-Id: I63e543e19998ec6bcbc9c28ff9cc13e2b94ef1d2
2019-02-10 22:18:47 +01:00
jenkins-bot 60fa899822 Merge "build: Replace 'svgmin' 'indent' option value by tab escape sequence" 2019-02-09 23:19:32 +00:00
jenkins-bot 1c73afc7de Merge "build: Update grunt-banana-checker from 0.6.0 to 0.7.0" 2019-02-09 23:06:04 +00:00
Translation updater bot 26daceb4cc Localisation updates from https://translatewiki.net.
Change-Id: Ife3f6c47ac26e5cb0ed7da697961a0ecb22362ac
2019-02-07 22:28:45 +01:00
Volker E 2e27c9597b build: Replace 'svgmin' 'indent' option value by tab escape sequence
Unifying code across projects.

Change-Id: I78e07c4efab6a9c084cbba5944c24003dc30fcad
2019-02-06 21:15:39 -08:00
libraryupgrader 0c36bcd866 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I82693cf8ebc10a313991deceb5c3d798fd87fc1c
2019-02-07 01:15:09 +00:00
James D. Forrester 2543fd8c44 build: Update grunt-banana-checker from 0.6.0 to 0.7.0
Change-Id: Ife735aac7762b127112107b4c130bb0131bb6e30
2019-02-06 15:45:46 -08:00
Ed Sanders 92157f6b05 build: Update eslint-config-wikimedia to 0.10.1
Change-Id: Icd89819ef38142e55c0bd4cc8dbb73745123f9f6
2019-02-06 01:56:53 +00:00
Eric Gardner bbaf7a38b4 Get Rid of EmbedFileInfo
* Deletes the mmv.model.EmbedFileInfo class file and its test file
* Updates the extension.json and MultimediaViewerHooks.php files to reflect
  these deletions (by removing entries from dependency lists)
* Refactors all instances of `new mmv.model.EmbedFileInfo()` to instead use a
  POJO with appropriate properties. Conditional assignment is used for the
  caption and alt properties if there is any chance they won't be available, to
  keep from adding props with falsy values.
* Refactors JSDoc method annotations so that `@param` tags expecting an
  EmbedFileInfo instance now expect an object; relevant properties of this
  object and their types have been added to the method annotations as well.

Bug: T77320
Change-Id: Ie9f5f24136f4b73000259685474ce4d765a3ccd3
2019-02-05 15:31:49 -08:00
Translation updater bot bc574eaa2c Localisation updates from https://translatewiki.net.
Change-Id: I2162db5e5c3cb3adea7406bd0e6f893bc87df925
2019-01-31 22:26:12 +01:00