Simon Legner
01437fd521
Replace wgMultimediaViewer with config.json packageFiles
...
Practically, the variable wgMultimediaViewer is not used inside user common.js, see https://global-search.toolforge.org/?q=wgMultimediaViewer
Ref: https://www.mediawiki.org/wiki/ResourceLoader/Package_files
Bug: T77349
Change-Id: Ib086c6184f76ca2dbeb701f79c3b18b336ff5433
2024-08-11 11:34:46 +02:00
Simon Legner
a8a5247c5e
Use mw.msg shortcut
...
Change-Id: I5af9cc79d1c6108f643b690ded0dd9b876c3852b
2024-05-29 05:14:01 +00:00
Simon Legner
f00dbbb939
Remove IIFE
...
Remove Immediately-invoked function expression throughout production code base.
Bug: T77349
Change-Id: Ia31b556975209bbea27df8444b69d924654b181e
2024-05-21 22:31:15 +02:00
Simon Legner
683b3e1caf
Use Codex icons
...
Discussed with Justin and Matthew (designers):
- Dropping the image in "Disable Media Viewer"
Discussed with Jon:
- Resizing the next/previous arrows
Bug: T340258
Change-Id: I6f7b6d0f9b96168ab6d835811141ab4cede214d1
2024-05-04 20:54:12 +03:00
jenkins-bot
612ebb5c80
Merge "Public API to Check Wikimedia Media Viewer Extension Status"
2024-02-15 19:21:24 +00:00
libraryupgrader
147b576b57
build: Updating dependencies
...
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0
npm:
* eslint-config-wikimedia: 0.25.1 → 0.26.0
The following rules are failing and were disabled:
* resources:
* es-x/no-resizable-and-growable-arraybuffers
* tests/qunit:
* es-x/no-resizable-and-growable-arraybuffers
* grunt-banana-checker: 0.11.0 → 0.11.1
Change-Id: Ief610bdadaccd2325cd1b8a2cae70b7e465d8b76
2024-02-13 02:13:29 +00:00
Simon Legner
1ab8d0d899
Public API to Check Wikimedia Media Viewer Extension Status
...
mw.mmv.isMediaViewerEnabledOnClick()
Bug: T348026
Change-Id: Ibc34e370e6bf631d9f861b9f6baa75d3f227123e
2024-02-07 20:38:01 +01:00
Simon Legner
6ee3f05104
Use Codex styles for buttons in mmv.ui.download.pane
...
Bug: T340258
Change-Id: I30a7ab4a6732fd87a68c67593d322be2347b2ff8
2023-09-28 10:02:57 -07:00
Ed Sanders
a33f7e5c57
Update linters and fix issues
...
Change-Id: Ib562131bbb3a9940d56602e0c4dbbe810ce7358c
2023-06-28 19:12:48 +01:00
Simon Legner
5f781b7a9b
Add jsdoc to MMV
...
This replaces the jsduck implementation that we recently removed.
Changes:
* Document events on Document element.
Bug: T337039
Change-Id: Iaa9f54c7838159a75a38eec0d49f203803aadee7
2023-06-12 22:08:14 +02:00
Simon Legner
30fad6b8b8
Use ES6 features
...
* classes
* arrow functions
* const/let
* string templates
* Object.assign
Bug: T337102
Change-Id: I757b9993a2feeed707fb4ad213944001498f3f6a
2023-06-12 16:45:08 +00:00
Simon Legner
d82910fbb3
Use packageFiles in mmv
...
Bug: T337030
Change-Id: I833c7e91230272b82a2512fd55f1c7c0f61233b4
2023-05-20 10:04:41 +03:00
Simon Legner
35cd0f18c0
Use packageFiles in mmv
...
Bug: T337030
Change-Id: I90cdfb626c176b27b59db6b92b9edd6b2fe49b68
2023-05-20 09:34:56 +03:00
Fomafix
90a1949444
Use .text( '\u00A0' ) instead of .html( ' ' )
...
On reading the HTML by .html() in the tests the content is still
' '.
Bug: T154300
Change-Id: I2f43909c5539a5882af354fc8f64b03e43697647
2023-05-01 18:41:48 +00:00
Sam Smith
34e4968b2c
Remove instrumentation
...
The MediaViewer and MultimediaViewer* instruments were disabled circa
October 2021 in Ie7dd8739efc.
This patch removes those instruments and any supporting code and data.
Notably, this patch does not remove the mw.mmv.logging.ViewLogger
instrument, which is responsible for logging image views.
Bug: T310890
Change-Id: I97d41be93849b2ae9d1adba6660546ea716657fd
2022-07-05 17:41:24 +00:00
Ed Sanders
bfdcd8dbf1
eslint: Update eslint-config-wikimedia to 0.16.2
...
Change-Id: I0c35ed9b5ab00952124cb0e5c6c48fbc0d734f60
2020-06-26 12:14:27 +01:00
Ed Sanders
a518cb03a5
build: Update eslint-config-wikimedia to 0.9.0
...
Change-Id: I92ed1f7093cfaed47f0372f9cb063fe4e65b4f55
2019-01-03 13:47:16 +00:00
Ed Sanders
1ded292f83
Remove obsolete aliases from closures
...
Bug: T208951
Change-Id: Ice695dfb489974faa23ba19d74cf17b06e3f6075
2018-11-12 16:33:24 +00:00
Ed Sanders
9ad112910c
Avoid jQuery event aliases
...
Use #on for event binding and #trigger for event firing.
Change-Id: I75ca1cfac8419204399e27941c9f424664b56113
2018-05-11 18:46:50 +00:00
Ed Sanders
42b577bae9
build: Update linters
...
Change-Id: I7262fb369df0428c39adaf55128b83f019afb4c0
2017-10-31 18:42:04 +00:00
Ed Sanders
d7ea64137c
build: Replace jshint/jscs with eslint
...
Change-Id: I423add157245353031e36b7e44fee7ace7c753c7
2017-01-10 10:24:39 -08:00
Ed Sanders
b46529d1b2
build: Introduce jshint & jscs and make a pass
...
These replace the hard-coded jshint task in CI.
Change-Id: Id14eec1ecba4ceae735ffd10f9114233a580302f
2016-07-19 13:48:06 -07:00
Gergő Tisza
1d79a5c483
Remove delay when logging link clicks
...
EventLogging uses sendBeacon now so there is no danger of losing
clicks because the browser navigates away. (On modern browsers,
anyway; but we can live with being a little imprecise on older
browsers. We don't use link click stats much, anyway.)
Bug: T89533
Change-Id: Id83f60585d11f06610d8514c211f0116c60ea936
2015-02-19 23:36:53 +00:00
Fomafix
ae99be730e
Apply coding conventions for JavaScript
...
Change-Id: I57a8f188eb1152438a8e94235a6f6801e2617c28
2015-01-23 12:48:27 +00:00
Gilles Dubuc
6da3f6b33e
Make room for arbitrary i18n text length in the options dialogs
...
Change-Id: Id618a92e1502307612f289bfb4d071d88cc5b292
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/979
Bug: 72862
2014-11-12 11:21:32 +00:00
Mark Holmquist
ff7a8b23c2
Add about link to disable/enable dialog
...
This was the last issue with the dialogs. Tests included.
Change-Id: Ic08af400893950a04489af4b166827d059561974
2014-10-24 13:51:32 -05:00
Mark Holmquist
1853540cd3
Add viewing options panel
...
Enable, disable, and get confirmations.
Lots of UI work on this one.
Change-Id: I1f731992bd240e7ea403592872f7c7e270158753
2014-10-19 00:27:15 +02:00
