Ed Sanders
b03af20581
eslint: Lint Gruntile.js using server rules
...
Change-Id: I6f6f7391668412b2bb572a8d77da8e137fa169bb
2022-02-07 16:38:38 +00:00
Volker E
3205e72ad8
build: Replace 'grunt-svgmin' with npm based 'svgo' & re-crush SVGs
...
Replacing 'grunt-svgmin' with 'svgo' v2.3.0.
Also
- replacing all Grunt based tasks with npm equivalents. 'build' has
before just been for SVG minification and that's the same now in npm.
- changing to JS based '.svgo.config.js'
- re-crushing all SVGs. Note that 'link-hover.svg' and 'link.svg' have
been optimized with reduced precision. All other changes are resulting
from updated SVGO.
Bug: T278656
Change-Id: Ie895edb4e88336ffc56f570b8f80bf7d1e331894
2021-04-12 13:01:59 -07:00
Ed Sanders
bfdcd8dbf1
eslint: Update eslint-config-wikimedia to 0.16.2
...
Change-Id: I0c35ed9b5ab00952124cb0e5c6c48fbc0d734f60
2020-06-26 12:14:27 +01:00
James D. Forrester
f7681dc537
Follow-up 950577662: Put developer-focussed notes in DEVELOPERS.md
...
Much more likely to be found than inline comments in Gruntfile.js.
Change-Id: I51f8b56d490fb72dba111d80140b4f3c6e87db18
2020-02-24 12:08:52 -08:00
AronDemian
950577662e
Maintenance: grunt lint --fix, grunt eslint --fix, grunt stylelint --fix automatically fixes trivial coding style errors
...
Bug: T245930
Change-Id: Ied764d76c8d2f1fd3f541df38e40a0c029a842a9
2020-02-24 19:03:25 +01:00
AronDemian
404c0d5fc7
Maintenance: add grunt lint and grunt minify, consistent with core, and grunt build, npm build
...
Bug: T245930
Change-Id: I3b3c42078d041c6df866001508dd7e75e81f289e
2020-02-24 14:55:54 +01:00
AronDemian
2ebd52ec71
Maintenance: grunt test won't run the unnecessary 'svgmin' task. grunt (default) will, though.
...
'svgmin' minifies .svg files, that's only necessary when those are changed, which seldom happens.
Bug: T245930
Change-Id: I79e1dbc5c86206991fcef08eb23d17d3141901b7
2020-02-24 14:54:03 +01:00
libraryupgrader
bb26bc47b4
build: Updating eslint-config-wikimedia to 0.15.0
...
The following rules are failing and were disabled:
* brace-style
* camelcase
* eqeqeq
* new-cap
* no-alert
* no-console
* no-constant-condition
* no-dupe-keys
* no-empty
* no-implicit-globals
* no-jquery/no-global-selector
* no-jquery/variable-pattern
* no-mixed-spaces-and-tabs
* no-redeclare
* no-tabs
* no-undef
* no-underscore-dangle
* no-unused-vars
* no-use-before-define
* no-useless-concat
* one-var
* valid-jsdoc
* vars-on-top
Additional changes:
* Added .eslintcache to .gitignore.
* Removing manual reportUnusedDisableDirectives for eslint.
Change-Id: I2b54baa20980b7efa3e432ed5d95fa9bc0ba7e40
2020-01-08 00:06:26 +00:00
Ed Sanders
18a154b989
build: Update devDependencies
...
Change-Id: I46f5317976ef9f818e30b0c81018e83800535389
2019-07-31 22:59:13 +01:00
James D. Forrester
342b02035d
build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
...
Change-Id: I422d5ea3a8939247aa8a4bd521ec05636caaa13f
2019-05-08 21:34:56 +00:00
James D. Forrester
9b826f022e
build: Lint the rest of our JS, and make pass
...
Change-Id: I660bba75d2637ac67a1f7920d40e051ed67d1d45
2019-05-08 14:28:06 -07:00
Volker E
2e27c9597b
build: Replace 'svgmin' 'indent' option value by tab escape sequence
...
Unifying code across projects.
Change-Id: I78e07c4efab6a9c084cbba5944c24003dc30fcad
2019-02-06 21:15:39 -08:00
Ed Sanders
92157f6b05
build: Update eslint-config-wikimedia to 0.10.1
...
Change-Id: Icd89819ef38142e55c0bd4cc8dbb73745123f9f6
2019-02-06 01:56:53 +00:00
Volker E
a23084a360
build: Follow 'svgmin' step option best-practices
...
Changing indentation to tabs and use `multipass` option correctly.
Follow-up to I09660b9d49cfdc4.
Change-Id: Ic69532ad165c34aab97888328c7bef6e6c578491
2018-11-28 18:32:16 -08:00
Volker E
d1f416278a
Bring SVGO optimization to build step
...
Enabling SVGO automation with conservative plugin set, among those:
- disable cleanupIDs, removeDesc, removeTitle, removeViewBox &
removeXMLProcInst and
- don't use multipass,
- enable removeRasterImages and sortAttrs
Bug: T185596
Change-Id: Ic13afb6e1cbc4d26af7a100cb7a916619fb4158e
2018-01-24 00:27:53 -08:00
Umherirrender
1f153df6d2
build: Always exclude vendor and node_modules
...
Change-Id: I40a46de7388d6c48762c3d9452fd3341354015a0
2017-11-12 00:25:39 +01:00
Ed Sanders
e7f53c4be8
build: Re-use MessageDirs in banana conf
...
Change-Id: If9651d9e1c394a294cc9808dbf1656883c1dfbc6
2017-01-23 13:51:12 +00:00
Ed Sanders
d7ea64137c
build: Replace jshint/jscs with eslint
...
Change-Id: I423add157245353031e36b7e44fee7ace7c753c7
2017-01-10 10:24:39 -08:00
Ed Sanders
e7ff2ba8b6
build: Introduce stylelint and make pass
...
Change-Id: I6f97359c6f34f2e5687ce91ab9926c493e613bf5
2016-07-19 13:51:05 -07:00
Ed Sanders
b46529d1b2
build: Introduce jshint & jscs and make a pass
...
These replace the hard-coded jshint task in CI.
Change-Id: Id14eec1ecba4ceae735ffd10f9114233a580302f
2016-07-19 13:48:06 -07:00
Kunal Mehta
d996d5e6ae
build: Configure banana-checker and jsonlint
...
Change-Id: If625ff9a3324ac0835afa9fa03d6e5041d3ea331
2015-06-19 21:55:50 -07:00
