wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-09-29 13:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix E2E scroll assertion logic

Browse source 
It turns out that cucumber/selenium will automatically scroll
to the element you want it to click on. As a result we have to do
the same in order for the assertion to be correct when coming back to
the article.

Change-Id: I7d3b6609cfe7cdae9c08a6d723d652ad1a6a7055
This commit is contained in:
Gilles Dubuc 2014-04-15 16:09:18 +02:00
parent 201f97cf28
commit fe399fc71c
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
View file

@ -5,10 +5,10 @@ end
When(/^I click on the first image in the article$/) do
on(LightboxDemoPage) do |page|
# Scroll the article on purpose
page.execute_script "window.scroll(10, 100)"
@articleScrollTop = page.execute_script("return $(window).scrollTop();")
@articleScrollLeft = page.execute_script("return $(window).scrollLeft();")
# We store the offset of the image as the scroll position, because cucumber/selenium
# automatically scrolls to it when we ask it to click on it
@articleScrollTop = page.execute_script("return Math.round($('a[href=\"/wiki/File:Sunrise_over_fishing_boats_in_Kerala.jpg\"]').first().find('img').offset().top);")
# Scrolls to the image and clicks on it
page.image1_in_article
end
end
@ -68,7 +68,6 @@ end
Then(/^the wiki article should be scrolled to the same position as before opening MMV$/) do
on(LightboxDemoPage) do |page|
page.execute_script("return $(window).scrollTop();").should eq @articleScrollTop
page.execute_script("return $(window).scrollLeft();").should eq @articleScrollLeft
end
end