wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-09-29 13:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix E2E scroll assertion logic"

Browse source
This commit is contained in:
jenkins-bot 2014-04-16 22:10:44 +00:00 committed by Gerrit Code Review
parent fff6c55695 fe399fc71c
commit bd9b268107
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
View file

@ -5,10 +5,10 @@ end
When(/^I click on the first image in the article$/) do When(/^I click on the first image in the article$/) do
on(LightboxDemoPage) do |page| on(LightboxDemoPage) do |page|
# Scroll the article on purpose # We store the offset of the image as the scroll position, because cucumber/selenium
page.execute_script "window.scroll(10, 100)" # automatically scrolls to it when we ask it to click on it
@articleScrollTop = page.execute_script("return $(window).scrollTop();") @articleScrollTop = page.execute_script("return Math.round($('a[href=\"/wiki/File:Sunrise_over_fishing_boats_in_Kerala.jpg\"]').first().find('img').offset().top);")
@articleScrollLeft = page.execute_script("return $(window).scrollLeft();") # Scrolls to the image and clicks on it
page.image1_in_article page.image1_in_article
end end
end end
@ -68,7 +68,6 @@ end
Then(/^the wiki article should be scrolled to the same position as before opening MMV$/) do Then(/^the wiki article should be scrolled to the same position as before opening MMV$/) do
on(LightboxDemoPage) do |page| on(LightboxDemoPage) do |page|
page.execute_script("return $(window).scrollTop();").should eq @articleScrollTop page.execute_script("return $(window).scrollTop();").should eq @articleScrollTop
page.execute_script("return $(window).scrollLeft();").should eq @articleScrollLeft
end end
end end