From 2e4bd06f6b85f37ad4144a32ddea83ac30bae86f Mon Sep 17 00:00:00 2001
From: Jdlrobson <jrobson@wikimedia.org>
Date: Wed, 13 Nov 2024 23:11:46 +0000
Subject: [PATCH] Revert "mmv.js: Store comingFromHashChange as a class
 property"

This reverts commit b5ed0e6c04ca0a99ccefa12923622ccf28cfd009.

Reason for revert: Caused T379835

Bug: T379835
Change-Id: I5ad84928417588d777fc40bad04d8e693a1bc257
---
 resources/mmv/mmv.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/resources/mmv/mmv.js b/resources/mmv/mmv.js
index 4636187c5..d2c4a4150 100644
--- a/resources/mmv/mmv.js
+++ b/resources/mmv/mmv.js
@@ -44,6 +44,7 @@ const ThumbnailWidthCalculator = require( './mmv.ThumbnailWidthCalculator.js' );
 const { extensions, useThumbnailGuessing } = require( './config.json' );
 
 const router = require( 'mediawiki.router' );
+let comingFromHashChange = false;
 
 /**
  * Analyses the page, looks for image content and sets up the hooks
@@ -95,7 +96,7 @@ class MultimediaViewer {
 		 */
 		this.router = router;
 		this.setupRouter();
-		this.comingFromHashChange = false;
+		comingFromHashChange = false;
 
 		/**
 		 * UI object used to display the pictures in the page.
@@ -685,8 +686,8 @@ class MultimediaViewer {
 		this.viewLogger.recordViewDuration();
 		this.viewLogger.unattach();
 
-		if ( this.comingFromHashChange ) {
-			this.comingFromHashChange = false;
+		if ( comingFromHashChange ) {
+			comingFromHashChange = false;
 		} else {
 			this.router.back();
 		}
@@ -706,7 +707,7 @@ class MultimediaViewer {
 		// handle empty hashes, and anchor links (page sections, possibly including /)
 		this.router.addRoute( /.*$/, () => {
 			if ( this.isOpen ) {
-				this.comingFromHashChange = true;
+				comingFromHashChange = true;
 				document.title = this.createDocumentTitle( null );
 				if ( this.ui ) {
 					// FIXME triggers mmv-close event, which calls viewer.close()