From 9d265ee1d0c3311667b8c928d07e91da5dd621af Mon Sep 17 00:00:00 2001 From: dylsss Date: Tue, 7 Jun 2022 23:24:53 +0100 Subject: [PATCH] Fix credit fallback not updating when switching image jQuery object gets converted to "[object Object]" which results in an ununique array key in HUP.htmlToTextWithTags cache.textWithTags, instead pass HTML string. Bug: T308958 Change-Id: If6fc934d263107a0d3346ccea8e91cade72db666 --- resources/mmv/ui/mmv.ui.metadataPanel.js | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/mmv/ui/mmv.ui.metadataPanel.js b/resources/mmv/ui/mmv.ui.metadataPanel.js index 0ae78d4e1..afcfffa5e 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanel.js +++ b/resources/mmv/ui/mmv.ui.metadataPanel.js @@ -496,6 +496,7 @@ .addClass( 'mw-mmv-credit-fallback' ) .prop( 'href', filepageUrl ) .text( mw.message( 'multimediaviewer-credit-fallback' ).plain() ) + .get( 0 ).outerHTML ); }