wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-24 08:13:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Click in the top-left corner of the image when trying to close the download dialog

Browse source 
This should fix the failures happening in IE.

Bug: T89087
Change-Id: Ia0128a9c85891e8f2d89098c898d5927f01fbedd
This commit is contained in:
Gilles Dubuc 2015-02-13 12:18:27 +01:00
parent 8c37b7abb4
commit 94ac32835d
3 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/browser/features/mmv.download.feature
View file

@ -36,6 +36,7 @@ Feature: Download menu
Scenario: The small download option has the correct information
When I open the download dropdown
And the download size options appear
And I click the small download size
And the download size options disappears
Then the download image size label should be "193 × 145 px jpg"
@ -43,6 +44,7 @@ Feature: Download menu
Scenario: The medium download option has the correct information
When I open the download dropdown
And the download size options appear
And I click the medium download size
And the download size options disappears
Then the download image size label should be "640 × 480 px jpg"
@ -50,6 +52,7 @@ Feature: Download menu
Scenario: The large download option has the correct information
When I open the download dropdown
And the download size options appear
And I click the large download size
And the download size options disappears
Then the download image size label should be "1200 × 900 px jpg"

6
tests/browser/features/step_definitions/mmv_download_steps.rb
View file

@ -35,10 +35,14 @@ When /^I click the (.*) download size$/ do |size_option|
@index = 0
end
page.mmv_download_size_options_elements[@index].when_present.click
page.mmv_download_size_options_elements[@index].click
end
end
When /^the download size options appear$/ do
on(E2ETestPage).mmv_download_size_menu_element.when_present
end
When /^the download size options disappears$/ do
on(E2ETestPage).mmv_download_size_menu_element.when_not_present
end

6
tests/browser/features/step_definitions/mmv_steps.rb
View file

@ -40,7 +40,11 @@ When /^I close MMV$/ do
end
When /^I click the image$/ do
on(E2ETestPage).mmv_image_div_element.when_present.click
on(E2ETestPage) do |page|
# Clicking the top-left corner of the image is necessary for the test to work on IE
# A plain click on the image element ends up hitting the dialog, which means it won't close
@browser.driver.action.move_to(@browser.driver.find_element(:class, 'mw-mmv-image'), 10, 10).click.perform
end
end
Then /^the image metadata and the image itself should be there$/ do