wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-28 01:50:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable thumbnail URL guessing by default

Browse source 
Config change to keep it on on WMF sites:
Iba41a37a1d4b7957cd05516ae9466652dadcf28a

Bug: 64554
Change-Id: I25f52611f6f2a6db7f33d52a2fbae48c729f7686
This commit is contained in:
Gergő Tisza 2014-06-27 01:37:03 +00:00 committed by Gergő Tisza
parent c7948fd873
commit 7081184535
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
MultimediaViewer.php
View file

@ -52,21 +52,15 @@ if ( !isset( $wgMediaViewerIsInBeta ) ) {
if ( !isset( $wgMediaViewerUseThumbnailGuessing ) ) {
/**
* When this is enabled, MediaViewer will try to guess image URLs instead of making an
* imageinfo API to get them from the server. This speeds up image loading, but does not
* work well with certain settings (especially $wgGenerateThumbnailOnParse == true).
* If e.g. you use non-standard thumbnail URLs, you might want to override this to false.
*
* Note that MediaViewer will catch 404 errors and do an API request when this is enabled,
* so even if it does not work with your config, there should be no visible breakage, but
* there will be a small performance hit. You have to look at network logs to checks whether
* it works or not.
*
* FIXME this should be configurable per-repo. Even if the local wiki pre-renders thumbnails,
* remotes such as Commons will work (and vice versa).
* imageinfo API to get them from the server. This speeds up image loading, but will result in 404s
* when $wgGenerateThumbnailOnParse (so the thumbnails are only generated as a result of the API request).
* MediaViewer will catch such 404 errors and fall back to the API request, but depending on how the site
* is set up, the 404 might get cached, or redirected, causing the image load to fail. The safe way to
* use URL guessing is with a 404 handler: https://www.mediawiki.org/wiki/Manual:Thumb.php#404_Handler
*
* @var bool
*/
$wgMediaViewerUseThumbnailGuessing = true;
$wgMediaViewerUseThumbnailGuessing = false;
}
if ( !isset( $wgEnableMediaViewerForLoggedInUsersOnly ) ) {