wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-24 16:23:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simple test for enter/exiting fullscreen mode

Browse source 
While writing the test I spotted a bug and fixed it

Change-Id: I781c67752781960e4be88520f53163756fc11dab
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/140
This commit is contained in:
Gilles Dubuc 2014-01-27 17:47:23 +01:00
parent b770e02d48
commit 6803daf3a6
3 changed files with 47 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/mmv/mmv.js
View file

@ -176,7 +176,10 @@
// Register various event hooks. TODO: Make this a function that's only called once. // Register various event hooks. TODO: Make this a function that's only called once.
lightboxHooks.register( 'closeInterface', function () { lightboxHooks.register( 'closeInterface', function () {
if ( this.$nextButton ) {
this.$nextButton.add( this.$prevButton ).css( 'top', '-999px' ); this.$nextButton.add( this.$prevButton ).css( 'top', '-999px' );
}
$( document.body ).removeClass( 'mw-mlb-lightbox-open' ); $( document.body ).removeClass( 'mw-mlb-lightbox-open' );
if ( comingFromPopstate === false ) { if ( comingFromPopstate === false ) {
history.pushState( {}, '', '#' ); history.pushState( {}, '', '#' );
@ -194,8 +197,6 @@
} ); } );
lightboxHooks.register( 'fullscreen', function ( fullscreen ) { lightboxHooks.register( 'fullscreen', function ( fullscreen ) {
viewer.ui.isFullscreen = fullscreen;
if ( this.$imageMetadata ) { if ( this.$imageMetadata ) {
if ( fullscreen ) { if ( fullscreen ) {
this.$imageMetadata.hide(); this.$imageMetadata.hide();

2
resources/multilightbox/lightboxinterface.js
View file

@ -69,6 +69,8 @@
} ); } );
$( document ).on( 'jq-fullscreen-change', function ( e ) { $( document ).on( 'jq-fullscreen-change', function ( e ) {
lbinterface.isFullscreen = e.fullscreen;
lightboxHooks.callAll( 'fullscreen', this, e.fullscreen ); lightboxHooks.callAll( 'fullscreen', this, e.fullscreen );
if ( !lbinterface.fullscreenButtonJustPressed && !e.fullscreen ) { if ( !lbinterface.fullscreenButtonJustPressed && !e.fullscreen ) {

41
tests/qunit/lightboxinterface.test.js
View file

@ -56,4 +56,45 @@
lightbox.load(img); lightbox.load(img);
} ); } );
QUnit.test( 'Fullscreen mode', 4, function ( assert ) {
var lightbox = new window.LightboxInterface(),
oldFnEnterFullscreen = $.fn.enterFullscreen,
oldFnExitFullscreen = $.fn.exitFullscreen;
// Since we don't want these tests to really open fullscreen
// which is subject to user security confirmation,
// we create a proxy and make it pretend that regular jquery.fullscreen behavior happened
$.fn.enterFullscreen = function() {
this.first().addClass( 'jq-fullscreened' ).data( 'isFullscreened', true );
$( document ).trigger( $.Event( 'jq-fullscreen-change', { element: this, fullscreen: true } ) );
};
$.fn.exitFullscreen = function() {
this.first().removeClass( 'jq-fullscreened' ).data( 'isFullscreened', false );
$( document ).trigger( $.Event( 'jq-fullscreen-change', { element: this, fullscreen: false } ) );
};
// Attach lightbox to testing fixture to avoid interference with other tests.
lightbox.attach( '#qunit-fixture' );
// Entering fullscreen
lightbox.$fullscreenButton.click();
assert.strictEqual( lightbox.$main.hasClass( 'jq-fullscreened' ) , true,
'Fullscreened area has the fullscreen class');
assert.strictEqual( lightbox.isFullscreen , true, 'Lightbox knows it\'s in fullscreen mode');
// Exiting fullscreen
lightbox.$fullscreenButton.click();
assert.strictEqual( lightbox.$main.hasClass( 'jq-fullscreened' ) , false,
'Fullscreened area doesn\'t have the fullscreen class anymore');
assert.strictEqual( lightbox.isFullscreen , false, 'Lightbox knows it\'s not in fullscreen mode');
$.fn.enterFullscreen = oldFnEnterFullscreen;
$.fn.exitFullscreen = oldFnExitFullscreen;
} );
}( mediaWiki, jQuery ) ); }( mediaWiki, jQuery ) );