wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-23 15:56:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix mmv.ui.metadataPanel.test.js

Browse source 
Regression of I3a4024ccf90e50558152d4ee012e492f49e14a0e: unless mw.messages.exists the license shortName CC-BY-2.0 is returned, breaking "License is correctly set" in setImageInfo() in mmv.ui.metadataPanel.test.

Change-Id: I35f67fa3d160d771970b5695fb93f5de7ea2d41d
This commit is contained in:
Simon Legner 2024-10-10 12:40:33 +02:00
parent 683ca2a2dd
commit 3d350a29ab
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
View file

@ -1,7 +1,16 @@
const { Config } = require( 'mmv.bootstrap' ); const { Config } = require( 'mmv.bootstrap' );
const { MetadataPanel, License } = require( 'mmv' ); const { MetadataPanel, License } = require( 'mmv' );
QUnit.module( 'mmv.ui.metadataPanel', QUnit.newMwEnvironment() ); const mwMessagesExists = mw.messages.exists;
QUnit.module( 'mmv.ui.metadataPanel', QUnit.newMwEnvironment( {
beforeEach: () => {
// mock mw.messages.exists for License.getShortLink (multimediaviewer-license-cc-by-2.0)
mw.messages.exists = () => true;
},
afterEach: () => {
mw.messages.exists = mwMessagesExists;
}
} ) );
QUnit.test( '.empty()', ( assert ) => { QUnit.test( '.empty()', ( assert ) => {
const $qf = $( '#qunit-fixture' ); const $qf = $( '#qunit-fixture' );
@ -46,9 +55,7 @@ QUnit.test( '.setLocationData()', ( assert ) => {
const imageData = { const imageData = {
latitude: latitude, latitude: latitude,
longitude: longitude, longitude: longitude,
hasCoords: function () { hasCoords: () => true,
return true;
},
title: mw.Title.newFromText( 'File:Foobar.jpg' ) title: mw.Title.newFromText( 'File:Foobar.jpg' )
}; };
@ -116,9 +123,7 @@ QUnit.test( '.setImageInfo()', function ( assert ) {
title: image.filePageTitle, title: image.filePageTitle,
url: 'https://upload.wikimedia.org/wikipedia/commons/3/3a/Foobar.jpg', url: 'https://upload.wikimedia.org/wikipedia/commons/3/3a/Foobar.jpg',
descriptionUrl: 'https://commons.wikimedia.org/wiki/File:Foobar.jpg', descriptionUrl: 'https://commons.wikimedia.org/wiki/File:Foobar.jpg',
hasCoords: function () { hasCoords: () => false
return false;
}
}; };
const clock = this.sandbox.useFakeTimers(); const clock = this.sandbox.useFakeTimers();