From 26165464683e58dce168ff51d55ff606125e62ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Tisza?= Date: Mon, 9 Jun 2014 06:27:16 +0000 Subject: [PATCH] Change "learn more" to "more details about this file" Several people complained that "Learn more on Wikimedia Commons" is not clear: it can be interpreted as a link to the Commons main page, the text does not suggest that the link will be related to this specific file. The new wording tries to address this. Change-Id: Ia605cc30c4ca57598f7cebdde60061800a10b6e7 --- i18n/en.json | 6 +++--- .../features/step_definitions/basic_mmv_navigation_steps.rb | 4 ++-- tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/i18n/en.json b/i18n/en.json index c741c9314..ebf24a48d 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -10,8 +10,8 @@ "multimediaviewer-pref-desc": "Improve your multimedia viewing experience with this new tool. It displays images in larger size on pages that have thumbnails. Images are shown in a nicer fullscreen interface overlay, and can also be viewed in full-size.", "multimediaviewer-optin-pref": "Enable [https://www.mediawiki.org/wiki/Special:MyLanguage/Multimedia/About_Media_Viewer Media Viewer]", "multimediaviewer-file-page": "Go to corresponding file page", - "multimediaviewer-repository": "Learn more on $1", - "multimediaviewer-repository-local": "Learn more", + "multimediaviewer-repository": "More details about this file on $1", + "multimediaviewer-repository-local": "More details about this file", "multimediaviewer-datetime-created": "Created: $1", "multimediaviewer-datetime-uploaded": "Uploaded: $1", "multimediaviewer-userpage-link": "{{GENDER:$2|Uploaded}} by $1", @@ -96,7 +96,7 @@ "multimediaviewer-feedback-button-text": "Your feedback about this tool", "multimediaviewer-feedback-popup-text": "Leave feedback about this new media viewing experience", "multimediaviewer-description-page-button-text": "More details", - "multimediaviewer-description-page-popup-text": "More details on $1", + "multimediaviewer-description-page-popup-text": "More details about this file on $1", "multimediaviewer-commons-subtitle": "The free media repository", "multimediaviewer-view-expanded": "Expand view" } diff --git a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb index 5ce8888d7..2180d0d11 100644 --- a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb +++ b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb @@ -106,7 +106,7 @@ def check_elements_in_viewer_for_image1(page) # Image metadata links page.mmv_image_metadata_links_wrapper_element.when_present.should be_visible # Repo link - page.mmv_image_metadata_repo_link_element.when_present.text.should match /Learn more on Wikimedia Commons/ + page.mmv_image_metadata_repo_link_element.when_present.text.should match /More details about this file on Wikimedia Commons/ page.mmv_image_metadata_repo_link_element.when_present.attribute('href').should match /boats_in_Kerala.jpg$/ # Category links page.mmv_image_metadata_category_links_wrapper_element.when_present.should be_visible @@ -150,7 +150,7 @@ def check_elements_in_viewer_for_image2(page) # Image metadata links page.mmv_image_metadata_links_wrapper_element.when_present.should be_visible # Repo link - page.mmv_image_metadata_repo_link_element.when_present.text.should match /Learn more on Wikimedia Commons/ + page.mmv_image_metadata_repo_link_element.when_present.text.should match /More details about this file on Wikimedia Commons/ page.mmv_image_metadata_repo_link_element.when_present.attribute('href').should match /All_Hands_Offsite.*\.jpg$/ # Category links page.mmv_image_metadata_category_links_wrapper_element.when_present.should be_visible diff --git a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js index 1c81c5b72..4d682c20e 100644 --- a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js +++ b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js @@ -42,11 +42,11 @@ repoInfo = new mw.mmv.model.Repo( 'Example Wiki' ); panel.setRepoDisplay( repoInfo ); - assert.strictEqual( panel.$repo.text(), 'Learn more on Example Wiki', 'Text set to something useful for remote wiki - if this fails it might be because of localisation' ); + assert.strictEqual( panel.$repo.text(), 'More details about this file on Example Wiki', 'Text set to something useful for remote wiki - if this fails it might be because of localisation' ); repoInfo = new mw.mmv.model.Repo(); panel.setRepoDisplay( repoInfo ); - assert.strictEqual( panel.$repo.text(), 'Learn more on ' + mw.config.get( 'wgSiteName' ), 'Text set to something useful for local wiki - if this fails it might be because of localisation' ); + assert.strictEqual( panel.$repo.text(), 'More details about this file on ' + mw.config.get( 'wgSiteName' ), 'Text set to something useful for local wiki - if this fails it might be because of localisation' ); panel.setFilePageLink( 'https://commons.wikimedia.org/wiki/File:Foobar.jpg' ); assert.strictEqual( panel.$repo.prop( 'href' ), 'https://commons.wikimedia.org/wiki/File:Foobar.jpg', 'The file link was set successfully.' );