From 2f05b66988c9f5c1401639cf4a9d82655c25ecd4 Mon Sep 17 00:00:00 2001 From: Simon Legner Date: Sat, 4 May 2024 22:37:24 +0300 Subject: [PATCH] Fix Codex icon on progressive buttons in dark mode Bug: T340258 Bug: T364254 Change-Id: Ia4b7db3cfec07a83d74893d0600fd1ec1f9b772d --- resources/mmv.ui.download.pane/mmv.ui.download.pane.js | 3 ++- resources/mmv/ui/mmv.ui.stripeButtons.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/mmv.ui.download.pane/mmv.ui.download.pane.js b/resources/mmv.ui.download.pane/mmv.ui.download.pane.js index 2ee431873..e31f7c156 100644 --- a/resources/mmv.ui.download.pane/mmv.ui.download.pane.js +++ b/resources/mmv.ui.download.pane/mmv.ui.download.pane.js @@ -84,7 +84,8 @@ const { EmbedFileFormatter, Utils } = require( 'mmv.ui.ondemandshareddependencie .attr( 'target', '_blank' ) .attr( 'download', '' ) .addClass( 'cdx-button cdx-button--weight-primary cdx-button--action-progressive cdx-button--fake-button cdx-button--fake-button--enabled' ) - .html( '' + mw.message( 'multimediaviewer-download' ).text() ) + // FIXME T364254: using "notheme" here since codex does not apply @color-inverted-fixed instead of @color-inverted for progressive/destructive button + .html( '' + mw.message( 'multimediaviewer-download' ).text() ) .appendTo( $container ); } diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js b/resources/mmv/ui/mmv.ui.stripeButtons.js index 6886f452e..8f646831c 100644 --- a/resources/mmv/ui/mmv.ui.stripeButtons.js +++ b/resources/mmv/ui/mmv.ui.stripeButtons.js @@ -101,7 +101,8 @@ const UiElement = require( './mmv.ui.js' ); } $button.empty() - .append( $( '' ).addClass( 'cdx-button__icon' ) ) + // FIXME T364254: using "notheme" here since codex does not apply @color-inverted-fixed instead of @color-inverted for progressive/destructive button + .append( $( '' ).addClass( 'cdx-button__icon notheme' ) ) .append( mw.message( 'multimediaviewer-repository-local' ).text() ) .attr( 'href', descriptionUrl );