From 44865d87e67287e4f6955636e43a4560a3d8b9c1 Mon Sep 17 00:00:00 2001 From: Gilles Dubuc Date: Thu, 10 Jul 2014 15:02:25 -0400 Subject: [PATCH] Remove $.browser call in jquery.hashchange I've tested a wide variety of old browsers on sauce labs and only the older IEs reported "false" for support_onhashchange. I think the $.browser.msie check was defensive in the first place, there's no reason why a browser that doesn't support the onhashchange event wouldn't benefit from the iframe trick. Change-Id: I5b3a83118ef870237a54a6d67dd930617987abf2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/590 --- resources/jquery.hashchange/jquery.hashchange.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/resources/jquery.hashchange/jquery.hashchange.js b/resources/jquery.hashchange/jquery.hashchange.js index 1f0592bf1..d1d2be9fa 100644 --- a/resources/jquery.hashchange/jquery.hashchange.js +++ b/resources/jquery.hashchange/jquery.hashchange.js @@ -7,6 +7,9 @@ * http://benalman.com/about/license/ */ +// Forked on July 10th 2014 by Gilles Dubuc (WMF) in order to add jQuery 1.9 compatibility +// The fork was done because upstream is currently unmaintained and not responding to merge requests + // Script: jQuery hashchange event // // *Version: 1.3, Last updated: 7/21/2010* @@ -297,7 +300,7 @@ // vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv // vvvvvvvvvvvvvvvvvvv REMOVE IF NOT SUPPORTING IE6/7/8 vvvvvvvvvvvvvvvvvvv // vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv - $.browser.msie && !supports_onhashchange && (function(){ + !supports_onhashchange && (function(){ // Not only do IE6/7 need the "magical" Iframe treatment, but so does IE8 // when running in "IE7 compatibility" mode.