wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-24 08:13:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Multim.../MultimediaViewer.php

947 lines
21 KiB
PHP
Raw Normal View History

Initial commit - working demo Works with the new multilightbox library from https://gitorious.org/multilightbox/multilightbox Also has fullscreen and close. Very fun. Change-Id: I6d61f6590843e1767bc7492dbd98e6aa3b85fcdc
2013-08-07 08:59:08 +00:00
<?php
/*
* This file is part of the MediaWiki extension MultimediaViewer.
*
* MultimediaViewer is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* MultimediaViewer is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with MultimediaViewer. If not, see <http://www.gnu.org/licenses/>.
*
* @file
* @ingroup extensions
* @author Mark Holmquist <mtraceur@member.fsf.org>
* @copyright Copyright © 2013, Mark Holmquist
*/
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
if ( !isset( $wgNetworkPerformanceSamplingFactor ) ) {
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
/** @var int|bool: If set, records image load network performance via EventLogging once per this many requests. False if unset. **/
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
$wgNetworkPerformanceSamplingFactor = false;
}
Initial commit - working demo Works with the new multilightbox library from https://gitorious.org/multilightbox/multilightbox Also has fullscreen and close. Very fun. Change-Id: I6d61f6590843e1767bc7492dbd98e6aa3b85fcdc
2013-08-07 08:59:08 +00:00
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
if ( !isset( $wgMediaViewerDurationLoggingSamplingFactor ) ) {
Add sampling to unsampled event logging Has issues: - needs dependency injection - needs to be DRY - should not load mw.eventLogging when we are not in sample Due to urgency this will be fixed in another commit. Change-Id: I0df067a619109a7c945f82c8d33fa2e621217f0b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-16 18:17:52 +00:00
/**
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
* If set, records loading times via EventLogging. A value of 1000 means there will be an
* 1:1000 chance to log the duration event.
Add sampling to unsampled event logging Has issues: - needs dependency injection - needs to be DRY - should not load mw.eventLogging when we are not in sample Due to urgency this will be fixed in another commit. Change-Id: I0df067a619109a7c945f82c8d33fa2e621217f0b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-16 18:17:52 +00:00
* False if unset.
* @var int|bool
*/
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
$wgMediaViewerDurationLoggingSamplingFactor = false;
}
if ( !isset( $wgMediaViewerActionLoggingSamplingFactorMap ) ) {
/**
* If set, records user actions via EventLogging and applies a sampling factor according to the map. A "default" key in the map must be set.
* False if unset.
* @var array|bool
*/
$wgMediaViewerActionLoggingSamplingFactorMap = false;
Add sampling to unsampled event logging Has issues: - needs dependency injection - needs to be DRY - should not load mw.eventLogging when we are not in sample Due to urgency this will be fixed in another commit. Change-Id: I0df067a619109a7c945f82c8d33fa2e621217f0b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-16 18:17:52 +00:00
}
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
if ( !isset( $wgMediaViewerIsInBeta ) ) {
/** @var bool: If set, Media Viewer will try to use BetaFeatures. False if unset. **/
$wgMediaViewerIsInBeta = false;
}
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Use thumbnail guessing Change-Id: I2335af257fd23c9367b6839dfc6050840a905aa2
2014-04-10 01:08:36 +00:00
if ( !isset( $wgMediaViewerUseThumbnailGuessing ) ) {
/**
* When this is enabled, MediaViewer will try to guess image URLs instead of making an
* imageinfo API to get them from the server. This speeds up image loading, but does not
* work well with certain settings (especially $wgGenerateThumbnailOnParse == true).
* If e.g. you use non-standard thumbnail URLs, you might want to override this to false.
*
* Note that MediaViewer will catch 404 errors and do an API request when this is enabled,
* so even if it does not work with your config, there should be no visible breakage, but
* there will be a small performance hit. You have to look at network logs to checks whether
* it works or not.
*
* FIXME this should be configurable per-repo. Even if the local wiki pre-renders thumbnails,
* remotes such as Commons will work (and vice versa).
*
* @var bool
*/
$wgMediaViewerUseThumbnailGuessing = true;
}
Add site/language conditions for feedback button Only show the survey button if the user's language matches and the site is enabled, and log which site we are on. The corresponding site configuration commit is Ic07432649906890785769ce5127761e2c84316e2 Change-Id: I575bb286f4289489b80505c901f5a9e7aeecec8b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/261
2014-04-08 09:37:24 +00:00
if ( !isset( $wgMediaViewerShowSurvey ) ) {
/** @var bool: If set, MediaViewer might direct the user to a survey. **/
$wgMediaViewerShowSurvey = false;
}
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
if ( !isset( $wgEnableMediaViewerForLoggedInUsersOnly ) ) {
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
/**
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
* @var bool: If set, and $wgMediaViewerIsInBeta is unset, Media Viewer will be turned on for
* all logged-in users. False if unset.
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
*/
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
$wgEnableMediaViewerForLoggedInUsersOnly = false;
}
$wgMessagesDirs['MultimediaViewer'] = __DIR__ . '/i18n';
$wgExtensionMessagesFiles['MultimediaViewer'] = __DIR__ . '/MultimediaViewer.i18n.php';
/**
* @param string $path
* @return array
*/
$wgMediaViewerResourceTemplate = array(
'localBasePath' => __DIR__ . '/resources',
'remoteExtPath' => 'MultimediaViewer/resources',
);
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
$wgResourceModules += array(
'mmv.lightboximage' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.lightboximage.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Namespacing MMV properly Everything is under mw.mmv now. (Also, I cut down on the number of direct global instance references a bit.) Change-Id: I88bb3b62b82ce54126dd069b0aab4412d9404719
2014-02-25 02:28:49 +00:00
'dependencies' => array(
'mmv.base',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.lightboxinterface' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.lightboxinterface.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Merge MultiLightbox into LightboxInterface Change-Id: I4363095e0504dd941793ba3addc7ee3cbe835536 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-05 02:24:18 +00:00
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.lightboxinterface.less',
Merge MultiLightbox into LightboxInterface Change-Id: I4363095e0504dd941793ba3addc7ee3cbe835536 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-05 02:24:18 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'dependencies' => array(
Namespacing MMV properly Everything is under mw.mmv now. (Also, I cut down on the number of direct global instance references a bit.) Change-Id: I88bb3b62b82ce54126dd069b0aab4412d9404719
2014-02-25 02:28:49 +00:00
'mmv.base',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger',
Some refactoring to get LightboxInterface closer to a proper UI component * remove reference to MultimediaViewer * move hash handling to MultimediaViewer * make it inherit from Element, remove code duplication * cleaner event handling life cycle (register on attach, unregister on unattach) Change-Id: Ida8f68dead758a6ae3c429eb85c548af61e46801 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-04 12:52:08 +00:00
'mmv.ui',
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
'mmv.ui.canvas',
Rename Buttons to CanvasButtons Less misleading as we have lots of buttons, and I plan to add a new button class for the Commons/survey/reuse thing. Change-Id: I74194e22e9066c58f9c1eba57629458b2b9148b5
2014-03-28 00:10:04 +00:00
'mmv.ui.canvasButtons',
Add categories to the interface Also move some things around a liiiittle bit. Not too much. Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 11:13:37 +00:00
'mmv.ui.categories',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'mmv.ui.description',
'mmv.ui.fileUsage',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'mmv.ui.metadataPanel',
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ThumbnailWidthCalculator' => $wgMediaViewerResourceTemplate + array(
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.ThumbnailWidthCalculator.js',
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
),
'dependencies' => array(
'jquery.hidpi',
'mmv.base',
'mmv.model.ThumbnailWidth',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.HtmlUtils' => $wgMediaViewerResourceTemplate + array(
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.HtmlUtils.js',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
),
'dependencies' => array(
'mmv.base',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.base',
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.EmbedFileInfo' => $wgMediaViewerResourceTemplate + array(
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.EmbedFileInfo.js',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.License' => $wgMediaViewerResourceTemplate + array(
Get more license info Fetch more license information from the imageinfo API (as needed by the reuse panel), store it in a new model Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 01:19:54 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.License.js',
Get more license info Fetch more license information from the imageinfo API (as needed by the reuse panel), store it in a new model Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 01:19:54 +00:00
),
'dependencies' => array(
'mmv.model',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'mmv.HtmlUtils',
Get more license info Fetch more license information from the imageinfo API (as needed by the reuse panel), store it in a new model Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 01:19:54 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Get more license info Fetch more license information from the imageinfo API (as needed by the reuse panel), store it in a new model Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 01:19:54 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.FileUsage' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.FileUsage.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.Image' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.Image.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.model',
Get more license info Fetch more license information from the imageinfo API (as needed by the reuse panel), store it in a new model Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 01:19:54 +00:00
'mmv.model.License',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.Repo' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.Repo.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.model',
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.Thumbnail' => $wgMediaViewerResourceTemplate + array(
Add Thumbnail model Also refactor size calculation a bit - I found target/requested harder to remember. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 Change-Id: I4781cdd7004e9a8e36875c152e1d3a335a55b7d7
2014-02-05 01:06:10 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.Thumbnail.js',
Add Thumbnail model Also refactor size calculation a bit - I found target/requested harder to remember. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 Change-Id: I4781cdd7004e9a8e36875c152e1d3a335a55b7d7
2014-02-05 01:06:10 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add Thumbnail model Also refactor size calculation a bit - I found target/requested harder to remember. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 Change-Id: I4781cdd7004e9a8e36875c152e1d3a335a55b7d7
2014-02-05 01:06:10 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.ThumbnailWidth' => $wgMediaViewerResourceTemplate + array(
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.ThumbnailWidth.js',
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor thumbnail size calculation * moves generic logic into ThumbnailSizeCalculator class * moves UI-specific logic into interface class * fixes bug where non-bucketed sizes were served on devices with non-standard pixel density * fixes bug where bucketed size was compared to css size instead of screen size for resizing Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-06 23:18:47 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.User' => $wgMediaViewerResourceTemplate + array(
Preload prev/next images When the lightbox is opened, or prev/next pressed, preloads the previous/next N images. Technical debt introduced: * initialization is a mess, with the viewer and the interface randomly setting properties on each other in different phases of execution. That got in the way and I shuffled things around until they worked, which is obviously not the way to have a robust system, but hopefully it will get scrapped soon anyway in favor of a clean top-down dependency injection. Change-Id: Idcb5c40de1ac0b3e482decd66e56c4de8ec71b6b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155
2014-02-13 09:52:40 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.User.js',
Preload prev/next images When the lightbox is opened, or prev/next pressed, preloads the previous/next N images. Technical debt introduced: * initialization is a mess, with the viewer and the interface randomly setting properties on each other in different phases of execution. That got in the way and I shuffled things around until they worked, which is obviously not the way to have a robust system, but hopefully it will get scrapped soon anyway in favor of a clean top-down dependency injection. Change-Id: Idcb5c40de1ac0b3e482decd66e56c4de8ec71b6b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155
2014-02-13 09:52:40 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Preload prev/next images When the lightbox is opened, or prev/next pressed, preloads the previous/next N images. Technical debt introduced: * initialization is a mess, with the viewer and the interface randomly setting properties on each other in different phases of execution. That got in the way and I shuffled things around until they worked, which is obviously not the way to have a robust system, but hopefully it will get scrapped soon anyway in favor of a clean top-down dependency injection. Change-Id: Idcb5c40de1ac0b3e482decd66e56c4de8ec71b6b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155
2014-02-13 09:52:40 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.model.TaskQueue' => $wgMediaViewerResourceTemplate + array(
Add TaskQueue class A simple task queue which can be processed or cancelled. Will be used to handle preloading in a more robust way. Change-Id: Ib33f9b2d814a35538f9d4f3691fce5ba5cdc82c1
2014-02-10 21:24:19 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/model/mmv.model.TaskQueue.js',
Add TaskQueue class A simple task queue which can be processed or cancelled. Will be used to handle preloading in a more robust way. Change-Id: Ib33f9b2d814a35538f9d4f3691fce5ba5cdc82c1
2014-02-10 21:24:19 +00:00
),
'dependencies' => array(
'mmv.model',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add TaskQueue class A simple task queue which can be processed or cancelled. Will be used to handle preloading in a more robust way. Change-Id: Ib33f9b2d814a35538f9d4f3691fce5ba5cdc82c1
2014-02-10 21:24:19 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.provider' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/provider/mmv.provider.Api.js',
'mmv/provider/mmv.provider.ImageUsage.js',
'mmv/provider/mmv.provider.GlobalUsage.js',
'mmv/provider/mmv.provider.ImageInfo.js',
'mmv/provider/mmv.provider.FileRepoInfo.js',
'mmv/provider/mmv.provider.ThumbnailInfo.js',
Guess thumbnail URLs without extra API call Given a sample thumbnail URL and the original width/height this provider tries to guess the thumbnail url for a given size. Change-Id: I2966b60978ab763864475851d8a79370bd422dc4
2014-04-09 08:10:21 +00:00
'mmv/provider/mmv.provider.GuessedThumbnailInfo.js',
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/provider/mmv.provider.UserInfo.js',
'mmv/provider/mmv.provider.Image.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mediawiki.Title',
'mmv.model',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'mmv.model.FileUsage',
'mmv.model.Image',
'mmv.model.Repo',
'mmv.model.Thumbnail',
'mmv.model.User',
Use provider XHR information in performance metrics + several fixes * more robust method of obtaining URL * decouple performance logging from providers (mostly) * ignore fake XHR object which jQuery returns for JSONP requests * guard for CORS requests - apparently Chrome refuses to return certain information even with an Allow-Origin: * response header. * Resource Timing is limited to 150 results, which causes fake misses in debug mode. There is an API to increase the limit but it is not implemented in Chrome. I am calling it nevertheless, maybe IE understands it (it is present in the MSDN docs at least). This seems to work for AJAX, CORS, JSONP, image AJAX; CORS requests return 0 for a lot of values, per spec a Timing-Allow-Origin: * header might help that. Change-Id: I8353858022f51a7e70774e65513d0fa2554a5064
2014-02-15 02:15:54 +00:00
'mmv.performance',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'oojs',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Add routing classes Adds a Route class hierarchy for various URL schemes and a Router class to convert Route classes to and from URLs. Right now we only have two(-ish) schemes, but in the future we want to be able to show related images which are not present on the current page and need shareable URLs for those as well; also we might want to specify other things in the URL than the current image (the reuse box being open was one thing discussed); this will be a good framework to add features like that. The MainFileRoute class will be used by #416. Change-Id: I489126a0ada37f91a22a2f48a4e686140a28d162 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371
2014-04-14 18:32:30 +00:00
'mmv.routing' => $wgMediaViewerResourceTemplate + array(
Replace deprecated jQuery.browser with jQuery.client jQuery.browser is deprecated. jQuery.client is a core RL module. Bug: 65371 Change-Id: I040cfba574fa0514a25ec5166d82d86f6f697441
2014-05-16 18:27:13 +00:00
'scripts' => array(
'mmv/routing/mmv.routing.js',
'mmv/routing/mmv.routing.Route.js',
'mmv/routing/mmv.routing.ThumbnailRoute.js',
'mmv/routing/mmv.routing.MainFileRoute.js',
'mmv/routing/mmv.routing.Router.js',
),
'dependencies' => array(
'mediawiki.Title',
'oojs',
),
Add routing classes Adds a Route class hierarchy for various URL schemes and a Router class to convert Route classes to and from URLs. Right now we only have two(-ish) schemes, but in the future we want to be able to show related images which are not present on the current page and need shareable URLs for those as well; also we might want to specify other things in the URL than the current image (the reuse box being open was one thing discussed); this will be a good framework to add features like that. The MainFileRoute class will be used by #416. Change-Id: I489126a0ada37f91a22a2f48a4e686140a28d162 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371
2014-04-14 18:32:30 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.base' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.base.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Replace deprecated jQuery.browser with jQuery.client jQuery.browser is deprecated. jQuery.client is a core RL module. Bug: 65371 Change-Id: I040cfba574fa0514a25ec5166d82d86f6f697441
2014-05-16 18:27:13 +00:00
'dependencies' => array(
'jquery.client',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.base',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.canvas' => $wgMediaViewerResourceTemplate + array(
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.canvas.js',
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.canvas.less',
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
),
Handle image loading rejections Displays the rejection error message when loading something fails, so that the user knows what's going on and can send meaningful error reports. Needs non-crappy design. Change-Id: I7d2914d89549b598bd1070ed40c6f1c9d45b55f0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/271
2014-03-01 01:10:51 +00:00
'messages' => array(
'multimediaviewer-thumbnail-error',
),
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
'dependencies' => array(
'mmv.ui',
'mmv.ThumbnailWidthCalculator',
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Fix resize issues (Part II) I was going to stage this but better give you the whole enchilada, it is not that bad, ;-). This is what I am doing: - Delete things that are not used anymore. - Componentize image ui element (Canvas). Bug: 56454 Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00 Mingle: 239
2014-02-26 20:09:37 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.categories' => $wgMediaViewerResourceTemplate + array(
Add categories to the interface Also move some things around a liiiittle bit. Not too much. Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 11:13:37 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.categories.js',
Add categories to the interface Also move some things around a liiiittle bit. Not too much. Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 11:13:37 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.categories.less',
Add categories to the interface Also move some things around a liiiittle bit. Not too much. Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 11:13:37 +00:00
),
'dependencies' => array(
'mmv.ui',
'oojs',
),
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'messages' => array(
'comma-separator',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add categories to the interface Also move some things around a liiiittle bit. Not too much. Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 11:13:37 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.stripeButtons' => $wgMediaViewerResourceTemplate + array(
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.stripeButtons.js',
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.stripeButtons.less',
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
),
'dependencies' => array(
Add mediawiki.jqueryMsg as a dependency for mmv.ui.fileUsage The Hebrew translation of a message there uses GRAMMAR, so this module is needed. Change-Id: I1ffe9a936a071709e7049bc0ffec77123cb42fd1
2014-04-22 19:35:16 +00:00
'mediawiki.jqueryMsg',
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
'mmv.ui',
'oojs',
Add tooltips to metadata buttons Quick and dirty solution via tipsy, can be improved later. Change-Id: I717b45d9800dbabdaf7d52d1d377f6f6958abdf7
2014-04-02 00:39:54 +00:00
'jquery.tipsy',
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
),
Feedback button MVP implementation, just a link that opens the survey in a new tab Change-Id: I9f2fb85cc47ce2be4cf57679bf37f0bda13084b7
2014-04-01 19:02:33 +00:00
'messages' => array(
'multimediaviewer-feedback-button-text',
'multimediaviewer-feedback-popup-text',
Add metadata button to go to file description page directly Change-Id: I0f2c2b24aece3b806d572a0ed41dce8031e6ae6b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/226
2014-04-02 00:07:51 +00:00
'multimediaviewer-description-page-button-text',
'multimediaviewer-description-page-popup-text',
'multimediaviewer-description-page-popup-text-local',
Hide metadata top button texts Also make sure that the reuse dialog is positioned right, no matter where its button is. Also fixes some minor documentation problem with mw.mmv.ui.canvas which I noticed in the process. Change-Id: I86feed07738ebef012e63861ed909f3449b85a53
2014-04-02 01:58:41 +00:00
'multimediaviewer-reuse-link',
Feedback button MVP implementation, just a link that opens the survey in a new tab Change-Id: I9f2fb85cc47ce2be4cf57679bf37f0bda13084b7
2014-04-01 19:02:33 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.description' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.description.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
'mmv.ui',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'mmv.HtmlUtils',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.fileUsage' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.fileUsage.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.fileUsage.less',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'mediawiki.language',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'mediawiki.Uri',
'mediawiki.jqueryMsg',
'mmv.ui',
'oojs',
),
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'messages' => array(
'multimediaviewer-fileusage-count',
'multimediaviewer-fileusage-count-more',
'multimediaviewer-fileusage-link',
'multimediaviewer-fileusage-local-section',
'multimediaviewer-fileusage-global-section',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.permission' => $wgMediaViewerResourceTemplate + array(
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.permission.js',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.permission.less',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
),
'messages' => array(
'multimediaviewer-permission-title',
Make it obvious that the permission text is cut off; add expand link Fades out the bottom of the text and adds a link to replace it with the full HTML version. Due to the way it is positioned, the fade + link will be invisible if the text is less then 3 lines. The implementation is not very polished; since this will be replaced by some JS-based ellipsis thing, I didn't want to spend too much time on it. Change-Id: Ib30e40fe845b85bfcf9557970efb886d28b3e5c7 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-26 02:47:24 +00:00
'multimediaviewer-permission-viewmore',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
),
'dependencies' => array(
'jquery.color',
'mediawiki.jqueryMsg',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
'mmv.ui',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'mmv.HtmlUtils',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
Add truncatable text field, use for some fields Source + author are one such field, title is another. Loads of the mingle card will be split out. Change-Id: Ib2937cc55304118f82e5b2e87b822b2b2811ef2b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/243
2014-03-27 06:05:47 +00:00
'mmv.ui.truncatableTextField' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'mmv/ui/mmv.ui.truncatableTextField.js',
),
'styles' => array(
'mmv/ui/mmv.ui.truncatableTextField.less',
),
'dependencies' => array(
'mmv.HtmlUtils',
'mmv.ui',
'oojs',
),
),
Split the progress bar into a component of its own. Change-Id: I131b0d1b8ec992a7c7ad388021febea5a0303d16
2014-04-21 21:48:40 +00:00
'mmv.ui.progressBar' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'mmv/ui/mmv.ui.progressBar.js',
),
'styles' => array(
'mmv/ui/mmv.ui.progressBar.less',
),
'dependencies' => array(
'mmv.ui',
'oojs',
),
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.metadataPanel' => $wgMediaViewerResourceTemplate + array(
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.metadataPanel.js',
Extract metadata panel scroll/log/animate logic into separate component Change-Id: I2441d64c094a9bfbae7a4712ff4c78efa13a62a7
2014-05-05 21:44:27 +00:00
'mmv/ui/mmv.ui.metadataPanelScroller.js',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.metadataPanel.less',
Extract metadata panel scroll/log/animate logic into separate component Change-Id: I2441d64c094a9bfbae7a4712ff4c78efa13a62a7
2014-05-05 21:44:27 +00:00
'mmv/ui/mmv.ui.metadataPanelScroller.less',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
),
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'dependencies' => array(
Add truncatable text field, use for some fields Source + author are one such field, title is another. Loads of the mingle card will be split out. Change-Id: Ib2937cc55304118f82e5b2e87b822b2b2811ef2b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/243
2014-03-27 06:05:47 +00:00
'mmv.HtmlUtils',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'mmv.ui',
Split the progress bar into a component of its own. Change-Id: I131b0d1b8ec992a7c7ad388021febea5a0303d16
2014-04-21 21:48:40 +00:00
'mmv.ui.progressBar',
Create StripeButtons class, convert reuse button to use it Also do a bunch of refactoring to: * keep LESS rules in more sane locations so it is not as hard to get an overview (most of the metadata panel rules were in mmv.less) * move mmv.mixins.less up one directory as it is not specific to the UI * move the SVG icons as all of them were related to the UI * remove the marging-right hack which was used to keep the title text from overflowing the button; instead use a float and overflow properties to make sure text that is too long gets hidden Change-Id: Icc8ea2e766be67d86ae98c734721b2185bd6c36e
2014-04-01 01:41:57 +00:00
'mmv.ui.stripeButtons',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'mmv.ui.categories',
'mmv.ui.description',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
'mmv.ui.fileUsage',
'mmv.ui.permission',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'mmv.ui.reuse.dialog',
Add truncatable text field, use for some fields Source + author are one such field, title is another. Loads of the mingle card will be split out. Change-Id: Ib2937cc55304118f82e5b2e87b822b2b2811ef2b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/243
2014-03-27 06:05:47 +00:00
'mmv.ui.truncatableTextField',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'oojs',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
'messages' => array(
'multimediaviewer-repository',
'multimediaviewer-repository-local',
Make Commons link more prominent Change-Id: Id546de9671fdc00ba73b01a1bc6398f2da2a6a2b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/270
2014-04-08 22:43:54 +00:00
'multimediaviewer-commons-subtitle',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'multimediaviewer-credit',
'multimediaviewer-userpage-link',
'multimediaviewer-datetime-created',
'multimediaviewer-datetime-uploaded',
Show permission Change-Id: I0b8b0626b36baba9732f7350213d8b53ec2cca95 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118
2014-02-14 00:36:10 +00:00
// for license messages see end of file
'multimediaviewer-permission-link',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'multimediaviewer-geoloc-north',
'multimediaviewer-geoloc-east',
'multimediaviewer-geoloc-south',
'multimediaviewer-geoloc-west',
'multimediaviewer-geoloc-coord',
'multimediaviewer-geoloc-coords',
'multimediaviewer-geolocation',
'multimediaviewer-about-mmv',
'multimediaviewer-discuss-mmv',
Adds help link Pointing to //mediawiki.org/wiki/Special:MyLanguage/Multimedia/About_Media_Viewer/Help Change-Id: I90747e269e07dd27a4fa21470ec1563518177bb2
2014-03-24 13:35:34 +00:00
'multimediaviewer-help-mmv',
Handle image loading rejections Displays the rejection error message when loading something fails, so that the user knows what's going on and can send meaningful error reports. Needs non-crappy design. Change-Id: I7d2914d89549b598bd1070ed40c6f1c9d45b55f0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/271
2014-03-01 01:10:51 +00:00
Add preferences link after "help" Reused message from the top-right menu. Change-Id: Id37712e332bf8fed56edaa9ae8f7e04a2a5a5f42
2014-04-23 20:31:43 +00:00
// Reuse the preferences message in the top-right menu.
'mypreferences',
Handle image loading rejections Displays the rejection error message when loading something fails, so that the user knows what's going on and can send meaningful error reports. Needs non-crappy design. Change-Id: I7d2914d89549b598bd1070ed40c6f1c9d45b55f0 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/271
2014-03-01 01:10:51 +00:00
'multimediaviewer-metadata-error',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.embedFileFormatter' => $wgMediaViewerResourceTemplate + array(
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.EmbedFileFormatter.js',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
'dependencies' => array(
'mmv.base',
Replace current URL generation logic with routing classes * deduplicates URL generating/parsing code * gets rid of spaces in URLs * fixes error for file names with / in them (in case they exist; current MediaWiki seems to disallow such names anyway) Change-Id: I5aad43f6af1b99523c597c39befcc9db1ecab83a Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371
2014-04-14 23:22:28 +00:00
'mmv.routing',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'oojs',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'mmv.HtmlUtils',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
'messages' => array(
'multimediaviewer-credit',
'multimediaviewer-html-embed-credit-text-tbls',
'multimediaviewer-html-embed-credit-text-tls',
'multimediaviewer-html-embed-credit-text-tbs',
'multimediaviewer-html-embed-credit-text-tbl',
'multimediaviewer-html-embed-credit-text-tb',
'multimediaviewer-html-embed-credit-text-ts',
'multimediaviewer-html-embed-credit-text-tl',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.dialog' => $wgMediaViewerResourceTemplate + array(
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.dialog.js',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.dialog.less',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
),
'dependencies' => array(
'mmv.ui',
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.utils' => $wgMediaViewerResourceTemplate + array(
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.utils.js',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
),
'dependencies' => array(
'mmv.HtmlUtils',
'mmv.ui',
'oojs',
'oojs-ui',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.tab' => $wgMediaViewerResourceTemplate + array(
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.tab.js',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
'dependencies' => array(
'mmv.ui',
'oojs',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.share' => $wgMediaViewerResourceTemplate + array(
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.share.js',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.share.less',
'mmv/ui/mmv.ui.reuse.shareembed.less',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
),
'dependencies' => array(
'mmv.ui.reuse.tab',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
'mmv.ui.reuse.utils',
Replace current URL generation logic with routing classes * deduplicates URL generating/parsing code * gets rid of spaces in URLs * fixes error for file names with / in them (in case they exist; current MediaWiki seems to disallow such names anyway) Change-Id: I5aad43f6af1b99523c597c39befcc9db1ecab83a Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371
2014-04-14 23:22:28 +00:00
'mmv.routing',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'oojs',
'oojs-ui',
),
'messages' => array(
Fix some text selection issues with share/embed Change-Id: Ic9d330c04d4e9335cdfce6e99870d1e5877b2a90 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/374
2014-03-19 22:35:55 +00:00
'multimediaviewer-reuse-loading-placeholder',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'multimediaviewer-share-tab',
Add explanatory one-liners to share & embed Change-Id: Id8eb7020296004dae83d63c37393c29142928dd6 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/379
2014-03-26 13:34:44 +00:00
'multimediaviewer-share-explanation',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'multimediaviewer-link-to-file',
'multimediaviewer-link-to-page',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.embed' => $wgMediaViewerResourceTemplate + array(
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.embed.js',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.embed.less',
'mmv/ui/mmv.ui.reuse.shareembed.less',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
'dependencies' => array(
'mmv.ui.reuse.tab',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
'mmv.ui.reuse.utils',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'oojs',
'oojs-ui',
'mmv.model.EmbedFileInfo',
'mmv.embedFileFormatter',
),
'messages' => array(
Fix some text selection issues with share/embed Change-Id: Ic9d330c04d4e9335cdfce6e99870d1e5877b2a90 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/374
2014-03-19 22:35:55 +00:00
'multimediaviewer-reuse-loading-placeholder',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'multimediaviewer-embed-tab',
'multimediaviewer-embed-html',
'multimediaviewer-embed-wt',
Add explanatory one-liners to share & embed Change-Id: Id8eb7020296004dae83d63c37393c29142928dd6 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/379
2014-03-26 13:34:44 +00:00
'multimediaviewer-embed-explanation',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
'multimediaviewer-embed-byline',
'multimediaviewer-embed-license',
'multimediaviewer-embed-via',
Makes the size information (WxH) in Embed lighter Change-Id: I54ccafd81967eb682a2e10e9a0b9ef6c92e2806f
2014-03-24 14:44:41 +00:00
'multimediaviewer-default-embed-dimensions',
'multimediaviewer-original-embed-dimensions',
'multimediaviewer-large-embed-dimensions',
'multimediaviewer-medium-embed-dimensions',
'multimediaviewer-small-embed-dimensions',
'multimediaviewer-embed-dimensions',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
'multimediaviewer-embed-dimensions-separated',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.reuse.download' => $wgMediaViewerResourceTemplate + array(
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.download.js',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.reuse.download.less',
Download tab, basic download and preview * Following design, use split button to display a pulldown menu with possible image sizes. The download happens by sending the special "download" parameter to the server. * Offer link to preview image in the browser. Change-Id: Ic9d895fead04c9128186c7376a0bb09f3596335c Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79
2014-03-31 16:08:02 +00:00
),
'dependencies' => array(
'mediawiki.ui',
'mediawiki.ui.button',
'mmv.ui.reuse.tab',
'mmv.ui.reuse.utils',
),
'messages' => array(
'multimediaviewer-download-tab',
'multimediaviewer-download-preview-link-title',
'multimediaviewer-download-original-button-name',
'multimediaviewer-download-small-button-name',
'multimediaviewer-download-medium-button-name',
'multimediaviewer-download-large-button-name',
'multimediaviewer-embed-dimensions',
'multimediaviewer-embed-dimensions-with-file-format',
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Add embed tab to reuse dialog Implements the wikitext part of the mingle card Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 02:00:26 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.ui.canvasButtons' => $wgMediaViewerResourceTemplate + array(
Refactor button things into a separate class https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ib4b54164bccbe17e42b223880179531e8d9e6123
2014-02-04 23:44:36 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.canvasButtons.js',
Refactor button things into a separate class https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ib4b54164bccbe17e42b223880179531e8d9e6123
2014-02-04 23:44:36 +00:00
),
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/ui/mmv.ui.canvasButtons.less',
Refactor button things into a separate class https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ib4b54164bccbe17e42b223880179531e8d9e6123
2014-02-04 23:44:36 +00:00
),
'dependencies' => array(
'mmv.ui',
'oojs',
),
Add "zoom" but really just view-file The zoom icon should get replaced Real Soon Now - looking at you, pginer Change-Id: I88c1d4fb95e034e0f2fe618eb7309754ea1c283e
2014-06-10 20:39:10 +00:00
'messages' => array(
'multimediaviewer-viewfile-link',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor button things into a separate class https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ib4b54164bccbe17e42b223880179531e8d9e6123
2014-02-04 23:44:36 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.logger' => $wgMediaViewerResourceTemplate + array(
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
'scripts' => array(
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv/mmv.Logger.js',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
'dependencies' => array(
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
'mmv.base',
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Refactor panel-related things into another class mmv.lightboxinterface was getting way too clunky. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 14:47:00 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.performance' => $wgMediaViewerResourceTemplate + array(
Track detailed content loading network performance Leverages the W3C Navigation Timing API when available Change-Id: Ief1d327d1bd8928bf5f2bf0bd4c7141a0a608a53 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126
2014-02-06 16:17:38 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.performance.js',
Track detailed content loading network performance Leverages the W3C Navigation Timing API when available Change-Id: Ief1d327d1bd8928bf5f2bf0bd4c7141a0a608a53 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126
2014-02-06 16:17:38 +00:00
),
'dependencies' => array(
Get rid of lightboxHooks Delete lightboxHooks, since most of them haven't proven to be useful. Replace the useful ones by jQuery events. Change-Id: I28f99ba85666ca15979feb5c637924b98bba27a8 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176
2014-02-11 13:25:39 +00:00
'mmv.base',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.logger',
'oojs',
Track detailed content loading network performance Leverages the W3C Navigation Timing API when available Change-Id: Ief1d327d1bd8928bf5f2bf0bd4c7141a0a608a53 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126
2014-02-06 16:17:38 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Track detailed content loading network performance Leverages the W3C Navigation Timing API when available Change-Id: Ief1d327d1bd8928bf5f2bf0bd4c7141a0a608a53 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126
2014-02-06 16:17:38 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.api' => $wgMediaViewerResourceTemplate + array(
Use provider XHR information in performance metrics + several fixes * more robust method of obtaining URL * decouple performance logging from providers (mostly) * ignore fake XHR object which jQuery returns for JSONP requests * guard for CORS requests - apparently Chrome refuses to return certain information even with an Allow-Origin: * response header. * Resource Timing is limited to 150 results, which causes fake misses in debug mode. There is an API to increase the limit but it is not implemented in Chrome. I am calling it nevertheless, maybe IE understands it (it is present in the MSDN docs at least). This seems to work for AJAX, CORS, JSONP, image AJAX; CORS requests return 0 for a lot of values, per spec a Timing-Allow-Origin: * header might help that. Change-Id: I8353858022f51a7e70774e65513d0fa2554a5064
2014-02-15 02:15:54 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.api.js',
Use provider XHR information in performance metrics + several fixes * more robust method of obtaining URL * decouple performance logging from providers (mostly) * ignore fake XHR object which jQuery returns for JSONP requests * guard for CORS requests - apparently Chrome refuses to return certain information even with an Allow-Origin: * response header. * Resource Timing is limited to 150 results, which causes fake misses in debug mode. There is an API to increase the limit but it is not implemented in Chrome. I am calling it nevertheless, maybe IE understands it (it is present in the MSDN docs at least). This seems to work for AJAX, CORS, JSONP, image AJAX; CORS requests return 0 for a lot of values, per spec a Timing-Allow-Origin: * header might help that. Change-Id: I8353858022f51a7e70774e65513d0fa2554a5064
2014-02-15 02:15:54 +00:00
),
'dependencies' => array(
'mediawiki.api',
'mmv.base',
Missing dependency Change-Id: I8ce510883e13401d9b1464b1583ee11d01f40df6
2014-02-19 14:41:40 +00:00
'oojs',
Use provider XHR information in performance metrics + several fixes * more robust method of obtaining URL * decouple performance logging from providers (mostly) * ignore fake XHR object which jQuery returns for JSONP requests * guard for CORS requests - apparently Chrome refuses to return certain information even with an Allow-Origin: * response header. * Resource Timing is limited to 150 results, which causes fake misses in debug mode. There is an API to increase the limit but it is not implemented in Chrome. I am calling it nevertheless, maybe IE understands it (it is present in the MSDN docs at least). This seems to work for AJAX, CORS, JSONP, image AJAX; CORS requests return 0 for a lot of values, per spec a Timing-Allow-Origin: * header might help that. Change-Id: I8353858022f51a7e70774e65513d0fa2554a5064
2014-02-15 02:15:54 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Use provider XHR information in performance metrics + several fixes * more robust method of obtaining URL * decouple performance logging from providers (mostly) * ignore fake XHR object which jQuery returns for JSONP requests * guard for CORS requests - apparently Chrome refuses to return certain information even with an Allow-Origin: * response header. * Resource Timing is limited to 150 results, which causes fake misses in debug mode. There is an API to increase the limit but it is not implemented in Chrome. I am calling it nevertheless, maybe IE understands it (it is present in the MSDN docs at least). This seems to work for AJAX, CORS, JSONP, image AJAX; CORS requests return 0 for a lot of values, per spec a Timing-Allow-Origin: * header might help that. Change-Id: I8353858022f51a7e70774e65513d0fa2554a5064
2014-02-15 02:15:54 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv' => $wgMediaViewerResourceTemplate + array(
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.js',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'styles' => array(
Wait for CSS to be truly loaded before opening the viewer This is a workaround for core bug #61852 Change-Id: If7d830866993eddbf5784694514ff89aece56c5b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258
2014-02-24 17:06:11 +00:00
// Always make this one the last of the list (Bug 61852)
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.loaded.css',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'dependencies' => array(
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'mmv.api',
Namespacing MMV properly Everything is under mw.mmv now. (Also, I cut down on the number of direct global instance references a bit.) Change-Id: I88bb3b62b82ce54126dd069b0aab4412d9404719
2014-02-25 02:28:49 +00:00
'mmv.base',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'mmv.lightboximage',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'mmv.model.TaskQueue',
'mmv.lightboxinterface',
'mmv.provider',
Replace current URL generation logic with routing classes * deduplicates URL generating/parsing code * gets rid of spaces in URLs * fixes error for file names with / in them (in case they exist; current MediaWiki seems to disallow such names anyway) Change-Id: I5aad43f6af1b99523c597c39befcc9db1ecab83a Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/371
2014-04-14 23:22:28 +00:00
'mmv.routing',
Adds new performance metrics - duration between early click and replayed click - duration between replayed/post-replay click and first image display - duration between replayed/post-replay click and first metadata display Change-Id: Ia308db7580fd89538b9a9c8b0fea89fa2a4c77d2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/515 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508
2014-04-28 16:11:55 +00:00
'mmv.DurationLogger',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
'jquery.fullscreen',
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'jquery.hidpi',
'jquery.scrollTo',
Move jquery.throttle-debounce to core Depends on core change I008f46cc97af10e93ad9cad35924aaf251b99aa6 (merged) Change-Id: I0c5faa4b20274a61d95aa2067f1071d2ab462454
2014-02-12 21:30:18 +00:00
'jquery.throttle-debounce',
Add share panel, replace reuse Mingle: 147 Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-17 08:07:53 +00:00
'jquery.hidpi',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
'messages' => array(
'multimediaviewer-file-page',
'multimediaviewer-desc-nil',
Skip userinfo request if no message depends on the gender. Change-Id: I85bc617efc87ed1c4526eb74470bb6182910d9fc Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/435
2014-04-20 03:35:54 +00:00
// messages that are gender-dependent (we need to check if they really depend on the gender):
'multimediaviewer-userpage-link',
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.bootstrap' => $wgMediaViewerResourceTemplate + array(
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.bootstrap.js',
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
),
Display black overlay while the viewer JS is loading I went for this option because it was the fastest to implement. I think we should wait until we make the change to core to expose image dimensions before we consider switching to another strategy. Change-Id: I61c9342a2d6d6fc24a24e0988b3cf7f9a06859a2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/248
2014-03-28 08:06:53 +00:00
'styles' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.bootstrap.less',
Display black overlay while the viewer JS is loading I went for this option because it was the fastest to implement. I think we should wait until we make the change to core to expose image dimensions before we consider switching to another strategy. Change-Id: I61c9342a2d6d6fc24a24e0988b3cf7f9a06859a2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/248
2014-03-28 08:06:53 +00:00
),
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
'dependencies' => array(
Loads of fix-ups to our module definitions I suspected the performance -> eventlogging dependencies were wrong and took the opportunity to fix all the things. Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-07 23:53:23 +00:00
'jquery.hashchange',
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
'mediawiki.Title',
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger',
Utilities to transform HTML to plain or filtered text This takes care of several minor annoyances: * centralizes all the text processing functions which have been floating all around the code, and adds proper tests * filters out invisible elements (sometimes used for metadata) * avoids merging separate words on HTML->text transformation * adds caching since doing all this transformations could be processing-intensive for big chunks of HTML. (This might or might not be a good idea. I haven't done performance tests, so this might be premature optimization, and increases memory use. OTOH these functions are often called in situations where an immediate UI response is expected (such as selecting a size from the list) so even small delays would be perceivable. Bug: 63126 Change-Id: I1ef1e3a33efdfea17612df00da6b629bf39e07aa Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/388 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-26 23:59:04 +00:00
'mmv.HtmlUtils',
Adds new performance metrics - duration between early click and replayed click - duration between replayed/post-replay click and first image display - duration between replayed/post-replay click and first metadata display Change-Id: Ia308db7580fd89538b9a9c8b0fea89fa2a4c77d2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/515 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508
2014-04-28 16:11:55 +00:00
'mmv.DurationLogger',
Restore article scroll after closing Media Viewer There used to be a CSS trick with the order we added things to the page and removed them from it, but it doesn't seem possible anymore with the new order of execution, with the overlay appearing immediately and being taken care of inside bootstrap. The main cause of the bug, however, was the hash reset happening after the interface was closed. Doing the scroll restore with jQuery.scrollTo is more future-proof and testable in QUnit. Additions were also made to the cucumber E2E test because QUnit alone wouldn't have caught the hash issue. This also cleans up custom events a little and reintroduces pushState on browsers that support the history API. Change-Id: I63187383b632a2e8793f05380c18db2713856865 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/439 Bug: 63892
2014-04-11 09:31:38 +00:00
'jquery.scrollTo',
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
),
Open MMV on hash change on file pages, add link Change-Id: I4aa53d50bcd4880f341dfb59b7a451e2d5bda2ad
2014-04-08 21:01:07 +00:00
'messages' => array(
'multimediaviewer-view-expanded',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Lazy-load mmv Also removes the index inside the location hash Change-Id: I9429ff0101ab891f2c4c6aa2d989fbef0813252d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136
2014-02-17 15:09:23 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.bootstrap.autostart' => $wgMediaViewerResourceTemplate + array(
Get rid of global viewer instance - split event handler setup out of bootstrap and viewer creation - simplify the tests setup/teardown Change-Id: Icde1db81efd6191207ba35757192c800ea2d2e91 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278
2014-03-04 11:53:53 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.bootstrap.autostart.js',
Get rid of global viewer instance - split event handler setup out of bootstrap and viewer creation - simplify the tests setup/teardown Change-Id: Icde1db81efd6191207ba35757192c800ea2d2e91 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278
2014-03-04 11:53:53 +00:00
),
'dependencies' => array(
'mmv.base',
'mmv.bootstrap',
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
Get rid of global viewer instance - split event handler setup out of bootstrap and viewer creation - simplify the tests setup/teardown Change-Id: Icde1db81efd6191207ba35757192c800ea2d2e91 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278
2014-03-04 11:53:53 +00:00
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.ActionLogger' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'mmv/mmv.ActionLogger.js',
),
'dependencies' => array(
'mmv.base',
'mmv.logger',
'oojs'
)
),
Adds new performance metrics - duration between early click and replayed click - duration between replayed/post-replay click and first image display - duration between replayed/post-replay click and first metadata display Change-Id: Ia308db7580fd89538b9a9c8b0fea89fa2a4c77d2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/515 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508
2014-04-28 16:11:55 +00:00
'mmv.DurationLogger' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'mmv/mmv.DurationLogger.js',
),
'dependencies' => array(
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.base',
'mmv.logger',
'oojs'
Adds new performance metrics - duration between early click and replayed click - duration between replayed/post-replay click and first image display - duration between replayed/post-replay click and first metadata display Change-Id: Ia308db7580fd89538b9a9c8b0fea89fa2a4c77d2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/515 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508
2014-04-28 16:11:55 +00:00
)
),
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv.head' => $wgMediaViewerResourceTemplate + array(
Replay early thumb link clicks when bootstrap is ready to receive them Change-Id: I1ccd7c2cb949a051e3078fc746bc79254cc36a1d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/391
2014-03-28 22:39:36 +00:00
'scripts' => array(
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
'mmv/mmv.head.js',
Replay early thumb link clicks when bootstrap is ready to receive them Change-Id: I1ccd7c2cb949a051e3078fc746bc79254cc36a1d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/391
2014-03-28 22:39:36 +00:00
),
Disable IE < 9 At the moment issues in core are preventing Media Viewer from working on IE < 9. Let's disable it in those browsers for now. Change-Id: Icdd29f3c00fb8eeb3d463e8b8718d54d6cd01a23
2014-03-31 15:04:53 +00:00
'dependencies' => array(
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
'mmv.base'
Disable IE < 9 At the moment issues in core are preventing Media Viewer from working on IE < 9. Let's disable it in those browsers for now. Change-Id: Icdd29f3c00fb8eeb3d463e8b8718d54d6cd01a23
2014-03-31 15:04:53 +00:00
),
Replay early thumb link clicks when bootstrap is ready to receive them Change-Id: I1ccd7c2cb949a051e3078fc746bc79254cc36a1d Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/391
2014-03-28 22:39:36 +00:00
'position' => 'top',
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
),
'jquery.scrollTo' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'jquery.scrollTo/jquery.scrollTo.js',
),
),
'jquery.hashchange' => $wgMediaViewerResourceTemplate + array(
'scripts' => array(
'jquery.hashchange/jquery.hashchange.js',
),
),
);
Move providers into their own subdirectory Also refactor MultimediaViewer.php a bit to get rid of all the globals. Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-01-31 00:06:33 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
$wgExtensionFunctions[] = function () {
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
global $wgResourceModules, $wgEventLoggingSchemas;
Add feature flags for Media Viewer $wgMediaViewerIsInBeta is one, $wgEnableMediaViewerForLoggedInUsers is the other - use the former on all sites, the latter on pilot sites in April. Before merging, MERGE https://gerrit.wikimedia.org/r/117376 Change-Id: I232997918dee4a00be18c021eb351d81609df2b0
2014-03-07 01:56:56 +00:00
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
if ( isset( $wgResourceModules['ext.eventLogging'] ) ) {
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
$wgEventLoggingSchemas[ 'MediaViewer' ] = 8572637;
$wgEventLoggingSchemas[ 'MultimediaViewerNetworkPerformance' ] = 7917896;
$wgEventLoggingSchemas[ 'MultimediaViewerDuration' ] = 8572641;
Add feature flags for Media Viewer $wgMediaViewerIsInBeta is one, $wgEnableMediaViewerForLoggedInUsers is the other - use the former on all sites, the latter on pilot sites in April. Before merging, MERGE https://gerrit.wikimedia.org/r/117376 Change-Id: I232997918dee4a00be18c021eb351d81609df2b0
2014-03-07 01:56:56 +00:00
Record sampling factor in EventLogging calls. Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-19 09:24:54 +00:00
$wgResourceModules['mmv.ActionLogger']['dependencies'][] = 'ext.eventLogging';
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
$wgResourceModules['mmv.performance']['dependencies'][] = 'ext.eventLogging';
Adds new performance metrics - duration between early click and replayed click - duration between replayed/post-replay click and first image display - duration between replayed/post-replay click and first metadata display Change-Id: Ia308db7580fd89538b9a9c8b0fea89fa2a4c77d2 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/515 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/508
2014-04-28 16:11:55 +00:00
$wgResourceModules['mmv.DurationLogger']['dependencies'][] = 'ext.eventLogging';
Add feature flags for Media Viewer $wgMediaViewerIsInBeta is one, $wgEnableMediaViewerForLoggedInUsers is the other - use the former on all sites, the latter on pilot sites in April. Before merging, MERGE https://gerrit.wikimedia.org/r/117376 Change-Id: I232997918dee4a00be18c021eb351d81609df2b0
2014-03-07 01:56:56 +00:00
}
Register ResourceLoader modules the conventional way * Remove $moduleInfo trick; it's an expensive way to save typing a few characters. (If you are really keen to save those characters, consider flattening the file hierarchy: does every mmv module have to have 'mmv' both in its directory name *and* in the filename itself?) * Using an anonymous, immediate function to create a scope and thereby avoid polluting global scope is a JavaScript pattern that doesn't translate well to PHP. The idiomatic way of doing that in PHP is to use namespaces. But you don't even need to do that, since all the variables you are manipulating are global anyway, now that $moduleInfo is gone. * Use the same pattern as VisualEditor for registering multiple modules in bulk. * Always put extension info under 'other' section. If a value is configurable, then it is not essential / inherent to the extension itself. The fact that the extension is a beta feature is a property of the way it is deployed on the Wikimedia cluster; it's not descriptive of the extension in itself. (I would argue getting rid of the 'betafeatures' section everywhere for this reason.) Change-Id: Ifc0a05362db990e4c073761a00ba17326c5ebbdb
2014-04-07 04:34:09 +00:00
};
foreach ( array(
'cc-by-1.0',
'cc-sa-1.0',
'cc-by-sa-1.0',
'cc-by-2.0',
'cc-by-sa-2.0',
'cc-by-2.1',
'cc-by-sa-2.1',
'cc-by-2.5',
'cc-by-sa-2.5',
'cc-by-3.0',
'cc-by-sa-3.0',
'cc-by-sa-3.0-migrated',
'cc-by-4.0',
'cc-by-sa-4.0',
'cc-pd',
'cc-zero',
'pd',
'default',
) as $license ) {
$wgResourceModules['mmv']['messages'][] = 'multimediaviewer-license-' . $license;
}
$wgAutoloadClasses['MultimediaViewerHooks'] = __DIR__ . '/MultimediaViewerHooks.php';
$wgDefaultUserOptions['multimediaviewer-enable'] = true;
$wgHooks['GetPreferences'][] = 'MultimediaViewerHooks::getPreferences';
$wgHooks['GetBetaFeaturePreferences'][] = 'MultimediaViewerHooks::getBetaPreferences';
$wgHooks['BeforePageDisplay'][] = 'MultimediaViewerHooks::getModulesForArticle';
$wgHooks['CategoryPageView'][] = 'MultimediaViewerHooks::getModulesForCategory';
$wgHooks['ResourceLoaderGetConfigVars'][] = 'MultimediaViewerHooks::resourceLoaderGetConfigVars';
$wgHooks['MakeGlobalVariablesScript'][] = 'MultimediaViewerHooks::makeGlobalVariablesScript';
$wgHooks['ResourceLoaderTestModules'][] = 'MultimediaViewerHooks::getTestModules';
$wgHooks['ThumbnailBeforeProduceHTML'][] = 'MultimediaViewerHooks::thumbnailBeforeProduceHTML';
$wgExtensionCredits['other'][] = array(
'path' => __FILE__,
'name' => 'MultimediaViewer',
'descriptionmsg' => 'multimediaviewer-desc',
'version' => '0.3.0',
'author' => array(
'MarkTraceur (Mark Holmquist)',
'Gilles Dubuc',
'Gergő Tisza',
'Aaron Arcos',
'Zeljko Filipin',
'Pau Giner',
'theopolisme',
'MatmaRex',
'apsdehal',
'vldandrew',
'Ebrahim Byagowi',
'Dereckson',
'Brion VIBBER',
'Yuki Shira',
'Yaroslav Melnychuk',
'tonythomas01',
'Raimond Spekking',
'Kunal Mehta',
'Jeff Hall',
'Christian Aistleitner',
'Amir E. Aharoni',
),
'url' => 'https://mediawiki.org/wiki/Extension:MultimediaViewer',
);
Reference in a new issue Copy permalink