mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Math
synced 2024-12-23 21:02:51 +00:00
65642489ae
Currently the method render always returns a html string that can be a string that represents the correct result or a rendered error message. This change splits rendering and fetching of the HTML output. This simplifies the logic of the rendering and caching mechanism. Now the render method returns a boolean that indicates if the rendering was sucessful or not. Step 2/2 Warning: Errors in this change might affect caching logic and squid caches. Change-Id: I00502b84212ed70cdf63bd69916a35afbd6fdbc1
173 lines
5.8 KiB
PHP
173 lines
5.8 KiB
PHP
<?php
|
|
/**
|
|
* PHPUnit tests for MathTexvc.
|
|
*
|
|
* @group Extensions
|
|
* @group Math
|
|
*/
|
|
|
|
/**
|
|
* @covers MathTexvc
|
|
*/
|
|
class MathTexvcTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* Tests behavior of render() upon a cache hit.
|
|
* If the rendered object exists in the database cache, MathTexvc
|
|
* just generates HTML from it, and skips shelling out to texvc
|
|
* entirely.
|
|
* @covers MathTexvc::render
|
|
*/
|
|
function testRenderCacheHit() {
|
|
global $wgMathCheckFiles;
|
|
|
|
// Disable file checks. (This is permissable, because PHPUnit
|
|
// will backup / restore global state on test setup / teardown.)
|
|
$wgMathCheckFiles = false;
|
|
|
|
// Create a MathTexvc mock, replacing methods 'readFromDatabase',
|
|
// 'callTexvc', and 'doHTMLRender' with test doubles.
|
|
$texvc = $this->getMockBuilder( 'MathTexvc' )
|
|
->setMethods( array( 'readCache', 'callTexvc', 'getHtmlOutput' ) )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
// When we call render() below, MathTexvc will ...
|
|
|
|
// ... first check if the item exists in the database cache:
|
|
$texvc->expects( $this->once() )
|
|
->method( 'readCache' )
|
|
->with()
|
|
->will( $this->returnValue( true ) );
|
|
|
|
// ... if cache lookup succeeded, it won't shell out to texvc:
|
|
$texvc->expects( $this->never() )
|
|
->method( 'callTexvc' );
|
|
|
|
// ... the output will not be generated if not requested
|
|
$texvc->expects( $this->never() )
|
|
->method( 'getHtmlOutput' );
|
|
|
|
$texvc->render();
|
|
}
|
|
|
|
/**
|
|
* Test behavior of render() upon cache miss.
|
|
* If the rendered object is not in the cache, MathTexvc will shell
|
|
* out to texvc to generate it. If texvc succeeds, it'll use the
|
|
* result to generate HTML.
|
|
* @covers MathTexvc::render
|
|
*/
|
|
function testRenderCacheMiss() {
|
|
$texvc = $this->getMockBuilder( 'MathTexvc' )
|
|
->setMethods( array( 'readCache', 'callTexvc', 'getHtmlOutput' ) )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
// When we call render() below, MathTexvc will ...
|
|
|
|
// ... first look up the item in cache:
|
|
$texvc->expects( $this->once() )
|
|
->method( 'readCache' )
|
|
->will( $this->returnValue( false ) );
|
|
|
|
// ... on cache miss, MathTexvc will shell out to texvc:
|
|
$texvc->expects( $this->once() )
|
|
->method( 'callTexvc' )
|
|
->will( $this->returnValue( MathTexvc::MW_TEXVC_SUCCESS ) );
|
|
|
|
// ... the output will not be generated if not requested
|
|
$texvc->expects( $this->never() )
|
|
->method( 'getHtmlOutput' );
|
|
|
|
$texvc->render();
|
|
}
|
|
|
|
/**
|
|
* Test behavior of render() when texvc fails.
|
|
* If texvc returns a value other than MW_TEXVC_SUCCESS, render()
|
|
* returns the error object and does not attempt to generate HTML.
|
|
* @covers MathTexvc::render
|
|
*/
|
|
function testRenderTexvcFailure() {
|
|
$texvc = $this->getMockBuilder( 'MathTexvc' )
|
|
->setMethods( array( 'readCache', 'callTexvc', 'getHtmlOutput' ) )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
// When we call render() below, MathTexvc will ...
|
|
|
|
// ... first look up the item in cache:
|
|
$texvc->expects( $this->any() )
|
|
->method( 'readCache' )
|
|
->will( $this->returnValue( false ) );
|
|
|
|
// ... on cache miss, shell out to texvc:
|
|
$texvc->expects( $this->once() )
|
|
->method( 'callTexvc' )
|
|
->will( $this->returnValue( false ) );
|
|
|
|
// ... if texvc fails, render() will not generate HTML:
|
|
$texvc->expects( $this->never() )
|
|
->method( 'getHtmlOutput' );
|
|
|
|
// ... it will return the error result instead:
|
|
$this->assertEquals( $texvc->render(), false );
|
|
}
|
|
|
|
/**
|
|
* Tests behavior of convertTexvcError
|
|
*
|
|
* @covers MathTexvc::convertTexvcError
|
|
*/
|
|
public function testConvertTexvcError() {
|
|
$texvc = $this->getMockBuilder( 'MathTexvc' )
|
|
->setMethods( NULL )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$mathFailure = wfMessage( 'math_failure' )->inContentLanguage()->escaped();
|
|
|
|
$actualLexing = $texvc->convertTexvcError( 'E' );
|
|
$expectedLexing = wfMessage( 'math_lexing_error', '' )->inContentLanguage()->escaped();
|
|
$this->assertContains( $mathFailure, $actualLexing, 'Lexing error contains general math failure message' );
|
|
$this->assertContains( $expectedLexing, $actualLexing, 'Lexing error contains detailed error for lexing' );
|
|
|
|
$actualSyntax = $texvc->convertTexvcError( 'S' );
|
|
$expectedSyntax = wfMessage( 'math_syntax_error', '' )->inContentLanguage()->escaped();
|
|
$this->assertContains( $mathFailure, $actualSyntax, 'Syntax error contains general math failure message' );
|
|
$this->assertContains( $expectedSyntax, $actualSyntax, 'Syntax error contains detailed error for syntax' );
|
|
|
|
$unknownFunction = 'figureEightIntegral';
|
|
$actualUnknownFunction = $texvc->convertTexvcError( "F$unknownFunction" );
|
|
$expectedUnknownFunction = wfMessage( 'math_unknown_function', $unknownFunction )->inContentLanguage()->escaped();
|
|
$this->assertContains( $mathFailure, $actualUnknownFunction, 'Unknown function error contains general math failure message' );
|
|
$this->assertContains( $expectedUnknownFunction, $actualUnknownFunction, 'Unknown function error contains detailed error for unknown function' );
|
|
|
|
$actualUnknownError = $texvc->convertTexvcError( 'Q' );
|
|
$expectedUnknownError = wfMessage( 'math_unknown_error', '' )->inContentLanguage()->escaped();
|
|
$this->assertContains( $mathFailure, $actualUnknownError, 'Unknown error contains general math failure message' );
|
|
$this->assertContains( $expectedUnknownError, $actualUnknownError, 'Unknown error contains detailed error for unknownError' );
|
|
}
|
|
/**
|
|
* Test behavior $change when the rendered hash was changed
|
|
* @covers MathRenderer::setHash()
|
|
*/
|
|
public function testChangeHash() {
|
|
$renderer = $this->getMockBuilder( 'MathTexvc' )
|
|
->setMethods( array( 'render', 'getMathTableName' ) )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$this->assertEquals(
|
|
$renderer->isChanged(),
|
|
false,
|
|
"test if changed is initially false"
|
|
);
|
|
$renderer->setHash( '0000' );
|
|
$this->assertEquals(
|
|
$renderer->isChanged(),
|
|
true,
|
|
"assumes that changing a hash sets changed to true" );
|
|
}
|
|
}
|