mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Math
synced 2024-12-24 21:33:04 +00:00
8b481b45f1
Adding action=purge to the url did not bypass cache in native mode, because the check request was performed before the purge information was passed. * Move purge property to the base class * Pass purge option via the checker constructor * Add cache checking for mathoid checker * Adjust method signatures accordingly Change-Id: I6f545060ae72dac8b12fb0f85662c4048059b2e9
200 lines
7.2 KiB
PHP
200 lines
7.2 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Extension\Math\InputCheck;
|
|
|
|
use HashBagOStuff;
|
|
use MediaWiki\Extension\Math\Math;
|
|
use MediaWiki\Extension\Math\MathMathML;
|
|
use MediaWiki\Http\HttpRequestFactory;
|
|
use MediaWikiIntegrationTestCase;
|
|
use MockHttpTrait;
|
|
use RuntimeException;
|
|
use WANObjectCache;
|
|
|
|
class MathoidCheckerTest extends MediaWikiIntegrationTestCase {
|
|
use MockHttpTrait;
|
|
|
|
private const SAMPLE_KEY = 'global:MediaWiki\Extension\Math\InputCheck\MathoidChecker:' .
|
|
'eb27aefff6e58e58dcefa22102531a58';
|
|
|
|
public static function provideTexExamples() {
|
|
return [
|
|
[ '\sin x', 'eb27aefff6e58e58dcefa22102531a58' ],
|
|
[ '\sin_x', '7b33c69d6eac9126d41b663b93896951' ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getCacheKey
|
|
* @dataProvider provideTexExamples
|
|
*/
|
|
public function testCacheKey( string $input, string $expected ) {
|
|
$checker = $this->getMathoidChecker( $input );
|
|
$realKey = $checker->getCacheKey();
|
|
$this->assertStringEndsWith( $expected, $realKey );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getCheckResponse
|
|
*/
|
|
public function testResponseFromCache() {
|
|
$fakeWAN = new WANObjectCache( [ 'cache' => new HashBagOStuff() ] );
|
|
$fakeWAN->set( self::SAMPLE_KEY,
|
|
[ 999, 'expected' ],
|
|
WANObjectCache::TTL_INDEFINITE,
|
|
[ 'version' => MathoidChecker::VERSION ] );
|
|
// double check that the fake works
|
|
$this->assertSame( [ 999, 'expected' ], $fakeWAN->get( self::SAMPLE_KEY ) );
|
|
$this->setService( 'MainWANObjectCache', $fakeWAN );
|
|
$checker = $this->getMathoidChecker();
|
|
$this->assertSame( [ 999, 'expected' ], $checker->getCheckResponse() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getCheckResponse
|
|
*/
|
|
public function testResponseWithPurge() {
|
|
$fakeWAN = new WANObjectCache( [ 'cache' => new HashBagOStuff() ] );
|
|
$fakeWAN->set( self::SAMPLE_KEY,
|
|
[ 999, 'unexpected' ],
|
|
WANObjectCache::TTL_INDEFINITE,
|
|
[ 'version' => MathoidChecker::VERSION ] );
|
|
// double check that the fake works
|
|
$this->assertSame( [ 999, 'unexpected' ], $fakeWAN->get( self::SAMPLE_KEY ) );
|
|
$this->setFakeRequest( 200, 'expected' );
|
|
$this->setService( 'MainWANObjectCache', $fakeWAN );
|
|
$checker = $this->getMathoidChecker( '\sin x', true );
|
|
$this->assertSame( [ 200, 'expected' ], $checker->getCheckResponse() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getCheckResponse
|
|
*/
|
|
public function testResponseFromResponse() {
|
|
$fakeWAN = WANObjectCache::newEmpty();
|
|
$fakeWAN->set( self::SAMPLE_KEY, 'expected' );
|
|
// double check that the fake does not work
|
|
$this->assertSame( false, $fakeWAN->get( self::SAMPLE_KEY ) );
|
|
$this->setService( 'MainWANObjectCache', $fakeWAN );
|
|
$this->setFakeRequest( 200, 'expected' );
|
|
$checker = $this->getMathoidChecker();
|
|
$this->assertSame( [ 200, 'expected' ], $checker->getCheckResponse() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getCheckResponse
|
|
*/
|
|
public function testFailedResponse() {
|
|
$fakeWAN = WANObjectCache::newEmpty();
|
|
$fakeWAN->set( self::SAMPLE_KEY, 'expected' );
|
|
// double check that the fake does not work
|
|
$this->assertSame( false, $fakeWAN->get( self::SAMPLE_KEY ) );
|
|
$this->setService( 'MainWANObjectCache', $fakeWAN );
|
|
$this->setFakeRequest( 401, false );
|
|
$checker = $this->getMathoidChecker();
|
|
$this->expectException( RuntimeException::class );
|
|
$checker->getCheckResponse();
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::isValid
|
|
* @dataProvider provideMathoidSamples
|
|
* @param string $input LaTeX input to check
|
|
* @param string $mockRequestBody
|
|
* @param int $mockResponseStatus
|
|
* @param array $expeted
|
|
*/
|
|
public function testIsValid( $input, $mockRequestBody, $mockResponseStatus, $expeted ) {
|
|
$request = $this->makeFakeHttpRequest( $mockRequestBody, $mockResponseStatus );
|
|
$this->installMockHttp( $request );
|
|
$checker = $this->getMathoidChecker( $input );
|
|
$this->assertSame( $expeted['valid'], $checker->isValid() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getValidTex
|
|
* @dataProvider provideMathoidSamples
|
|
* @param string $input LaTeX input to check
|
|
* @param string $mockRequestBody
|
|
* @param int $mockResponseStatus
|
|
* @param array $expeted
|
|
*/
|
|
public function testGetChecked( $input, $mockRequestBody, $mockResponseStatus, $expeted ) {
|
|
$request = $this->makeFakeHttpRequest( $mockRequestBody, $mockResponseStatus );
|
|
$this->installMockHttp( $request );
|
|
$checker = $this->getMathoidChecker( $input );
|
|
$this->assertSame( $expeted['checked'], $checker->getValidTex() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\Math\InputCheck\MathoidChecker::getError
|
|
* @dataProvider provideMathoidSamples
|
|
* @param string $input LaTeX input to check
|
|
* @param string $mockRequestBody
|
|
* @param int $mockResponseStatus
|
|
* @param array $expeted
|
|
*/
|
|
public function testGetError( $input, $mockRequestBody, $mockResponseStatus, $expeted ) {
|
|
$request = $this->makeFakeHttpRequest( $mockRequestBody, $mockResponseStatus );
|
|
$this->installMockHttp( $request );
|
|
$checker = $this->getMathoidChecker( $input );
|
|
if ( array_key_exists( 'error', $expeted ) ) {
|
|
$checkerError = $checker->getError();
|
|
$this->assertNotNull( $checkerError );
|
|
$renderedCheckerError = ( new MathMathML( 'a' ) )
|
|
->getError( $checkerError->getKey(), ...$checkerError->getParams() );
|
|
$this->assertStringContainsString( $expeted['error'], $renderedCheckerError );
|
|
} else {
|
|
$this->assertNull( $checker->getError() );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param string $tex
|
|
* @param bool $purge
|
|
* @return MathoidChecker
|
|
*/
|
|
private function getMathoidChecker( string $tex = '\sin x', bool $purge = false ): MathoidChecker {
|
|
return Math::getCheckerFactory()
|
|
->newMathoidChecker( $tex, 'tex', $purge );
|
|
}
|
|
|
|
private function setFakeRequest( $returnStatus, $content ): void {
|
|
$fakeHTTP = $this->createMock( HttpRequestFactory::class );
|
|
$fakeRequest = $this->createMock( \MWHttpRequest::class );
|
|
$fakeRequest->expects( $this->once() )->method( 'execute' )->willReturn( true );
|
|
$fakeRequest->expects( $this->once() )->method( 'getStatus' )->willReturn( $returnStatus );
|
|
if ( $content ) {
|
|
$fakeRequest->expects( $this->once() )->method( 'getContent' )->willReturn( $content );
|
|
} else {
|
|
$fakeRequest->expects( $this->never() )->method( 'getContent' );
|
|
}
|
|
$fakeHTTP->expects( $this->once() )->method( 'create' )->willReturn( $fakeRequest );
|
|
$this->setService( 'HttpRequestFactory', $fakeHTTP );
|
|
}
|
|
|
|
public static function provideMathoidSamples() {
|
|
yield '\ sin x' => [
|
|
'\sin x',
|
|
file_get_contents( __DIR__ . '/data/mathoid/sinx.json' ), 200,
|
|
[ 'valid' => true, 'checked' => '\sin x' ],
|
|
];
|
|
yield 'invalid F' => [
|
|
'1+\invalid',
|
|
file_get_contents( __DIR__ . '/data/mathoid/invalidF.json' ), 400,
|
|
[ 'valid' => false, 'checked' => null, 'error' => 'unknown function' ],
|
|
];
|
|
yield 'unescaped' => [
|
|
'1.5%',
|
|
file_get_contents( __DIR__ . '/data/mathoid/deprecated.json' ), 200,
|
|
[ 'valid' => true, 'checked' => '1.5\%' ],
|
|
];
|
|
yield 'syntax error' => [
|
|
'\left( x',
|
|
file_get_contents( __DIR__ . '/data/mathoid/syntaxE.json' ), 400,
|
|
[ 'valid' => false, 'checked' => null, 'error' => 'Failed to parse' ],
|
|
];
|
|
}
|
|
|
|
}
|