Commit graph

258 commits

Author SHA1 Message Date
jenkins-bot ad668a6e69 Merge "Fix for sideset case" 2023-03-13 15:57:52 +00:00
Stegmujo b7d909e0a2 Fix for sideset case
* example "\sideset{_1^2}{_3^4}\sum"
* case 3 phabricator "sideset"
* index: 90
* since result has multiscripts which is not generated by mathoid, there is an explicit test in MMLRenderTest and the previous test is in MMLTexVCUtilTest is skipped
* in MMLGenerationTexUtilTest test for sideset is deactivated
* adds a case from FullCoverageTest for sideset with FQ
* fixes an issue which occured during Phan checks for merging that genFrac throws an error

Bug : T327391

Change-Id: I4c5a5f5a901dbc906f5a1b168d3a8d04f25b9290
2023-03-13 15:38:04 +00:00
libraryupgrader dcce2100d0 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 41.0.0

npm:
* cookiejar: 2.1.3 → 2.1.4
  * https://github.com/advisories/GHSA-h452-7996-h45h
* http-cache-semantics: 4.1.0 → 4.1.1
  * https://github.com/advisories/GHSA-rc47-6667-2j5j
* ua-parser-js: 1.0.2 → 1.0.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I4198e1cbdc115d27c9fe5b8d0ce813b514524796
2023-03-12 05:44:17 +00:00
jenkins-bot d7c931fbaa Merge "Add minimal native MML mode" 2023-03-07 11:45:31 +00:00
Moritz Schubotz (physikerwelt) aa828066df
Catch all exception during rendering
When switching to native MathML rendering more code is
beeing executed and Errors might be thrown. We want to make sure
that bugs in individual formulae don't break the display for the
entire page. Therefore, we extend the the catch clause to catch all
throwables.

Change-Id: I3deda42950bee75d9257135854535dd41a5e18dc
2023-03-02 22:19:38 +01:00
Moritz Schubotz (physikerwelt) 88a4c8bc1d
Add minimal native MML mode
* Add minimal POC for native MathML rendering.
* (minor) convert string-based reference to MathConfig to proper access
  method.

Missing:
 *  Error handling
 *  Image fallbacks

Bug: T331047

Change-Id: I7e644c4688cca7fc9af0d54bdc260268c1f6b9df
2023-03-02 20:50:29 +01:00
jenkins-bot 35257884ea Merge "Fix for tex-statement definecolor" 2023-03-02 11:16:20 +00:00
jenkins-bot 76686aa904 Merge "Introduce method to get checker" 2023-03-02 11:16:18 +00:00
Moritz Schubotz (physikerwelt) daadfad9ae
Introduce method to get checker
Allow MathRenderers to overwrite the way how the checker is initalized.
This will be needed for native MathML where LocalChecker will be used.

Change-Id: I358bef495675f7f8f9028f81484c4e535b9336f8
2023-03-02 11:41:15 +01:00
Stegmujo 8101c8f136
Fix for tex-statement definecolor
* example "\definecolor{ultramarine}{RGB}{0,32,96} a {b \color{ultramarine} c} d"
* case 2 phabricator: "colors"
* index: 22
* some test for parsing color statements

Bug: T327391
Change-Id: I98fdf011a2089dad4e7cb5a7a6aa8433fafe4a94
2023-03-02 11:35:27 +01:00
Stegmujo b9011e8e5b Fix for tex-statement "\pagecolor{red} e^{i \pi}"
* case 2 phabricator: "colors"
* index: 17

Bug: T327391
Change-Id: I202e13de8c07b63b0dfbff28036c9eb7fcc52db8
2023-03-01 15:26:03 +00:00
Stegmujo d23c6dc84d Fix for tex-statement "a {b \\color{red} c} d"
* case 2 phabricator: "colors"
* index: 16

Bug: T327391
Change-Id: I0c19dcc3819372c464d2ac0742160cec3bb8757a
2023-03-01 15:25:55 +00:00
jenkins-bot 64c3f6893a Merge "Add native MathML rendering mode to MathConfig" 2023-03-01 14:25:05 +00:00
jenkins-bot 567bd826e3 Merge "Fix for state forwarding" 2023-03-01 13:52:41 +00:00
Moritz Schubotz (physikerwelt) 642e54c51b Add native MathML rendering mode to MathConfig
Add a new rendering mode option.

Change-Id: I36e2cc542ae89bff03f779a71ddceb77dfac99a9
2023-03-01 13:39:35 +00:00
Stegmujo 00fd80f56d Fix for state forwarding
Bug: T327391
Change-Id: I71ed330b866b945c7ec91e6d43831029c63e78a5
2023-03-01 12:01:52 +00:00
Moritz Schubotz (physikerwelt) 9340b09c03
Expose parsetree in local checker
In perparation to the PHP only native MathML rendering mode, we expose
the parsetree of the checker.

Change-Id: I8da8d0e236c2b001e664ce707c7469ebe8a91eb8
2023-03-01 08:30:46 +01:00
Stegmujo ef2f59eed5
Fix exceptions thrown by LocalChecker
* for more consistency with the other Checker initialisations in
InputCheckFactory

Bug: T327098
Change-Id: Ia85775dea6a7dda5fcf42d66a161da49515ba0aa
2023-02-27 17:52:28 +01:00
Stegmujo 6ffaed440c
Remove additional mi for Hbox cases in TexUtilTest
* fix results for tests
* testindices 53 to 58
* formerly this contained a comparator fix (rolled back)

Bug: T327392
Change-Id: I1af65d5d8a4625d164630254da285830f4c9e0a3
2023-02-16 20:25:48 +01:00
Stegmujo 14c38c8f46
Fix vline in Matrix in TexUtilTest
* case index 654

Bug: T327392
Change-Id: I3f7d22ff501a30eef79baf82236406d8f5e450ae
2023-02-16 17:16:19 +01:00
jenkins-bot 1259375bfd Merge "Add state array to MathML rendering tree" 2023-02-16 09:17:51 +00:00
Stegmujo 65b3114e5b
Allow \circ command in bonds in TexVCPHP
Add \circ to mhchem macros to allow them in bonds.

Bug: T328833
Change-Id: I3100033904e28a181a2e674da388832678eb0db3
2023-02-15 14:25:30 +01:00
Moritz Schubotz (physikerwelt) 6efbf4dd00
Add state array to MathML rendering tree
For conditional rendering a state variable is needed.

Change-Id: Iac1a1058fecf89c58a02ca3b643e973b4742f51f
2023-02-15 11:04:20 +01:00
Stegmujo f760f896b2 Fix binom and dbinom in TexUtilTest
*indices: 79, 82

Bug: T327392
Change-Id: Ib1c19a52eea5f6433f52e440007cf6ba4ba4d48c
2023-02-14 11:53:58 +00:00
jenkins-bot e776fc32be Merge "Fix underline overline cases in TexUtilTest" 2023-02-13 20:03:40 +00:00
Stegmujo 448d1bb658 Fix underline overline cases in TexUtilTest
* indices: 48, 59

Bug: T327392
Change-Id: I6962b238485e03a7e2f65fd10d20377dbc2c5892
2023-02-13 18:14:03 +00:00
Stegmujo 0a3a4a4ff2
Fix parsing of 'P' operator
* index 219

Bug: T327392
Change-Id: Ie820c303ef0fcaa86d10022982023cebfc0e8046
2023-02-13 14:25:05 +01:00
Stegmujo 78b7769149
Fix parsing macros in mbox for TexUtilTest
* testindices 638 to 654 and 13

Bug: T327392

Change-Id: I1c83290f50f3fe7ee7e512574150d6be9723b3e7
2023-02-13 13:59:34 +01:00
Stegmujo 39c400a431 Fix Parsing of Mod elements with and without params
* some adaptions to test and comparator
* minor fix in mappings for ncong
* introduce a LaTeXML Fallback for the tex-cases:
** "\ce{\ca}"
** "\mod"

Bug: T327392

Change-Id: Ie2efa392bd517a28fe8b6e8d0cecdba64cd1c415
2023-02-13 12:23:44 +00:00
Stegmujo dbf15a72c6 Fix parsing functions for MMLGenerationTexVCUtilTest
* for "oint","ointctrclockwise", "varointclockwise."
* some ignored attributes added to similarity algorithm

Bug: T327392
Change-Id: Id4cf720bb2d2c8aeb524c2303bdf0d4be3547404
2023-02-08 14:30:46 +00:00
jenkins-bot 347dcbd3fe Merge "Fix significant typo in grammar" 2023-01-03 16:02:27 +00:00
jenkins-bot 6153004078 Merge "Improve security of MathML output" 2023-01-03 15:28:24 +00:00
Moritz Schubotz (physikerwelt) 7b425a5500
Improve security of MathML output
Avoid that user input is passed to the HTML output directly by using
HTML methods for tag generation. This also enables additional phan checks.

Change-Id: Iff584ac829c190e413a36331c53d6835a86bc0d5
2023-01-03 15:47:54 +01:00
Moritz Schubotz (physikerwelt) 81fa5b0c97
Fix significant typo in grammar
* Uq and Dq was mixed
* Simplify regeneration of grammar for node developers
* Speed up npm test by ignoring local test json files

Change-Id: Iec273dcc967be46d3df52260fc56f1969667e497
2022-12-30 16:58:39 +01:00
Moritz Schubotz (physikerwelt) 96c636e243
Refactor LocalChecker
* Do not throw arbitrary exception in constructor
* Remove custom fields

Change-Id: Ibb49f6a5e66649bab8b605e8785a868b74dbd7d0
2022-12-29 22:51:34 +01:00
Moritz Schubotz (physikerwelt) b9e297c4ec Improve test coverage for nodes
* Use merror instead of plain strings for not implemented functions

Change-Id: If20559e05f3b0c8921a28c623102b8f4788a3c94
2022-12-28 19:18:21 +00:00
Moritz Schubotz (physikerwelt) 469c698e47
Improve checking performance
* Report only on used packages if requested

Change-Id: I5b4fc6d7e571206f5b5d41d3bf268251ed1a8677
2022-12-28 13:34:23 +01:00
Moritz Schubotz (physikerwelt) 70acbd7ea4
Fix missing curlies in chem nodes
* the php implementation had fewer curlies compared to the
  js implmenetation

* remove unused function name (could be replace get_class)

* Add testcase for declh

Change-Id: I8132604a659d7ddf98e1f73686b40ff0591229f3
2022-12-28 00:56:47 +01:00
Stegmujo 783797bb9a
Add test for basic MML Methods
Bug: T302628
Change-Id: Ib3d781a516e53392fb09a2c70b322805dcb43fcf
2022-12-23 22:46:59 +01:00
Stegmujo f8e25f5dce
Update visitor functions and add parsing methods (MMLGen)
Bug: T302628

Change-Id: I5374a831cf74a6eb3bf3165abe3ad0661ec07f5f
2022-12-23 20:02:00 +01:00
Stegmujo a692599224 Add mappings for MMLGen
Bug: T302628

Change-Id: I839b77d805820262bb96fea801f1f2c3f52b53d5
2022-12-23 15:29:33 +00:00
jenkins-bot 5db9b573f3 Merge "Update namespace references in MMLNodes" 2022-12-23 15:16:25 +00:00
Stegmujo bdcd599e97 Update namespace references in MMLNodes
* this is necessary for phan to have corresponding namespaces to project structure

Bug: T302628

Change-Id: Ic485136990698828c04739db48f69658264bfd25
2022-12-23 14:54:00 +00:00
Stegmujo c124f1ec26 Add utility classes for generating MathML
Bug: T302628

Change-Id: I90f0470a14f0adeaef94b90833b4bbc32a758a32
2022-12-23 14:42:18 +00:00
Stegmujo d3da9f2ce1
Add updated TexConstants and Lengths
* mostly this solves dependency references

Bug: T302628
Change-Id: Idee807304e283def14ea0eb00762793a8e52ae7e
2022-12-23 11:06:34 +01:00
Stegmujo 34b98c5a0d
Add MML nodes and basic constants for MML generation
Bug: T302628

Change-Id: If18a5650b6c92b5da7496dd891987ecc8bd0efab
2022-12-21 12:05:26 +01:00
Umherirrender 6e424c2e4a Replace comment about deprecated Http::post
Bug: T305813
Change-Id: I1975fd473c8d57ab7e43a47ea4da3d4f33fac68c
2022-12-11 15:04:59 +01:00
AndreG-P 95c5757ee5 Enable popups for annotated math formulae
Enable popup extension for annotated math expressions. The popup shows a short summary of the formula and is generated via the Popup API introduced with I65fcbf25ac5818f6c649daf494c719921247e8f5. It is a follow up of Iefe98c1f0422dbf034e385b1a41a859d030a2cf4.

Bug: T208758
Change-Id: I8c45b7e441083c240bbf2e0217ec219df7dcc351
2022-12-06 06:07:22 +00:00
jenkins-bot 7c58d11125 Merge "Fix broken/incomplete regex patterns in TexNode::texContainsFunc" 2022-12-01 20:53:02 +00:00
thiemowmde 566944c42d Fix broken/incomplete regex patterns in TexNode::texContainsFunc
I compared with
6c6988c4f6/lib/astutil.js
and found two mistakes:
* Missing space at the end of the color regex.
* Not enough backslash escaping in the last regex.

Note how the code in lines #116 and #130 is now identical.

Change-Id: I13b75ad4a1e4da0766c0d73b8786b21865945697
2022-12-01 17:05:30 +01:00