Commit graph

118 commits

Author SHA1 Message Date
Amire80 848d762e24 Add support for chemical formulae in VisualEditor
The chemical and mathematical formula inspectors and dialogs
have a lot of similar functionality, and the common parts are
now moved to the common MWLatex class.

MWMath* classes now inherit from MWLatex*, and so do
the new MWChem* classes.

Bug: T153365
Change-Id: I4452ceca55197fda5f1e1293a5741c6f5fb7c245
2017-02-19 18:36:26 +00:00
jenkins-bot 74be597efb Merge "build: Bump stylelint and make pass" 2017-02-18 00:13:01 +00:00
James D. Forrester 6a6c68b387 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
2017-02-17 15:30:18 -08:00
James D. Forrester 4a06cdf728 Follow-up 75db3ed9: Also fall back to symbol.insert in MWMathPage
Bug: T157751
Change-Id: Ia0d40c70f52f41eb07dcbe121437379419b861b3
2017-02-09 17:47:27 -08:00
Ed Sanders 75db3ed9fe Math symbols: Remove 'tex' when identical to 'insert'
Change-Id: I3e9abc923eb686a60b9ae5359d8b823acc863f31
2017-02-09 19:22:47 +00:00
Amire80 48a5a0a7e8 Split ve.ui.MWMathPage.css from ve.ui.MWMathDialog.css
There are separate JS files for them, so the CSS should be separate, too.

This is a part of the refactoring that is required for bug T153365.

Change-Id: Iadbe5eeccff25ed1d184658945a4eb52e465d863
2017-01-11 19:44:31 -08:00
jenkins-bot f8ceb1d495 Merge "Add word list to math dialog for autocompletion" 2017-01-11 23:57:20 +00:00
Thalia 06f6af78dc Add word list to math dialog for autocompletion
Bug: T155107
Change-Id: I57bbf9d9a75810cd06b9ba43a173f9bf4a74c9fc
2017-01-11 14:44:16 -08:00
Ed Sanders edd166cfa3 Create chemistry icon for upcoming VE chemistry support
Bug: T153365
Change-Id: Ieaf5708932cfc91de6c293fd752dd64b8a73c73d
2017-01-11 14:28:31 -08:00
Ed Sanders a182a9d332 Fix primary command name
Primary command name is used by double click and enter.
Make this launch the default edit action 'mathDialog'.

Change-Id: Ie7a87914a55ecc87769c4a1aa029b36966b83a04
2016-11-30 12:39:59 +00:00
Ed Sanders 422ea757ae eslint: Re-enable wrap-iife and partially enable dot-notation
Also removed upstreamed spaced-comment rule.

Change-Id: Ide83abeedfea27c1f4574af0069d5a9fdb81de84
2016-11-15 13:13:05 +00:00
Ed Sanders f66ef920fb build: Replace jscs and jshint with eslint
Change-Id: I95f59d9bef6bb8fec69b454dc8efe4b4c7e40805
2016-10-28 11:11:26 -07:00
Thalia 3ebade4175 Make width of buttons in math dialog more flexible
Previously there were only two possible button widths,
now there are four.

Bug: T145613
Change-Id: I233f4f7c6cb810d6b5d54a5242514afed7c2ad9d
2016-10-14 16:30:50 -07:00
Ed Sanders 5f31ddeb8f VE: Make all edits 'quick edit' on mobile
Mobile doesn't really have room for the full dialog.

Change-Id: I08f45c3b26bd88f75deb4dbd51435a109021f0fe
2016-09-08 16:19:29 -07:00
James D. Forrester fda31a802f build: Fix stylelint devDependencies
Bug: T142235
Change-Id: I45021b2cd1decdc4cd9a9e9908d132cc1f6d795b
2016-08-05 11:59:39 -07:00
Ed Sanders 7938545a7c Use transition timing from OOUI theme config
Depends-On: I00eaa2b815d7c76b6315a3993a9a7921ae503c00
Change-Id: Iddd99171137a7457d0c3084c396453575a1e7231
2016-07-12 13:29:15 +01:00
James D. Forrester 9b6f6c7300 Follow-up 3f456b1: Fix typo in function call
Bug: T132736
Change-Id: I36862baf287efe275d5b5fdc3bef911b7815a762
2016-05-26 09:22:33 -07:00
Ed Sanders e2139b1657 build: Introduce stylelint to lint for css errors
Also update the rest of the CI world whilst we're at it.

Change-Id: Iaad2867797cccb2dd0df7758e448b553859fa62c
2016-05-19 19:16:00 +01:00
jenkins-bot 950c0596ca Merge "Make short mode for the math dialog" 2016-04-19 19:22:23 +00:00
Thalia a5e6d22495 Make short mode for the math dialog
When the math dialog's menuLayout height is below 450 px,
make the symbol menu and the preview element shorter, so
the input is still in view. (This works until about
280px, below which the user will need to scroll down to
use the input.

Bug: T121150
Change-Id: I9e41cce80c3f770b1e3d0e7b133470045a1afe67
2016-04-19 19:50:17 +01:00
jenkins-bot 86f359ec30 Merge "Add inverse of texToClass function in comment" 2016-04-12 15:29:34 +00:00
jenkins-bot e00af78d9a Merge "Use new executeCommand method" 2016-04-12 15:20:29 +00:00
Ed Sanders 4010978ebf Add inverse of texToClass function in comment
Change-Id: Iba9658cfb8f413eaff8cdd62b6b7b2d836c5b23d
2016-04-12 15:01:04 +01:00
Ed Sanders dba01a653e CSS code style: spaces inside parentheses
Change-Id: Ia1324fe4ee98b487b82d01ee0d9cffe284a64811
2016-04-12 14:57:27 +01:00
Ed Sanders 3f456b1931 Use new executeCommand method
Change-Id: I24afd6c94c3224a3ae1f86204ddc16c726833c7c
2016-04-12 14:56:45 +01:00
Ed Sanders 617e0ccd53 Remove icon properties from windows
Windows stopped supporting icons a while ago.

Change-Id: I7a3fba6aef39b761f8eac9ed0f639ed18b1c4e65
2016-03-29 12:34:56 +01:00
Ed Sanders 481138a73d Remove SVGO compression, now done upstream in Mathoid
Change-Id: I961eb82722ae161bdf7a3ea945c299244ce321fb
Depends-On: I86c1a14ad81d2d252ac73da973274f88153d993c
2016-03-23 10:52:10 +00:00
Ed Sanders 49fc247004 Use the mathoidStyle property instead of parsing the SVG
This attribute was added in Ia0f601c1d5. Use it instead of
extracting the information from the SVG.

Change-Id: Ib6d6f4c9480ae00ccb2977b57c7b93de8ebb03f2
2016-03-22 14:46:48 +00:00
Ed Sanders 2b9bce4a0b makeSvgsAndCss: Add missing semi-colons to CSS, tweak symbol alignment formula
Sub-pixel alignment errors are unavoidable as the browser will rasterise
the SVG then round percentage offsets to the pixel grid.

Change-Id: I704db755d49be189db9670594e2ae2f193e6052d
2016-02-02 19:03:01 +00:00
Ed Sanders fd6f963504 makeSvgsAndCss: Increase max connections
This was set low to avoid issues with local servers, but the new default
server (wmflabs.org) can handle a higher value, and the script runs
much faster.

Change-Id: I69b06c59fc03c4c4b15619e8dff7bfc904dba96f
2016-02-02 12:49:32 +00:00
Thalia 2b9e3307ac Add option to adjust SVG baseline on math dialog buttons
If a symbol has "backgroundPosition" set to true, adjust
its vertical position in the button, according to the
vertical-align property on the SVG, by adding a
background-position property on its CSS rule.

Also set "backgroundPosition" to true for a number of
symbols and generate a new CSS file.

Bug: T123397
Change-Id: Ic9bbb65d2bedf38f569d8922599a2e3d2575f153
2016-02-01 18:07:13 +00:00
jenkins-bot e736202170 Merge "Resize math dialog input to fit the available space" 2016-01-25 15:12:44 +00:00
Thalia 150e658dc3 Correct \mathit button in math dialog
Change-Id: Ida4d82a9b859234e84a93ac34549076be9c42c46
2016-01-24 11:48:23 +00:00
Thalia 79eeb24bc0 Resize math dialog input to fit the available space
Every time the math dialog is resized, calculate the
vertical space available to the input and resize the
input to fill this space.

Bug: T123891
Depends-On: Ia2e094071f385628449f1935f0250cbeb75196f0
Change-Id: I3f3c915469f282a6e0459a7e4d10e19bee68b8db
2016-01-23 11:08:48 +00:00
Thalia a3a76811d2 Use more generic host and port for updating the math menu
Change-Id: Iaa079b8037d3c73cfc8a283aa3f7c7926feb328b
2016-01-13 20:04:14 +00:00
Thalia f62b625c21 Small corrections to the math dialog menu
Remove some duplicated symbols and correct some typos

Change-Id: I41e98a7b80554f3332e9abff33b9d12701a5d855
2016-01-11 18:18:42 +00:00
jenkins-bot 2499ea5236 Merge "VE: Rename parent tool" 2016-01-04 20:50:58 +00:00
jenkins-bot 867ad7f91a Merge "Allow users to choose math inspector or math dialog" 2016-01-04 17:10:42 +00:00
Ed Sanders ee3e0855f1 VE: Rename parent tool
Depends on I3a0e761f0 in core.

Change-Id: I7c6e5f2bd20e7875efc0ee60e329cdf081b64bd5
2016-01-04 17:07:51 +00:00
Thalia 5fe280c3cf Allow users to choose math inspector or math dialog
The context item for math nodes now has two edit buttons,
one for the inspector (edit inline) and one for the dialog
(edit). Creating a new math node automatically opens the
dialog.

Bug: T120382
Change-Id: Icd3ec75262fcc5e0cbc304051c651278b0d8b01c
2016-01-04 08:20:16 +00:00
jenkins-bot e04098facf Merge "Force Ace Editor to resize after the dialog has been rendered" 2015-12-20 12:57:58 +00:00
Thalia ac1ce967c1 Force Ace Editor to resize after the dialog has been rendered
If the editor resizes first, the height is 0px.

Depends on: I48307bd9184b

Bug: T121164
Change-Id: Ieb4ed963b03c9e7d802e9547478eb3c9cde512ae
2015-12-20 12:51:57 +00:00
Ed Sanders abb5573424 VE MWMathDialog: Fix documentation
Change-Id: Ic362df855ba616d2d2b3e0ccd4cebd3befd4ab94
2015-12-19 17:37:13 +00:00
Thalia 4087a1cec0 Focus the math dialog input after the symbols promise has returned
Bug: T119778
Change-Id: Ia5afe667241543addbda95d4d284b8af63f693a1
2015-12-08 13:26:34 +00:00
Thalia 3f193f6745 Make math dialog menu content scrollable
Also make input widget height respond to its contents. These two
changes address the problems of overlapping when the screen
height is limited.

Bug: T119900
Change-Id: Ie21c141673a9343d05da05cdbd2eaa96efff0a58
2015-12-03 16:25:00 +00:00
Thalia dfbce3f5ce Focus input and move cursor to end when MathDialog opens
Change-Id: Ie963913723b8c5f8ffb32701477627387c77eb85
2015-11-25 14:43:41 -08:00
Thalia bd36680d21 Ensure the formula preview in MathDialog is vertically centered
The formula preview is not centered when the display attribute
is set to block. Correct this by enforcing display: inline-block
when the math image is inside the preview element.

Bug: T119670
Change-Id: I77d9b213a31d3005212c8c11874112ddb64aa74a
2015-11-25 14:22:49 -08:00
Thalia a48a216171 Modify updateMwData in MathDialog to update display and id attributes
Also populate the options form with pre-existing values and add event
handlers.

Bug: T119663
Change-Id: I32fbecdb9b204fa33e309662f1f670942968fee7
2015-11-25 14:22:21 -08:00
Thalia 959d0d7b3a Set autocomplete options for math dialog input
Depends on I57db44c876c in ve-mw

Bug: T119549
Change-Id: I80193b7b662336c65b81556eb000f3895cddf49f
2015-11-24 18:54:48 -08:00
Thalia 6e73aaf86c Make math dialog with clickable list of formula fragments
The main components are:
- a menu of formula fragment buttons
- an ace editor text input into which LaTeX commands are
inserted on clicking the buttons
- a preview of the formula

The deviations from the draft design (full-width menu,
smaller buttons, dialog is 'larger' instead of 'large')
are so that more buttons can be seen at once.

Depends on Ia0f46da2d4 in ve-mw
Depends on Ib75fb7b087 in ve-mw
Depends on I758f90abb9 in ve-mw
Depends on Ibcd941d938 in CodeEditor
Depends on Ie814f59086 in oojs-ui
Depends on If540670bf2 in oojs-ui
Depends on I5f70f133b7 in ve core

Bug: T114163
Bug: T118617
Bug: T118618
Change-Id: I96d4b72f2e49ad3f43a2e5c71f0d348fdfb35503
2015-11-23 16:30:38 -08:00
Ed Sanders e4719c56a7 SVG/CSS generator: Ignore duplicates and 'notWorking' buttons
Change-Id: I5f0c9fc62a1e434576550e142d6b25f329e63e7f
2015-11-20 18:03:06 -08:00
Ed Sanders cbc847222e SVG/CSS generator: Make faster by skipping already-fetched icons
Also keep the CSS file in alphabetical order so additions make
for clean diffs. (The async built file had a pseudo-random order)

Change-Id: Iad76ef36c90f42ba3232f135b05465408f42b2ba
2015-11-20 17:32:03 -08:00
Ed Sanders a682d9677f VE: Correct name of script in header
Change-Id: I4a76d72dcb22a5ebeb02f6c0b6946c1ef4744185
2015-11-18 20:16:13 -08:00
Thalia eac71ab60f Add tool to create SVG files of LaTeX symbols
Also produces a CSS file for the symbol buttons, using the
SVG filenames. Gets the list of symbols from symbols.json.

Bug: T118660
Change-Id: Iaa792418d870a7e266b6455ef037994e31278278
2015-11-19 04:11:59 +00:00
Ed Sanders 17168f573b VE: Register sequence with CommandHelp
Depends on I65e2bfc2 in VE-MW

Change-Id: I8f71b1b242cb5c273c6d4a16bdfef6bf1e0adb55
2015-11-05 10:12:38 +00:00
Thalia f4a9297a70 Use new error element
Depends on I5839ba62fe in VE-MW

Bug: T114754
Change-Id: Iedd632af8743a53aa96b736ca5ef5af40c28bc7a
2015-10-29 22:08:31 +00:00
Ed Sanders 358635a33d VE: Add a '<math' sequence
Change-Id: I5ec6cc2e6b7487ef3ac5987b8eb055adbfc41931
2015-10-22 11:49:55 +01:00
jenkins-bot 11b0f02dd1 Merge "VE: Move hash changes to the rendering hash" 2015-10-07 19:18:15 +00:00
Ed Sanders 905a834be2 VE: Move hash changes to the rendering hash
Depends on I5d42943a0 in VE core.

Bug: T114689
Change-Id: Ib64a1184132fbf62f38c6bd5dde689acff7b8ae5
2015-10-07 14:40:43 +00:00
Thalia d24748769f Append error container to inspector
Also modify method that formats the error so only
the text is appended.

Depends on Ie84130d4ac0 in VE-MW.

Bug: T113172
Change-Id: I5310f22877f56d1828a9d1782ee335d5793700df
2015-10-05 00:07:21 +01:00
Thalia d81a1ff7ad Fix the check for the error class in generated content
Check the root of the generated content for the 'error'
class as well as the children.

Change-Id: I29044b5bfc33ce250c415a54d6c56f0620680658
2015-10-01 21:09:50 +01:00
Thalia 7241d5d3a7 Check for error in Parsoid response for math node
An error will contain an element with class "error".
Relies on I3f4ba354a in visual editor core in order to work.

Also remove old afterRender method.

Bug: T112610
Change-Id: Ie681806aebfdd7de918685c9343f5e176baaf517
2015-09-30 21:51:51 +01:00
Siebrand Mazeland 9a07f022f9 Update mediawiki-codesniffer and parallel-lint settings
Fix remaining sniffer warnings and errors

Change-Id: I2a2ab037793df771be2abc4a4433726469f60ab0
2015-09-29 02:19:04 +02:00
Thalia 2ca833f9e6 Fix old class name
Change-Id: Ia78e4c064e66536cb3144dd2af4c157087690b51
2015-09-19 01:33:01 +01:00
jenkins-bot 01004cbf94 Merge "Remove redundant size property" 2015-09-17 21:08:24 +00:00
Thalia 11ec6a3c12 Remove redundant size property
Change-Id: Iebedb66fda25078d507f012b17a459fde6a393e9
2015-09-17 19:48:42 +00:00
Ed Sanders 07c037e897 VisualEditor: Remove MathJax support
No longer needed.

Change-Id: Ibf6277f5cfccd1c689b55be5e4fbd8dbceafacae
2015-09-17 15:11:20 +00:00
Ed Sanders abad392272 Rename modules/VisualEditor to modules/ve-math
Per new naming convention (i.e. to be consistent with
ve-graph).

Change-Id: I3eae4ce011f0078b204d882a8068f844cd19daa3
2015-09-17 15:10:30 +00:00