Commit graph

296 commits

Author SHA1 Message Date
daniel 43dd9c7f63 Introduce MathInternalRestbaseURL setting.
This new MathInternalRestbaseURL setting allows the internal URL of
Mathoid to be configured directly, instead of relying on
VirtualRestConfig.

This patch moves the fallback logic for the internal and external API
URL into an extension registration callback. This way, we can keep the
application logic simple, and we can issue config warnings that will
cause the updater to fail, forcing wiki owners to update their config.

Bug: T334842
Change-Id: I2fbc441955a1fe417f264f31f3729ce0715f7f16
2023-05-30 09:48:03 +00:00
rrana-wmf 5926f42b52 Use MultiHttpClient instead of VirtualRESTService.
This fixes the problems with If208753edfdb301 which was reverted
and adds a new test.

Bug: T335347
Co-Authored-By: <rrana-ctr@wikimedia.org>
Change-Id: I7ddb7b294cbccc4dab42e286fc270f438385bee5
2023-05-20 16:57:46 +00:00
Subramanya Sastry de76f99d3d Revert "Revert "Add getMultiHttpClient function to make HTTP requests to Mathoid.""
This reverts commit a38e56c3fc and
reapplies 38c73d9b7a

Bug: T335347
Change-Id: Ib5f82c022d6ff435a807f8f4128a308f3dacc455
2023-05-16 13:07:32 +00:00
Daniel Kinzler a38e56c3fc Revert "Add getMultiHttpClient function to make HTTP requests to Mathoid."
This reverts commit 38c73d9b7a.

Reason for revert: Breaks math on Beta, shouldn't go live.

Change-Id: I62c63e20c94ddc25c5c291ba42afd28e153b34a6
2023-05-12 10:23:31 +00:00
rrana-wmf 38c73d9b7a Add getMultiHttpClient function to make HTTP requests to Mathoid.
This add new function named "getMultiHttpClient" to the
MathRestbaseInterface.
The function creates a MultiHttpClient object using the HTTP
request factory.

This function will be useful for making HTTP requests to Mathoid.

Add test case for getUrl() method.

Bug: T335347
Change-Id: If208753edfdb3017f722c97cea7653170d05f8a5
2023-05-11 17:58:50 +00:00
Umherirrender 35660f4e78 Replace deprecated Hooks::run
Bug: T335536
Change-Id: I6968c26df6819f0c83105e92c03d1d204f90db27
2023-05-06 23:11:13 +02:00
Umherirrender b654cc2b0a Replace deprecated Hooks::run
Bug: T335536
Change-Id: I6ef724346dd82147ef22af23833c6a0af8bc9054
2023-04-27 22:51:38 +02:00
jenkins-bot be27ddb2f1 Merge "Fix issues with DQ" 2023-04-20 16:07:27 +00:00
Stegmujo b1edd31543
Fix issues with DQ
Bug: T315978
Change-Id: I04c9178ce5785f29ab79de6dc82070465efca611
2023-04-20 10:57:04 +02:00
gerritbot e492f9189e Update moved class TitleFactory
See T321882
Moved in Iac1688172ee457

Bug: T321681
Change-Id: I713374ad7f9cfe1ba476d2b8729b2164cb5a4f56
2023-04-19 17:16:36 +00:00
Stegmujo 6e0427c2ba
Fix for attributes in named Operator
Bug: T315978
Change-Id: I7277d03bae031ffcb2995c097f92c795cc2637dd
2023-04-06 13:44:58 +02:00
Stegmujo c9cf3814ac
Fix for carriage return
Bug: T315978
Change-Id: I06728d45daa060655e655bb07717f23eef61a955
2023-04-06 11:40:54 +02:00
jenkins-bot df0fbc7ebd Merge "Fix style tag imbalance" 2023-04-06 07:10:30 +00:00
Stegmujo fa1a5a4b3f
Fix style tag imbalance
* sometimes there have been more start-tags than end style tags

Bug: T315978
Change-Id: I6b20d45d7561b084376a54f4d6273a2ff5ed7bb4
2023-04-05 15:48:03 +02:00
Stegmujo 08b16c99df
Fix preceding subscript
* example: "{}_1^2\!\Omega_3^4"
* MMLFullcoverageTest cases: 119, 381
* Add isEmpty method to TexNode
* Add empty mrow for prescripts

Bug: T327391
Change-Id: If60e5211bf43e50465072c049d8c432e621832b8
2023-04-05 13:00:06 +02:00
jenkins-bot db160076f0 Merge "Improve performance: remove redundant inputPreparation calls" 2023-03-31 09:27:46 +00:00
Moritz Schubotz (physikerwelt) 8c6eeae82e
Remove images from native MathML
In native MathML we only display MathML, also get
rid of enclosing <div / <span container.

Bug: T182041
Change-Id: I26bc4ea88d360d53cc7a34a89bef78812b84b2ea
2023-03-31 08:57:55 +02:00
Stegmujo 9213f93b88 Improve performance: arrange methods by call probability
* checked this with: EnWikiFormulaeTest.php
* remove finding chem macro from BaseMethods::checkAndParse, because
  this will be used somewhere else
* minor: remove mi from mathFont parsing function

Bug: T321599
Change-Id: I472e3ebdebfc91f97c9391268a384f788571612e
2023-03-28 17:29:03 +00:00
Stegmujo 7cd58420f7 Improve performance: remove redundant inputPreparation calls
Bug: T321599
Change-Id: I215b8883ace411933e7cbcd59b97df10dcc68d38
2023-03-28 12:39:08 +00:00
Stegmujo 5de6683c05
Fix colors
* some tests for checking colors

Bug: T327391
Change-Id: I437f8d72834f3cca7c21f97841ee4da2f1f36ed5
2023-03-27 14:42:27 +02:00
Stegmujo 030143cf14
Fix texstyle when rendering limits
* case index in FullCoverageTest: 144

Bug: T332183
Change-Id: I4bc427c00ffc83d53a91b094c7bde05a816f0f98
2023-03-24 16:15:45 +01:00
Stegmujo 0df4e38547
Fix derivatives
* indices in FullCoverageTest: 114, 124

Bug: T331998
Change-Id: I99724427b77e14044070d330758fb38a55032a10
2023-03-24 11:42:29 +01:00
jenkins-bot c8cdfcadcc Merge "Fix spaces defined by tilde and backslash" 2023-03-22 16:13:52 +00:00
Stegmujo 426a67fbd7
Fix P rendered as pilcrow
* contains a minor fix for spacings, so that they are rendered by spacer
* and some minor fixes for section sign
* MMLFullCoverageTest cases: 216

Bug: T327391
Change-Id: I124e7aec5552dec98a8292e5bdb9449a3009560a
2023-03-22 14:28:57 +01:00
Stegmujo 95816376c1
Fix spaces defined by tilde and backslash
* MMLFullCoverageTest case: 261

Bug: T327391
Change-Id: I99def9fe47ceb4471826e96e25562c070c0f1303
2023-03-22 11:31:51 +01:00
jenkins-bot 6e0181335f Merge "Fix spaces not rendering if within mtext" 2023-03-21 18:46:03 +00:00
jenkins-bot 0f154e86b7 Merge "Split latex_function_names and braces" 2023-03-21 18:41:04 +00:00
Stegmujo 5f9ca781d1
Fix spaces not rendering if within mtext
* MMLFullCoverageTest case: 260

Bug: T327391
Change-Id: Ifd858216b646efd53c401ac9bcddfc7fb1c1a933
2023-03-21 14:57:55 +01:00
Stegmujo ad2a6b7fef
Fix spaces and commas differentiation
* escaped semicolon/commas get rendered as spaces, non escaped get
  rendered as text
* MMLFullCoverageTest cases: 4,5,66

Bug: T327391
Change-Id: Icfa557fc43a8ac87fbf856795cb9c26d0fb2c456
2023-03-21 13:56:22 +01:00
Stegmujo e2f1e86ec0
Split latex_function_names and braces
* see also cid: If78e1506e17afeed23de446ca9b929c2d1366c44
* testindices Fullcoveragetest: 21
* also remove workaround for checking parentheses
* contains a postfix for limits, so the nested TexArray("\lim","") are
  read

Bug: T332183

Change-Id: If8d8487e33b762631fd90ce27baa6866e3539cc6
2023-03-20 16:21:30 +01:00
Stegmujo 1fa5ad3217
Fix preceding not
* indices in FullCoverageTest: 58,59
* fix a minor issue with less and greater signs to escape case 58
correctly

Bug: T331998
Change-Id: I29265f7954552423924dfc898fd36ec1b387e198
2023-03-16 11:46:53 +01:00
jenkins-bot abedeeef19 Merge "Fix varstigma" 2023-03-16 09:46:19 +00:00
Stegmujo f534da7558 Fix varstigma
* index in MMLTexUtilTest: 655

Bug: T331998
Change-Id: I57e5dfc843d04c85f3807c80ba6c24e5b4e5d3f9
2023-03-16 09:08:07 +00:00
Stegmujo 55068c5839 Fix a glitch in rendering style arguments
* now renders the succeeding elements instead of the style-info itself

* index in MMLTexUtilTest: 530

Bug: T331998
Change-Id: I0ad330157fa7687a2ad68a3d97b4c9cc942ea3ab
2023-03-16 07:52:40 +00:00
jenkins-bot c0281a9237 Merge "Fix gcd, min, max statements" 2023-03-15 15:15:34 +00:00
Stegmujo 89c9bb770e
Fix gcd, min, max statements
* with and without succeeding parentheses
* indices in FullCoverageTest: 21,22,33

Bug: T331998
Change-Id: I3a14db18764cc6df9b83249d19ed7de3b6489b1b
2023-03-15 10:42:46 +01:00
Moritz Schubotz (physikerwelt) c560ff0cd8
Remove MathPlayer
* MathPlayer stopped working around IE8

Bug: T298971
Change-Id: I759a5dc61eaf27a99d952366cf9c4380748f8e82
2023-03-15 10:20:13 +01:00
Stegmujo b843a09e92
Fix for limits
* example: "\lim\limits_{x \to 2}"
* case 4 phabricator: "limits-case"
* index: 411

Bug: T327391
Change-Id: I9a91e4cf49c9df89fb610057484165069f5c7e50
2023-03-14 11:10:31 +01:00
jenkins-bot ad668a6e69 Merge "Fix for sideset case" 2023-03-13 15:57:52 +00:00
Stegmujo b7d909e0a2 Fix for sideset case
* example "\sideset{_1^2}{_3^4}\sum"
* case 3 phabricator "sideset"
* index: 90
* since result has multiscripts which is not generated by mathoid, there is an explicit test in MMLRenderTest and the previous test is in MMLTexVCUtilTest is skipped
* in MMLGenerationTexUtilTest test for sideset is deactivated
* adds a case from FullCoverageTest for sideset with FQ
* fixes an issue which occured during Phan checks for merging that genFrac throws an error

Bug : T327391

Change-Id: I4c5a5f5a901dbc906f5a1b168d3a8d04f25b9290
2023-03-13 15:38:04 +00:00
libraryupgrader dcce2100d0 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 41.0.0

npm:
* cookiejar: 2.1.3 → 2.1.4
  * https://github.com/advisories/GHSA-h452-7996-h45h
* http-cache-semantics: 4.1.0 → 4.1.1
  * https://github.com/advisories/GHSA-rc47-6667-2j5j
* ua-parser-js: 1.0.2 → 1.0.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I4198e1cbdc115d27c9fe5b8d0ce813b514524796
2023-03-12 05:44:17 +00:00
jenkins-bot d7c931fbaa Merge "Add minimal native MML mode" 2023-03-07 11:45:31 +00:00
Moritz Schubotz (physikerwelt) aa828066df
Catch all exception during rendering
When switching to native MathML rendering more code is
beeing executed and Errors might be thrown. We want to make sure
that bugs in individual formulae don't break the display for the
entire page. Therefore, we extend the the catch clause to catch all
throwables.

Change-Id: I3deda42950bee75d9257135854535dd41a5e18dc
2023-03-02 22:19:38 +01:00
Moritz Schubotz (physikerwelt) 88a4c8bc1d
Add minimal native MML mode
* Add minimal POC for native MathML rendering.
* (minor) convert string-based reference to MathConfig to proper access
  method.

Missing:
 *  Error handling
 *  Image fallbacks

Bug: T331047

Change-Id: I7e644c4688cca7fc9af0d54bdc260268c1f6b9df
2023-03-02 20:50:29 +01:00
jenkins-bot 35257884ea Merge "Fix for tex-statement definecolor" 2023-03-02 11:16:20 +00:00
jenkins-bot 76686aa904 Merge "Introduce method to get checker" 2023-03-02 11:16:18 +00:00
Moritz Schubotz (physikerwelt) daadfad9ae
Introduce method to get checker
Allow MathRenderers to overwrite the way how the checker is initalized.
This will be needed for native MathML where LocalChecker will be used.

Change-Id: I358bef495675f7f8f9028f81484c4e535b9336f8
2023-03-02 11:41:15 +01:00
Stegmujo 8101c8f136
Fix for tex-statement definecolor
* example "\definecolor{ultramarine}{RGB}{0,32,96} a {b \color{ultramarine} c} d"
* case 2 phabricator: "colors"
* index: 22
* some test for parsing color statements

Bug: T327391
Change-Id: I98fdf011a2089dad4e7cb5a7a6aa8433fafe4a94
2023-03-02 11:35:27 +01:00
Stegmujo b9011e8e5b Fix for tex-statement "\pagecolor{red} e^{i \pi}"
* case 2 phabricator: "colors"
* index: 17

Bug: T327391
Change-Id: I202e13de8c07b63b0dfbff28036c9eb7fcc52db8
2023-03-01 15:26:03 +00:00
Stegmujo d23c6dc84d Fix for tex-statement "a {b \\color{red} c} d"
* case 2 phabricator: "colors"
* index: 16

Bug: T327391
Change-Id: I0c19dcc3819372c464d2ac0742160cec3bb8757a
2023-03-01 15:25:55 +00:00