wikimedia/mediawiki-extensions-Math
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Math synced 2024-11-27 17:01:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Avoid DBPerformance warnings in writeToDatabase()"

Browse source
This commit is contained in:
jenkins-bot 2016-06-10 08:34:56 +00:00 committed by Gerrit Code Review
parent 3de983d3ae 9a1dede261
commit a336d62a35
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
MathRenderer.php
View file

@ -330,28 +330,30 @@ abstract class MathRenderer {
public function writeToDatabase( $dbw = null ) { public function writeToDatabase( $dbw = null ) {
# Now save it back to the DB: # Now save it back to the DB:
if ( !wfReadOnly() ) { if ( !wfReadOnly() ) {
$dbw = $dbw ?: wfGetDB( DB_MASTER );
LoggerFactory::getInstance( 'Math' )->debug( 'Store entry for $' . $this->tex . LoggerFactory::getInstance( 'Math' )->debug( 'Store entry for $' . $this->tex .
'$ in database (hash:' . $this->getMd5() . ')' ); '$ in database (hash:' . $this->getMd5() . ')' );
$outArray = $this->dbOutArray(); $outArray = $this->dbOutArray();
$method = __METHOD__;
$mathTableName = $this->getMathTableName(); $mathTableName = $this->getMathTableName();
if ( $this->isInDatabase() ) { if ( $this->isInDatabase() ) {
$inputHash = $this->getInputHash(); $inputHash = $this->getInputHash();
$dbw->onTransactionIdle( function () use ( DeferredUpdates::addCallableUpdate( function () use (
$dbw, $outArray, $inputHash, $method, $mathTableName $dbw, $outArray, $inputHash, $mathTableName
) { ) {
$dbw = $dbw ?: wfGetDB( DB_MASTER );
$dbw->update( $mathTableName, $outArray, $dbw->update( $mathTableName, $outArray,
[ 'math_inputhash' => $inputHash ], $method ); [ 'math_inputhash' => $inputHash ], __METHOD__ );
LoggerFactory::getInstance( 'Math' )->debug( LoggerFactory::getInstance( 'Math' )->debug(
'Row updated after db transaction was idle: ' . 'Row updated after db transaction was idle: ' .
var_export( $outArray, true ) . " to database" ); var_export( $outArray, true ) . " to database" );
} ); } );
} else { } else {
$dbw->onTransactionIdle( function () use ( DeferredUpdates::addCallableUpdate( function () use (
$dbw, $outArray, $method, $mathTableName $dbw, $outArray, $mathTableName
) { ) {
$dbw->insert( $mathTableName, $outArray, $method, [ 'IGNORE' ] ); $dbw = $dbw ?: wfGetDB( DB_MASTER );
$dbw->insert( $mathTableName, $outArray, __METHOD__, [ 'IGNORE' ] );
LoggerFactory::getInstance( 'Math' )->debug( LoggerFactory::getInstance( 'Math' )->debug(
'Row inserted after db transaction was idle ' . 'Row inserted after db transaction was idle ' .
var_export( $outArray, true ) . " to database" ); var_export( $outArray, true ) . " to database" );