From 797c8ddfc94abb496cd2d9f23259080c4d2b40c8 Mon Sep 17 00:00:00 2001 From: Physikerwelt Date: Sat, 24 Dec 2016 13:04:07 +0000 Subject: [PATCH] Revert "Add class `mwe-math-element` to math elements" This reverts commit e674d7e73bf6816f4dcbee5bee35f09cb53b88e9. That commit does not help to solve T134281. It adds a CSS class name which is configurable by a global variable to various math elements, which is confusing. Change-Id: Iea5f231e0cea1221dc717b3409b36c0baf11bb24 --- MathMathML.php | 3 +-- MathSource.php | 2 -- MathTexvc.php | 2 -- extension.json | 3 +-- modules/ext.math.css | 4 ---- 5 files changed, 2 insertions(+), 12 deletions(-) diff --git a/MathMathML.php b/MathMathML.php index 681b90ba7..40bc77c49 100644 --- a/MathMathML.php +++ b/MathMathML.php @@ -418,7 +418,6 @@ class MathMathML extends MathRenderer { * @return string the class name */ private function getClassName( $fallback = false ) { - global $wgMathElementClassName; $class = 'mwe-math-'; if ( $fallback ) { $class .= 'fallback-image-'; @@ -435,7 +434,7 @@ class MathMathML extends MathRenderer { $class .= ' mwe-math-mathml-a11y'; // @codingStandardsIgnoreEnd } - return $class . " $wgMathElementClassName"; + return $class; } /** diff --git a/MathSource.php b/MathSource.php index 792e755d5..93d403d44 100644 --- a/MathSource.php +++ b/MathSource.php @@ -35,13 +35,11 @@ class MathSource extends MathRenderer { function getHtmlOutput() { # No need to render or parse anything more! # New lines are replaced with spaces, which avoids confusing our parser (bugs 23190, 22818) - global $wgMathElementClassName; if ( $this->getMathStyle() == 'display' ) { $class = 'mwe-math-fallback-source-display'; } else { $class = 'mwe-math-fallback-source-inline'; } - $class .= " $wgMathElementClassName"; return Xml::element( 'span', $this->getAttributes( 'span', diff --git a/MathTexvc.php b/MathTexvc.php index aa64ea086..6c61d8610 100644 --- a/MathTexvc.php +++ b/MathTexvc.php @@ -137,7 +137,6 @@ class MathTexvc extends MathRenderer { * @return string img HTML */ public function getMathImageHTML() { - global $wgMathElementClassName; $url = $this->getMathImageUrl(); $attributes = [ // the former class name was 'tex' @@ -149,7 +148,6 @@ class MathTexvc extends MathRenderer { // if DisplayStyle is true, the equation will be centered in a new line $attributes[ 'class' ] = 'mwe-math-fallback-image-display tex'; } - $attributes[ 'class' ] .= " $wgMathElementClassName"; return Xml::element( 'img', $this->getAttributes( 'img', diff --git a/extension.json b/extension.json index c9ce09323..a05965510 100644 --- a/extension.json +++ b/extension.json @@ -115,8 +115,7 @@ ], "MathEnableWikibaseDataType": true, "Texvc": false, - "TexvcBackgroundColor": "transparent", - "MathElementClassName": "mw-math-element" + "TexvcBackgroundColor": "transparent" }, "VisualEditorPluginModules": [ "ext.math.visualEditor" diff --git a/modules/ext.math.css b/modules/ext.math.css index 9892ce28e..69ea129b8 100644 --- a/modules/ext.math.css +++ b/modules/ext.math.css @@ -57,7 +57,3 @@ generated by Mathoid. See https://gerrit.wikimedia.org/r/#/c/166213/ */ img.tex { vertical-align: middle; } -.mwe-math-element { - overflow-x: auto; - max-width: 100%; -}