wikimedia/mediawiki-extensions-Math
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Math synced 2024-11-27 17:01:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make dataProvider in PopupTest static

Browse source 
Bug: T337160
Change-Id: I1c5384d319d9e34397ed4d94b4d9888d46722b91
This commit is contained in:
Moritz Schubotz (physikerwelt) 2023-10-21 22:56:26 +02:00 committed by Physikerwelt
parent e2ccab9687
commit 7965a91ae5
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/phpunit/unit/PopupTest.php
View file

@ -63,7 +63,8 @@ class PopupTest extends MathWikibaseConnectorTestFactory {
/**
* @dataProvider provideItemSetups
*/
public function testExistingId( Item $item ) {
public function testExistingId( bool $hasPart ) {
$item = $this->setupMassEnergyEquivalenceItem( $hasPart );
$popupHandler = $this->getPopup( null, null, $item );
$request = $this->getRequest( '1', 'en' );
@ -134,10 +135,10 @@ class PopupTest extends MathWikibaseConnectorTestFactory {
return new Popup( $mathWikibaseConnectorMock, $languageFactoryMock, $languageNameUtilsMock, $titleFactoryMock );
}
public function provideItemSetups(): array {
public static function provideItemSetups(): array {
return [
[ $this->setupMassEnergyEquivalenceItem( true ) ],
[ $this->setupMassEnergyEquivalenceItem( false ) ],
[ true ],
[ false ],
];
}
}