wikimedia/mediawiki-extensions-Math
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Math synced 2024-11-14 11:15:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Use RepoLinker for MathWikibaseConnector::buildURL()"

Browse source
This commit is contained in:
jenkins-bot 2021-07-21 10:21:50 +00:00 committed by Gerrit Code Review
parent 08ab221307 86af4f10cd
commit 77c4b6c561
1 changed files with 3 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/MathWikibaseConnector.php
View file

@ -12,6 +12,7 @@ use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\EntityIdParsingException;
use Wikibase\DataModel\Entity\EntityIdValue;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Services\Lookup\LabelDescriptionLookup;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\Snak;
@ -242,26 +243,11 @@ class MathWikibaseConnector {
}
/**
* @todo should be refactored once there is an easier way to get the URL
* @param string $qID
* @return string
*/
public static function buildURL( $qID ) {
$settings = WikibaseClient::getSettings();
$baseurl = $settings->getSetting( 'repoUrl' );
$articlePath = $settings->getSetting( 'repoArticlePath' );
$namespaces = $settings->getSetting( 'repoNamespaces' );
$url = $baseurl . $articlePath;
if ( $namespaces && $namespaces["item"] ) {
$articleId = $namespaces["item"] . ":" . $qID;
} else {
$articleId = $qID;
}
// repoArticlePath contains the placeholder $1 for the page title
// see: https://www.mediawiki.org/wiki/Manual:$wgArticlePath
return str_replace( '$1', $articleId, $url );
return WikibaseClient::getRepoLinker()
->getEntityUrl( new ItemId( $qID ) );
}
}