wikimedia/mediawiki-extensions-Math
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Math synced 2024-11-23 23:25:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary local context variables

Browse source 
Change-Id: I662e6e5e11dbf814755792ff64dc51aac77b7d6d
This commit is contained in:
Ed Sanders 2024-06-07 15:25:35 +01:00
parent 39c15f76f9
commit 28dcf9e6eb
2 changed files with 16 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/mw.widgets.MathWbEntitySelector.js
View file

@ -86,14 +86,13 @@
mw.widgets.MathWbEntitySelector.prototype.getLookupRequest = function () {
const api = this.getApi(),
query = this.getQueryValue(),
widget = this,
promiseAbortObject = {
abort: function () {
// Do nothing. This is just so OOUI doesn't break due to abort being undefined.
// see also mw.widgets.TitleWidget.prototype.getSuggestionsPromise
}
},
req = api.get( widget.getApiParams( query ) );
req = api.get( this.getApiParams( query ) );
promiseAbortObject.abort = req.abort.bind( req );
return req.promise( promiseAbortObject );
};

33
modules/ve-math/ve.ui.MWLatexDialog.js
View file

@ -39,8 +39,6 @@ ve.ui.MWLatexDialog.static.symbolsModule = null;
* @inheritdoc
*/
ve.ui.MWLatexDialog.prototype.initialize = function () {
const dialog = this;
// Parent method
ve.ui.MWLatexDialog.super.prototype.initialize.call( this );
@ -137,7 +135,7 @@ ve.ui.MWLatexDialog.prototype.initialize = function () {
this.pages = [];
this.symbolsPromise = mw.loader.using( this.constructor.static.symbolsModule ).done( ( require ) => {
// eslint-disable-next-line security/detect-non-literal-require
const symbols = require( dialog.constructor.static.symbolsModule );
const symbols = require( this.constructor.static.symbolsModule );
const symbolData = {};
for ( const category in symbols ) {
const symbolList = symbols[ category ].filter( ( symbol ) => {
@ -173,21 +171,21 @@ ve.ui.MWLatexDialog.prototype.initialize = function () {
symbols: symbolList
};
}
dialog.bookletLayout.setSymbolData( symbolData );
dialog.bookletLayout.connect( dialog, {
this.bookletLayout.setSymbolData( symbolData );
this.bookletLayout.connect( this, {
choose: 'onSymbolChoose'
} );
// Append everything
formulaPanel.$element.append(
dialog.previewElement.$element,
this.previewElement.$element,
inputField.$element
);
dialog.menuLayout.setMenuPanel( dialog.bookletLayout );
dialog.menuLayout.setContentPanel( formulaPanel );
this.menuLayout.setMenuPanel( this.bookletLayout );
this.menuLayout.setContentPanel( formulaPanel );
formulaTabPanel.$element.append(
dialog.menuLayout.$element
this.menuLayout.$element
);
optionsTabPanel.$element.append(
displayField.$element,
@ -195,9 +193,9 @@ ve.ui.MWLatexDialog.prototype.initialize = function () {
qidField.$element
);
dialog.$body
this.$body
.addClass( 've-ui-mwLatexDialog-content' )
.append( dialog.indexLayout.$element );
.append( this.indexLayout.$element );
} );
};
@ -292,18 +290,17 @@ ve.ui.MWLatexDialog.prototype.getBodyHeight = function () {
* Handle the window resize event
*/
ve.ui.MWLatexDialog.prototype.onWindowManagerResize = function () {
const dialog = this;
this.input.loadingPromise.always( () => {
// Toggle short mode as necessary
// NB a change of mode triggers a transition...
dialog.menuLayout.$element.toggleClass(
've-ui-mwLatexDialog-menuLayout-short', dialog.menuLayout.$element.height() < 450
this.menuLayout.$element.toggleClass(
've-ui-mwLatexDialog-menuLayout-short', this.menuLayout.$element.height() < 450
);
// ...So wait for the possible menuLayout transition to finish
setTimeout( () => {
// Give the input the right number of rows to fit the space
const availableSpace = dialog.menuLayout.$content.height() - dialog.input.$element.position().top;
const availableSpace = this.menuLayout.$content.height() - this.input.$element.position().top;
// TODO: Compute this line height from the skin
const singleLineHeight = 21;
const border = 1;
@ -311,10 +308,10 @@ ve.ui.MWLatexDialog.prototype.onWindowManagerResize = function () {
const borderAndPadding = 2 * ( border + padding );
const maxInputHeight = availableSpace - borderAndPadding;
const minRows = Math.floor( maxInputHeight / singleLineHeight );
dialog.input.loadingPromise.done( () => {
dialog.input.setMinRows( minRows );
this.input.loadingPromise.done( () => {
this.input.setMinRows( minRows );
} ).fail( () => {
dialog.input.$input.attr( 'rows', minRows );
this.input.$input.attr( 'rows', minRows );
} );
}, OO.ui.theme.getDialogTransitionDuration() );
} );