wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-09-23 18:29:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Log the heck out of everything

Browse source 
Bug: T173888
Change-Id: I6cd0a8f953fd823d33bba60df3b9dcfe51d4b4a3
This commit is contained in:
Max Semenik 2017-08-22 18:54:10 -07:00
parent 4ad8bbde55
commit ffae5375df
1 changed files with 38 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
includes/LoginNotify.php
View file

@ -134,11 +134,16 @@ class LoginNotify implements LoggerAwareInterface {
*/
private function isKnownSystemFast( User $user, WebRequest $request ) {
$result = $this->userIsInCookie( $user, $request );
if ( $result === self::USER_KNOWN ) {
return $result;
if ( $result !== self::USER_KNOWN ) {
$result = $this->mergeResults( $result, $this->userIsInCache( $user, $request ) );
}
$result = $this->mergeResults( $result, $this->userIsInCache( $user, $request ) );
$this->log->debug( 'Checking cookies and cache for {user}: {result}', [
'function' => __METHOD__,
'user' => $user->getName(),
'result' => $result,
] );
return $result;
}
@ -408,6 +413,13 @@ class LoginNotify implements LoggerAwareInterface {
public function setCurrentAddressAsKnown( User $user ) {
$this->cacheLoginIP( $user );
$this->setLoginCookie( $user );
$this->log->debug( 'Recording user {user} as known',
[
'function' => __METHOD__,
'user' => $user->getName(),
]
);
}
/**
@ -456,10 +468,13 @@ class LoginNotify implements LoggerAwareInterface {
// FIXME, does this really make sense?
if ( $cookie === '' ) {
return self::USER_NO_INFO;
}
$result = self::USER_NO_INFO;
} else {
list( $userKnown, ) = $this->checkAndGenerateCookie( $user, $cookie );
return $userKnown ? self::USER_KNOWN : self::USER_NOT_KNOWN;
$result = $userKnown ? self::USER_KNOWN : self::USER_NOT_KNOWN;
}
return $result;
}
/**
@ -665,6 +680,14 @@ class LoginNotify implements LoggerAwareInterface {
'extra' => $extra,
'agent' => $user,
] );
$this->log->info( 'Sending a {type} notification to {user}',
[
'function' => __METHOD__,
'type' => $type,
'user' => $user->getName(),
]
);
}
/**
@ -788,6 +811,15 @@ class LoginNotify implements LoggerAwareInterface {
]
);
JobQueueGroup::singleton()->lazyPush( $job );
$this->log->debug( 'Login {status}, creating a job to verify {user}, result so far: {result}',
[
'function' => __METHOD__,
'status' => $type,
'user' => $user->getName(),
'result' => $resultSoFar,
]
);
}
/**