wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-09-23 10:20:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

i18n: Use native digits in login notify messages

Browse source 
Whenever a number should be put inside a message, `numParams` should
be used instead of `params` as the former considers number formatting
needed for locales having their own numerals.

Change-Id: I1d331040a6f872fbf12ebe142257e53c46f5a219
This commit is contained in:
Ebrahim Byagowi 2022-11-18 01:00:27 +03:30 committed by Ebrahim
parent 1a75dd2331
commit f08f38032d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/PresentationModel.php
View file

@ -41,7 +41,7 @@ class PresentationModel extends EchoEventPresentationModel {
case 'login-fail-new':
$msg = $this->msg( 'notification-loginnotify-login-fail-email-subject' );
$msg->params( $this->getUser()->getName() );
$msg->params( $this->event->getExtraParam( 'count', 0 ) );
$msg->numParams( $this->event->getExtraParam( 'count', 0 ) );
break;
default:
$msg = $this->msg( 'notification-loginnotify-login-success-email-subject' );
@ -61,7 +61,7 @@ class PresentationModel extends EchoEventPresentationModel {
// Known IP? Don't bundle because we issue notifications after every 5 attempts anyway
case 'login-fail-known':
$msg = $this->msg( 'notification-known-header-login-fail' );
$msg->params( $this->event->getExtraParam( 'count', 0 ) );
$msg->numParams( $this->event->getExtraParam( 'count', 0 ) );
break;
// New IP?
case 'login-fail-new':
@ -75,12 +75,12 @@ class PresentationModel extends EchoEventPresentationModel {
},
0
);
$msg->params( $totalAttempts );
$msg->numParams( $totalAttempts );
} else {
// If the bundle is read or user goes to Special:Notifications, show
// one notification per attempt (aligned with how unbundled bundles work)
$msg = $this->msg( 'notification-new-unbundled-header-login-fail' );
$msg->params( $this->event->getExtraParam( 'count', 0 ) );
$msg->numParams( $this->event->getExtraParam( 'count', 0 ) );
}
break;
default: