wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-11-28 00:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Migrate ILB::getConnectionRef() calls to ILB::getMaintenanceConnectionRef()

Browse source 
Deprecated since 1.39 (I6e7544763bd)

Remove deprecated ILB::reuseConnection() calls as well

Bug: T343277
Change-Id: I477c216fe75bb393fc892ded13f3d117b6fda4aa
This commit is contained in:
gerritbot 2023-08-01 20:59:02 +00:00 committed by Umherirrender
parent 02e4e6ac72
commit eb79e7b8b8
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/LoginNotify.php
View file

@ -290,11 +290,10 @@ class LoginNotify implements LoggerAwareInterface {
$lb = MediaWikiServices::getInstance() $lb = MediaWikiServices::getInstance()
->getDBLoadBalancerFactory() ->getDBLoadBalancerFactory()
->getMainLB( $wiki ); ->getMainLB( $wiki );
$dbrLocal = $lb->getConnectionRef( DB_REPLICA, [], $wiki ); $dbrLocal = $lb->getMaintenanceConnectionRef( DB_REPLICA, [], $wiki );
if ( !$this->hasCheckUserTables( $dbrLocal ) ) { if ( !$this->hasCheckUserTables( $dbrLocal ) ) {
// Skip this wiki, no checkuser table. // Skip this wiki, no checkuser table.
$lb->reuseConnection( $dbrLocal );
continue; continue;
} }
// FIXME The case where there are no CU entries for // FIXME The case where there are no CU entries for
@ -306,7 +305,6 @@ class LoginNotify implements LoggerAwareInterface {
); );
if ( $res === self::USER_KNOWN ) { if ( $res === self::USER_KNOWN ) {
$lb->reuseConnection( $dbrLocal );
return $res; return $res;
} }
if ( $result === self::USER_NO_INFO if ( $result === self::USER_NO_INFO
@ -314,7 +312,6 @@ class LoginNotify implements LoggerAwareInterface {
) { ) {
$result = self::USER_NOT_KNOWN; $result = self::USER_NOT_KNOWN;
} }
$lb->reuseConnection( $dbrLocal );
$count++; $count++;
} }
} }