wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-11-28 00:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Do not record failures for non-existent accounts"

Browse source
This commit is contained in:
jenkins-bot 2017-08-23 21:59:28 +00:00 committed by Gerrit Code Review
parent b29ecb7953 a30621f412
commit deef3ee3cd
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/LoginNotify.php
View file

@ -738,6 +738,16 @@ class LoginNotify implements LoggerAwareInterface {
*/ */
public function recordFailure( User $user ) { public function recordFailure( User $user ) {
$this->incrStats( 'fail.total' ); $this->incrStats( 'fail.total' );
if ( $user->isAnon() ) {
// Login failed because user doesn't exist
// skip this user.
$this->log->debug( "Skipping recording failure for {user} - no account",
[ 'user' => $user->getName() ]
);
return;
}
$known = $this->isKnownSystemFast( $user, $user->getRequest() ); $known = $this->isKnownSystemFast( $user, $user->getRequest() );
if ( $known === self::USER_KNOWN ) { if ( $known === self::USER_KNOWN ) {
$this->recordLoginFailureFromKnownSystem( $user ); $this->recordLoginFailureFromKnownSystem( $user );