wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-09-23 18:29:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make Phan tests pass

Browse source 
Change-Id: Iba9d41e30a68a2ce17ec890e1708a1196eda783d
This commit is contained in:
Max Semenik 2017-07-06 17:40:41 -07:00
parent 382bc31397
commit b9a09fdb13
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/LoginNotify.php
View file

@ -271,6 +271,8 @@ class LoginNotify implements LoggerAwareInterface {
/**
* Actually do the query of the check user table.
*
* @suppress PhanTypeMismatchArgument
*
* @note This catches and ignores database errors.
* @param int $userId User id number (Not necessarily for the local wiki)
* @param string $ipFragment Prefix to match against cuc_ip (from $this->getIPNetwork())
@ -304,6 +306,8 @@ class LoginNotify implements LoggerAwareInterface {
* If we have no info for user, we maybe don't treat it as
* an unknown IP, since user has no known IPs.
*
* @suppress PhanTypeMismatchArgument
*
* @todo FIXME Does this behaviour make sense, esp. with cookie check?
* @param int $userId User id number (possibly on foreign wiki)
* @param Database $dbr DB connection (possibly to foreign wiki)