wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-09-23 10:20:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

If the user is known in the slow path, don't forget to notify

Browse source 
If the IP address associated with a failed login is found in CheckUser
for the relevant user, the notification was previously omitted.
Notification of failure with a known IP was only possible when the IP
was in the cache or cookie. So, fix that.

Change-Id: I498e6b71d0fab9dd9af63c9c5f88fbcaf6a53fc3
(cherry picked from commit a247ba5c79)
This commit is contained in:
Tim Starling 2023-08-24 10:03:46 +10:00 committed by Reedy
parent 66d13a59d6
commit aba8545d1e
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/LoginNotify.php
View file

@ -801,6 +801,8 @@ class LoginNotify implements LoggerAwareInterface {
$isKnown = $this->isKnownSystemSlow( $user, $subnet, $resultSoFar );
if ( !$isKnown ) {
$this->recordLoginFailureFromUnknownSystem( $user );
} else {
$this->recordLoginFailureFromKnownSystem( $user );
}
}