From a247ba5c798872fe7155191793a85319923467e6 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Thu, 24 Aug 2023 10:03:46 +1000 Subject: [PATCH] If the user is known in the slow path, don't forget to notify If the IP address associated with a failed login is found in CheckUser for the relevant user, the notification was previously omitted. Notification of failure with a known IP was only possible when the IP was in the cache or cookie. So, fix that. Change-Id: I498e6b71d0fab9dd9af63c9c5f88fbcaf6a53fc3 --- includes/LoginNotify.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/LoginNotify.php b/includes/LoginNotify.php index 5ea1c16..5413b8c 100644 --- a/includes/LoginNotify.php +++ b/includes/LoginNotify.php @@ -798,6 +798,8 @@ class LoginNotify implements LoggerAwareInterface { $isKnown = $this->isKnownSystemSlow( $user, $subnet, $resultSoFar ); if ( !$isKnown ) { $this->recordLoginFailureFromUnknownSystem( $user ); + } else { + $this->recordLoginFailureFromKnownSystem( $user ); } }