wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-11-11 16:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded @codingStandardsIgnore

Browse source 
* Break long lines
* Sniff fixed, see T178725

Change-Id: Iaeea06ece1c58f625dfdd3e0e9f6bd53351cc104
This commit is contained in:
Umherirrender 2018-03-27 20:07:54 +02:00
parent 70d2195460
commit 866f1883b4
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
maintenance/migratePreferences.php
View file

@ -17,10 +17,9 @@ require_once "$IP/maintenance/Maintenance.php";
/**
* Cleans up old preference values
* @codingStandardsIgnoreStart
*/
class MigratePreferences extends LoggedUpdateMaintenance {
// @codingStandardsIgnoreEnd
// Previously, these constants were used by Hooks to force different per-user defaults
const OPTIONS_FAKE_TRUTH = 2;
const OPTIONS_FAKE_FALSE = 'fake-false';

12
tests/phpunit/LoginNotifyTest.php
View file

@ -4,7 +4,6 @@ use LoginNotify\LoginNotify;
use \Psr\Log\NullLogger;
use Wikimedia\TestingAccessWrapper;
// @codingStandardsIgnoreStart Generic.Files.LineLength.TooLong
/**
* @covers \LoginNotify\LoginNotify
* @group LoginNotify
@ -26,7 +25,7 @@ class LoginNotifyTest extends MediaWikiTestCase {
"LoginNotifyCookieExpire" => 15552000,
"LoginNotifyCookieDomain" => null,
"LoginNotifyMaxCookieRecords" => 6,
"LoginNotifyCacheLoginIPExpiry" => 60*60*24*60
"LoginNotifyCacheLoginIPExpiry" => 60 * 60 * 24 * 60
] );
$this->inst = TestingAccessWrapper::newFromObject(
new LoginNotify(
@ -214,7 +213,10 @@ class LoginNotifyTest extends MediaWikiTestCase {
if ( !isset( $newCookieParts[1] ) ) {
$newCookieParts[1] = '';
}
$this->assertTrue( $this->inst->isUserRecordGivenCookie( $user, $newCookieParts[0] ), "[Cookie new entry] $desc" );
$this->assertTrue(
$this->inst->isUserRecordGivenCookie( $user, $newCookieParts[0] ),
"[Cookie new entry] $desc"
);
$this->assertEquals( $expectedNewCookie, $newCookieParts[1], "[Cookie] $desc" );
}
@ -239,7 +241,8 @@ class LoginNotifyTest extends MediaWikiTestCase {
],
[
$u1,
"$cookieOtherUser.$y-.$y-abcdefg-8oerxg4l59zpiu0by7m2to1b4cjeer4.$oldYear-1234567-tpnsk00419wba6vjh1upif21qtst1cv",
"$cookieOtherUser.$y-.$y-abcdefg-8oerxg4l59zpiu0by7m2to1b4cjeer4.$oldYear-" .
"1234567-tpnsk00419wba6vjh1upif21qtst1cv",
false,
"$cookieOtherUser.$y-abcdefg-8oerxg4l59zpiu0by7m2to1b4cjeer4",
"old values in cookie"
@ -328,4 +331,3 @@ class LoginNotifyTest extends MediaWikiTestCase {
);
}
}
// @codingStandardsIgnoreEnd