wikimedia/mediawiki-extensions-LoginNotify
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/LoginNotify synced 2024-11-24 15:04:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Log usage statistics

Browse source 
Bug: T170345
Change-Id: I7ec1214800062d9a22cd3fe0ce2ee9031fc9e21e
This commit is contained in:
Max Semenik 2017-07-28 11:09:20 -07:00
parent affc40d85a
commit 3b9faadf7d
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Hooks.php
View file

@ -151,7 +151,7 @@ class Hooks {
*
* @param User $user The user who logged in.
*/
public static function doSuccessfulLogin( User $user ) {
private static function doSuccessfulLogin( User $user ) {
$loginNotify = new LoginNotify();
$loginNotify->clearCounters( $user );
$loginNotify->sendSuccessNotice( $user );
@ -163,7 +163,7 @@ class Hooks {
*
* @param User $user The user that failed to log in.
*/
public static function doFailedLogin( User $user ) {
private static function doFailedLogin( User $user ) {
$loginNotify = new LoginNotify();
$loginNotify->recordFailure( $user );
}

19
includes/LoginNotify.php
View file

@ -12,6 +12,7 @@ use BagOStuff;
use CentralAuthUser;
use Config;
use EchoEvent;
use IBufferingStatsdDataFactory;
use JobQueueGroup;
use JobSpecification;
use MediaWiki\MediaWikiServices;
@ -55,6 +56,8 @@ class LoginNotify implements LoggerAwareInterface {
private $gSalt;
/** @var string */
private $secret;
/** @var IBufferingStatsdDataFactory */
private $stats;
/**
* Constructor
@ -83,6 +86,8 @@ class LoginNotify implements LoggerAwareInterface {
$log = LoggerFactory::getInstance( 'LoginNotify' );
$this->log = $log;
$this->stats = MediaWikiServices::getInstance()->getStatsdDataFactory();
}
/**
@ -618,6 +623,7 @@ class LoginNotify implements LoggerAwareInterface {
$this->config->get( 'LoginNotifyExpiryNewIP' )
);
if ( $count ) {
$this->incrStats( 'fail.unknown.notifications' );
$this->sendNotice( $user, 'login-fail-new', $count );
}
}
@ -637,6 +643,7 @@ class LoginNotify implements LoggerAwareInterface {
$this->config->get( 'LoginNotifyExpiryKnownIP' )
);
if ( $count ) {
$this->incrStats( 'fail.known.notifications' );
$this->sendNotice( $user, 'login-fail-known', $count );
}
}
@ -704,6 +711,7 @@ class LoginNotify implements LoggerAwareInterface {
* @param User $user User in question
*/
public function recordFailure( User $user ) {
$this->incrStats( 'fail.total' );
$known = $this->isKnownSystemFast( $user, $user->getRequest() );
if ( $known === self::USER_KNOWN ) {
$this->recordLoginFailureFromKnownSystem( $user );
@ -737,6 +745,7 @@ class LoginNotify implements LoggerAwareInterface {
if ( !$this->config->get( 'LoginNotifyEnableOnSuccess' ) ) {
return;
}
$this->incrStats( 'success.total' );
$result = $this->isKnownSystemFast( $user, $user->getRequest() );
if ( $result !== self::USER_KNOWN ) {
$this->createJob( DeferredChecksJob::TYPE_LOGIN_SUCCESS,
@ -755,6 +764,7 @@ class LoginNotify implements LoggerAwareInterface {
public function sendSuccessNoticeDeferred( User $user, $subnet, $resultSoFar ) {
$isKnown = $this->isKnownSystemSlow( $user, $subnet, $resultSoFar );
if ( !$isKnown ) {
$this->incrStats( 'success.notifications' );
$this->sendNotice( $user, 'login-success' );
}
}
@ -779,4 +789,13 @@ class LoginNotify implements LoggerAwareInterface {
);
JobQueueGroup::singleton()->lazyPush( $job );
}
/**
* Increments the given statistic
*
* @param string $metric
*/
private function incrStats( $metric ) {
$this->stats->increment( "loginnotify.$metric" );
}
}