Commit graph

12 commits

Author SHA1 Message Date
Bartosz Dziewoński a51f750f83 Handle VisualEditor when it skips the "tempWikitextEditor" stage
Depending on the user's internet connection, the code that sets up
mw.libs.ve.tempWikitextEditor may be completely skipped if the normal
editor code loads fast enough.

Refactor the code to handle all three cases using the same function.

Bug: T185279
Change-Id: I003b27f838d1986ed8d238089efd657b96e8ec91
2019-06-11 17:29:29 +02:00
Bartosz Dziewoński 6d0c6b6730 Fix VisualEditor (NWE) integration
The hook has been renamed from 've.tempWikitextReady' to
've.wikitextInteractive' in patchset 2 of changeset
I3678996bcf644cc889dd168ac3ce48b5c3633ec1 in mw/ext/VisualEditor,
but changeset I31a21e10b3fcd88fbce6881475f02a9d37df39c2 in this
repo was merged without being updated for that change.

Bug: T185279
Change-Id: I3256b0eb999e0259c3706697cd6a50459278af61
2019-06-11 17:28:11 +02:00
Bartosz Dziewoński d18262cfa1 Scroll the textbox to selection (error location) on page load
Only doing 'setSelection' doesn't guarantee that the textbox will be
scrolled (it works on Firefox and Edge, but not on Chrome and IE).

Bug: T152760
Change-Id: I3fab6363cd432d137430884eaca3555a7bf5aafa
2019-06-09 19:37:15 +00:00
James D. Forrester da89d77278 build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0
Change-Id: I17a163c3dd6d708b05d41786dce3dc9881250969
2019-04-03 16:06:08 -07:00
Ed Sanders 2e3f4ee488 build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I6299e2c479fe4106d180f6969f0abda291c51819
2019-02-10 16:06:13 +00:00
Ed Sanders b8a03444dd build: Update devDependencies
eslint-config-wikimedia   0.5.0  →   0.8.1
 grunt-eslint             20.1.0  →  21.0.0

Change-Id: I8c0cc86c79760c4a6aaba5d8096c4bde2daad8be
2018-11-12 16:07:17 +00:00
Ed Sanders 1558e4515f Remove obsolete aliases from closures
Bug: T208951
Change-Id: I1375167c846b09943c174ae56482a8339d6051ed
2018-11-12 16:06:19 +00:00
Ed Sanders 6e379107c3 Fix NWE integration to use new tempWikitextEditor
Bug: T185279
Depends-On: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
Change-Id: I31a21e10b3fcd88fbce6881475f02a9d37df39c2
2018-01-22 10:28:36 -08:00
Ed Sanders f5df08a745 Use VE's new offset conversion method
Change-Id: I64767fccae26522fdce5287c5486c322108c168a
Depends-On: Idc960a37433c5b8d952a677d1529a25b94fac7f7
Depends-On: I1071faeec586fa2b44be810a35f8044800c8f800
2017-11-04 21:44:11 +00:00
Ed Sanders 25c8a5772e Wait for selection reset when setting selection in NWE
Change-Id: I05fc5678a6945c13c7f390cb30e7fac6efb2767f
2017-11-01 21:43:50 +00:00
Kunal Mehta 9c65d786e2 Support new wikitext editor for edit helper
Register a hook for when VE is finished initializing to select the error
section, just like the textbox-based editor.

Use the BeforePageDisplay hook so it runs on VE page loads too.

Bug: T160102
Change-Id: I59a7e0a3e8be32e4689cbf41c4904970902c4dff
2017-04-25 15:21:13 +01:00
Kunal Mehta bce5b31616 Initial commit
This configures a MediaWiki extension to recieve Parsoid's lint errors
and expose them to users.

Change-Id: Ie0776aecf145eb1c87c2a539ddf3ea8d35a899f5
2016-10-17 16:02:53 -07:00