Move LoadExtensionSchemaUpdatesHook handler to separate class

This hook is not allowed to have a service, so before we can add
services to the main Hooks class, it needs to be split out.

Change-Id: Ia7b4b8bf7c91ebb851c5de9f0f54f56b0993bf83

extension.json

@@ -27,10 +27,13 @@
 	"HookHandlers": {
 		"main": {
 			"class": "MediaWiki\\Linter\\Hooks"
+		},
+		"schema": {
+			"class": "MediaWiki\\Linter\\SchemaHooks"
 		}
 	},
 	"Hooks": {
-		"LoadExtensionSchemaUpdates": "main",
+		"LoadExtensionSchemaUpdates": "schema",
 		"BeforePageDisplay": "main",
 		"APIQuerySiteInfoGeneralInfo": "main",
 		"InfoAction": "main",

includes/Hooks.php

@@ -22,13 +22,11 @@ namespace MediaWiki\Linter;
 
 use ApiQuerySiteinfo;
 use Content;
-use DatabaseUpdater;
 use IContextSource;
 use MediaWiki\Api\Hook\APIQuerySiteInfoGeneralInfoHook;
 use MediaWiki\Hook\BeforePageDisplayHook;
 use MediaWiki\Hook\InfoActionHook;
 use MediaWiki\Hook\ParserLogLinterDataHook;
-use MediaWiki\Installer\Hook\LoadExtensionSchemaUpdatesHook;
 use MediaWiki\Logger\LoggerFactory;
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Page\Hook\RevisionFromEditCompleteHook;
@@ -45,58 +43,10 @@ class Hooks implements
 	APIQuerySiteInfoGeneralInfoHook,
 	BeforePageDisplayHook,
 	InfoActionHook,
-	LoadExtensionSchemaUpdatesHook,
 	ParserLogLinterDataHook,
 	RevisionFromEditCompleteHook,
 	WikiPageDeletionUpdatesHook
 {
-	/**
-	 * @param DatabaseUpdater $updater
-	 */
-	public function onLoadExtensionSchemaUpdates( $updater ) {
-		$dbType = $updater->getDB()->getType();
-		if ( $dbType === 'mysql' ) {
-			$updater->addExtensionTable( 'linter',
-				dirname( __DIR__ ) . '/sql/tables-generated.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_namespace',
-				dirname( __DIR__ ) . '/sql/patch-linter-add-namespace.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_template',
-				dirname( __DIR__ ) . '/sql/patch-linter-template-tag-fields.sql'
-			);
-			$updater->modifyExtensionField( 'linter', 'linter_params',
-				dirname( __DIR__ ) . '/sql/patch-linter-fix-params-null-definition.sql'
-			);
-		} elseif ( $dbType === 'sqlite' ) {
-			$updater->addExtensionTable( 'linter',
-				dirname( __DIR__ ) . '/sql/sqlite/tables-generated.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_namespace',
-				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-add-namespace.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_template',
-				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-template-tag-fields.sql'
-			);
-			$updater->modifyExtensionField( 'linter', 'linter_params',
-				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-fix-params-null-definition.sql'
-			);
-		} elseif ( $dbType === 'postgres' ) {
-			$updater->addExtensionTable( 'linter',
-				dirname( __DIR__ ) . '/sql/postgres/tables-generated.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_namespace',
-				dirname( __DIR__ ) . '/sql/postgres/patch-linter-add-namespace.sql'
-			);
-			$updater->addExtensionField( 'linter', 'linter_template',
-				dirname( __DIR__ ) . '/sql/postgres/patch-linter-template-tag-fields.sql'
-			);
-			$updater->modifyExtensionField( 'linter', 'linter_params',
-				dirname( __DIR__ ) . '/sql/postgres/patch-linter-fix-params-null-definition.sql'
-			);
-		}
-	}
-
 	/**
 	 * Hook: BeforePageDisplay
 	 *

includes/SchemaHooks.php

@@ -0,0 +1,73 @@
+<?php
+/**
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ */
+
+namespace MediaWiki\Linter;
+
+use DatabaseUpdater;
+use MediaWiki\Installer\Hook\LoadExtensionSchemaUpdatesHook;
+
+class SchemaHooks implements LoadExtensionSchemaUpdatesHook {
+	/**
+	 * @param DatabaseUpdater $updater
+	 */
+	public function onLoadExtensionSchemaUpdates( $updater ) {
+		$dbType = $updater->getDB()->getType();
+		if ( $dbType === 'mysql' ) {
+			$updater->addExtensionTable( 'linter',
+				dirname( __DIR__ ) . '/sql/tables-generated.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_namespace',
+				dirname( __DIR__ ) . '/sql/patch-linter-add-namespace.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_template',
+				dirname( __DIR__ ) . '/sql/patch-linter-template-tag-fields.sql'
+			);
+			$updater->modifyExtensionField( 'linter', 'linter_params',
+				dirname( __DIR__ ) . '/sql/patch-linter-fix-params-null-definition.sql'
+			);
+		} elseif ( $dbType === 'sqlite' ) {
+			$updater->addExtensionTable( 'linter',
+				dirname( __DIR__ ) . '/sql/sqlite/tables-generated.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_namespace',
+				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-add-namespace.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_template',
+				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-template-tag-fields.sql'
+			);
+			$updater->modifyExtensionField( 'linter', 'linter_params',
+				dirname( __DIR__ ) . '/sql/sqlite/patch-linter-fix-params-null-definition.sql'
+			);
+		} elseif ( $dbType === 'postgres' ) {
+			$updater->addExtensionTable( 'linter',
+				dirname( __DIR__ ) . '/sql/postgres/tables-generated.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_namespace',
+				dirname( __DIR__ ) . '/sql/postgres/patch-linter-add-namespace.sql'
+			);
+			$updater->addExtensionField( 'linter', 'linter_template',
+				dirname( __DIR__ ) . '/sql/postgres/patch-linter-template-tag-fields.sql'
+			);
+			$updater->modifyExtensionField( 'linter', 'linter_params',
+				dirname( __DIR__ ) . '/sql/postgres/patch-linter-fix-params-null-definition.sql'
+			);
+		}
+	}
+}