wikimedia/mediawiki-extensions-Linter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Linter synced 2024-09-23 18:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Allow registration of hidden lint rules"

Browse source
This commit is contained in:
jenkins-bot 2023-05-04 19:31:39 +00:00 committed by Gerrit Code Review
parent 6b8b1de830 d543552be9
commit 9aa8b8fee2
5 changed files with 34 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extension.json
View file

@ -191,10 +191,8 @@
},
"large-tables": {
"dbid": 20,
"enabled": false,
"priority": "low",
"has-name": true,
"parser-migration": true
"enabled": true,
"priority": "none"
}
}
},

7
includes/ApiQueryLintErrors.php
View file

@ -115,6 +115,7 @@ class ApiQueryLintErrors extends ApiQueryBase {
/** @inheritDoc */
public function getAllowedParams() {
$visibleCats = ( new CategoryManager() )->getVisibleCategories();
$invisibleCats = ( new CategoryManager() )->getinvisibleCategories();
return [
'categories' => [
ParamValidator::PARAM_TYPE => $visibleCats,
@ -122,6 +123,12 @@ class ApiQueryLintErrors extends ApiQueryBase {
// Default is to show all categories
ParamValidator::PARAM_DEFAULT => implode( '|', $visibleCats ),
],
'invisible-categories' => [
ParamValidator::PARAM_TYPE => $invisibleCats,
ParamValidator::PARAM_ISMULTI => true,
// Default is to show all categories
ParamValidator::PARAM_DEFAULT => implode( '|', $invisibleCats ),
],
'limit' => [
ParamValidator::PARAM_DEFAULT => 10,
ParamValidator::PARAM_TYPE => 'limit',

21
includes/CategoryManager.php
View file

@ -31,6 +31,7 @@ class CategoryManager {
private const HIGH = 'high';
private const MEDIUM = 'medium';
private const LOW = 'low';
private const NONE = 'none';
/**
* Map of category names to their hardcoded
@ -47,6 +48,7 @@ class CategoryManager {
self::HIGH => [],
self::MEDIUM => [],
self::LOW => [],
self::NONE => [],
];
/**
@ -95,6 +97,7 @@ class CategoryManager {
sort( $this->categories[self::HIGH] );
sort( $this->categories[self::MEDIUM] );
sort( $this->categories[self::LOW] );
sort( $this->categories[self::NONE] );
}
/**
@ -142,6 +145,13 @@ class CategoryManager {
return $this->categories[self::LOW];
}
/**
* @return string[]
*/
public function getNonePriority() {
return $this->categories[self::NONE];
}
/**
* Categories that are configured to be displayed to users
*
@ -155,6 +165,17 @@ class CategoryManager {
);
}
/**
* Categories that are configured to be displayed to users
*
* @return string[]
*/
public function getInvisibleCategories() {
return array_merge(
$this->categories[self::NONE]
);
}
/**
* Whether this category has a hardcoded id and can be
* inserted into the database

1
includes/Hooks.php
View file

@ -158,6 +158,7 @@ class Hooks implements
'high' => $catManager->getHighPriority(),
'medium' => $catManager->getMediumPriority(),
'low' => $catManager->getLowPriority(),
'none' => $catManager->getNonePriority(),
];
}

5
includes/SpecialLintErrors.php
View file

@ -235,7 +235,7 @@ class SpecialLintErrors extends SpecialPage {
}
$catManager = new CategoryManager();
if ( in_array( $par, $catManager->getVisibleCategories() ) ) {
if ( in_array( $par, $this->getSubpagesForPrefixSearch() ) ) {
$this->category = $par;
}
@ -342,7 +342,8 @@ class SpecialLintErrors extends SpecialPage {
* @return string[]
*/
protected function getSubpagesForPrefixSearch() {
return ( new CategoryManager() )->getVisibleCategories();
$categoryManager = new CategoryManager();
return array_merge( $categoryManager->getVisibleCategories(), $categoryManager->getInvisibleCategories() );
}
}