wikimedia/mediawiki-extensions-Linter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Linter synced 2024-11-11 16:59:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Convert to HookHandler

Browse source 
Change-Id: Ib8ad9a58e781f7dad4b047d170a8f689802c4bad
This commit is contained in:
Reedy 2022-09-07 02:54:33 +01:00
parent 89d3f6152b
commit 1c526b7443
3 changed files with 40 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
extension.json
View file

@ -24,14 +24,19 @@
"ExtensionMessagesFiles": {
"LinterAlias": "Linter.alias.php"
},
"HookHandlers": {
"main": {
"class": "MediaWiki\\Linter\\Hooks"
}
},
"Hooks": {
"LoadExtensionSchemaUpdates": "MediaWiki\\Linter\\Hooks::onLoadExtensionSchemaUpdates",
"BeforePageDisplay": "MediaWiki\\Linter\\Hooks::onBeforePageDisplay",
"APIQuerySiteInfoGeneralInfo": "MediaWiki\\Linter\\Hooks::onAPIQuerySiteInfoGeneralInfo",
"InfoAction": "MediaWiki\\Linter\\Hooks::onInfoAction",
"WikiPageDeletionUpdates": "MediaWiki\\Linter\\Hooks::onWikiPageDeletionUpdates",
"RevisionFromEditComplete": "MediaWiki\\Linter\\Hooks::onRevisionFromEditComplete",
"ParserLogLinterData": "MediaWiki\\Linter\\Hooks::onParserLogLinterData"
"LoadExtensionSchemaUpdates": "main",
"BeforePageDisplay": "main",
"APIQuerySiteInfoGeneralInfo": "main",
"InfoAction": "main",
"WikiPageDeletionUpdates": "main",
"RevisionFromEditComplete": "main",
"ParserLogLinterData": "main"
},
"APIModules": {
"record-lint": "MediaWiki\\Linter\\ApiRecordLint"

2
includes/ApiRecordLint.php
View file

@ -46,7 +46,7 @@ class ApiRecordLint extends ApiBase {
if ( !is_array( $data ) ) {
$this->dieWithError( 'apierror-linter-invalid-data', 'invalid-data' );
}
if ( Hooks::onParserLogLinterData(
if ( ( new Hooks )->onParserLogLinterData(
$params['page'], $params['revision'], $data
) ) {
$this->getResult()->addValue( $this->getModuleName(), 'success', true );

43
includes/Hooks.php
View file

@ -24,20 +24,36 @@ use ApiQuerySiteinfo;
use Content;
use DatabaseUpdater;
use IContextSource;
use MediaWiki\Api\Hook\APIQuerySiteInfoGeneralInfoHook;
use MediaWiki\Hook\BeforePageDisplayHook;
use MediaWiki\Hook\InfoActionHook;
use MediaWiki\Hook\ParserLogLinterDataHook;
use MediaWiki\Installer\Hook\LoadExtensionSchemaUpdatesHook;
use MediaWiki\Logger\LoggerFactory;
use MediaWiki\MediaWikiServices;
use MediaWiki\Page\Hook\RevisionFromEditCompleteHook;
use MediaWiki\Page\Hook\WikiPageDeletionUpdatesHook;
use MediaWiki\Revision\RevisionRecord;
use MediaWiki\User\UserIdentity;
use MWCallableUpdate;
use OutputPage;
use Skin;
use Title;
use WikiPage;
class Hooks {
class Hooks implements
APIQuerySiteInfoGeneralInfoHook,
BeforePageDisplayHook,
InfoActionHook,
LoadExtensionSchemaUpdatesHook,
ParserLogLinterDataHook,
RevisionFromEditCompleteHook,
WikiPageDeletionUpdatesHook
{
/**
* @param DatabaseUpdater $updater
*/
public static function onLoadExtensionSchemaUpdates( DatabaseUpdater $updater ) {
public function onLoadExtensionSchemaUpdates( $updater ) {
$dbType = $updater->getDB()->getType();
if ( $dbType === 'mysql' ) {
$updater->addExtensionTable( 'linter',
@ -78,9 +94,10 @@ class Hooks {
* If there is a lintid parameter, look up that error in the database
* and setup and output our client-side helpers
*
* @param OutputPage &$out
* @param OutputPage $out
* @param Skin $skin
*/
public static function onBeforePageDisplay( OutputPage &$out ) {
public function onBeforePageDisplay( $out, $skin ): void {
$request = $out->getRequest();
$lintId = $request->getInt( 'lintid' );
if ( !$lintId ) {
@ -113,9 +130,7 @@ class Hooks {
* @param Content $content
* @param array &$updates
*/
public static function onWikiPageDeletionUpdates( WikiPage $wikiPage,
Content $content, array &$updates
) {
public function onWikiPageDeletionUpdates( $wikiPage, $content, &$updates ) {
$id = $wikiPage->getId();
$updates[] = new MWCallableUpdate( static function () use ( $id ) {
$database = new Database( $id );
@ -139,12 +154,8 @@ class Hooks {
* @param UserIdentity $user
* @param string[] &$tags
*/
public static function onRevisionFromEditComplete(
WikiPage $wikiPage,
RevisionRecord $newRevisionRecord,
$originalRevId,
UserIdentity $user,
&$tags
public function onRevisionFromEditComplete(
$wikiPage, $newRevisionRecord, $originalRevId, $user, &$tags
) {
// This is just a stop-gap to deal with callers that aren't complying
// with the advertised hook signature.
@ -170,7 +181,7 @@ class Hooks {
* @param ApiQuerySiteInfo $api
* @param array &$data
*/
public static function onAPIQuerySiteInfoGeneralInfo( ApiQuerySiteinfo $api, array &$data ) {
public function onAPIQuerySiteInfoGeneralInfo( $api, &$data ) {
$catManager = new CategoryManager();
$data['linter'] = [
'high' => $catManager->getHighPriority(),
@ -187,7 +198,7 @@ class Hooks {
* @param IContextSource $context
* @param array &$pageInfo
*/
public static function onInfoAction( IContextSource $context, array &$pageInfo ) {
public function onInfoAction( $context, &$pageInfo ) {
$pageId = $context->getTitle()->getArticleID();
if ( !$pageId ) {
return;
@ -217,7 +228,7 @@ class Hooks {
* @param array[] $data
* @return bool
*/
public static function onParserLogLinterData(
public function onParserLogLinterData(
string $page, int $revision, array $data
): bool {
$errors = [];