From 12065c11ca6c9d4a736ddab30f55722eefaf6fb9 Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Sun, 20 Oct 2019 12:10:45 +0000 Subject: [PATCH] build: Bump mediawiki-phan-config to 0.8.0 Change-Id: Icbe64747c8c219882d419f4767704af96368b11a --- composer.json | 2 +- includes/ApiRecordLint.php | 1 + includes/LintErrorsPager.php | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index b448b753..052078ef 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,7 @@ "mediawiki/mediawiki-codesniffer": "28.0.0", "jakub-onderka/php-console-highlighter": "0.3.2", "mediawiki/minus-x": "0.3.2", - "mediawiki/mediawiki-phan-config": "0.6.1" + "mediawiki/mediawiki-phan-config": "0.8.0" }, "scripts": { "test": [ diff --git a/includes/ApiRecordLint.php b/includes/ApiRecordLint.php index fa7436ed..b1aba37f 100644 --- a/includes/ApiRecordLint.php +++ b/includes/ApiRecordLint.php @@ -47,6 +47,7 @@ class ApiRecordLint extends ApiBase { if ( !is_array( $data ) ) { $this->dieWithError( 'apierror-linter-invalid-data', 'invalid-data' ); } + '@phan-var array[] $data'; $errors = []; $title = Title::newFromText( $params['page'] ); diff --git a/includes/LintErrorsPager.php b/includes/LintErrorsPager.php index e0c839b1..b055ad83 100644 --- a/includes/LintErrorsPager.php +++ b/includes/LintErrorsPager.php @@ -182,6 +182,7 @@ class LintErrorsPager extends TablePager { if ( isset( $lintError->templateInfo['multiPartTemplateBlock'] ) ) { return $this->msg( 'multi-part-template-block' )->escaped(); } else { + // @phan-suppress-next-line PhanTypeArraySuspiciousNullable Null checked above $templateName = $lintError->templateInfo['name']; // Parsoid provides us with fully qualified template title // So, fallback to the default main namespace