2016-12-01 05:17:18 +00:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
|
|
*
|
|
|
|
* @file
|
|
|
|
*/
|
|
|
|
|
|
|
|
namespace MediaWiki\Linter\Test;
|
|
|
|
|
|
|
|
use MediaWiki\Linter\Database;
|
|
|
|
use MediaWiki\Linter\LintError;
|
2021-10-12 19:52:50 +00:00
|
|
|
use MediaWikiIntegrationTestCase;
|
2016-12-01 05:17:18 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @group Database
|
2022-09-07 01:48:18 +00:00
|
|
|
* @covers \MediaWiki\Linter\Database
|
2016-12-01 05:17:18 +00:00
|
|
|
*/
|
2021-10-12 19:52:50 +00:00
|
|
|
class DatabaseTest extends MediaWikiIntegrationTestCase {
|
2024-04-11 01:20:43 +00:00
|
|
|
private function getDatabase() {
|
|
|
|
return $this->getServiceContainer()->get( 'Linter.Database' );
|
2024-04-04 22:55:43 +00:00
|
|
|
}
|
|
|
|
|
2016-12-01 05:17:18 +00:00
|
|
|
public function testConstructor() {
|
2024-04-11 01:20:43 +00:00
|
|
|
$this->assertInstanceOf( Database::class, $this->getDatabase() );
|
2016-12-01 05:17:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
private function getDummyLintErrors() {
|
|
|
|
return [
|
|
|
|
new LintError(
|
|
|
|
'fostered', [ 0, 10 ], []
|
|
|
|
),
|
|
|
|
new LintError(
|
|
|
|
'obsolete-tag', [ 15, 20 ], [ 'name' => 'big' ]
|
|
|
|
),
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
private function assertSetForPageResult( $result, $deleted, $added ) {
|
|
|
|
$this->assertArrayHasKey( 'deleted', $result );
|
|
|
|
$this->assertEquals( $deleted, $result['deleted'] );
|
|
|
|
$this->assertArrayHasKey( 'added', $result );
|
|
|
|
$this->assertEquals( $added, $result['added'] );
|
|
|
|
}
|
|
|
|
|
|
|
|
private function assertLintErrorsEqual( $expected, $actual ) {
|
2021-05-04 07:58:08 +00:00
|
|
|
$expectedIds = array_map( static function ( LintError $error ) {
|
2016-12-01 05:17:18 +00:00
|
|
|
return $error->id();
|
|
|
|
}, $expected );
|
2021-05-04 07:58:08 +00:00
|
|
|
$actualIds = array_map( static function ( LintError $error ) {
|
2016-12-01 05:17:18 +00:00
|
|
|
return $error->id();
|
|
|
|
}, $actual );
|
|
|
|
$this->assertArrayEquals( $expectedIds, $actualIds );
|
|
|
|
}
|
|
|
|
|
2024-04-10 20:52:53 +00:00
|
|
|
private function createManyLintErrors(
|
|
|
|
$lintDb, int $pageId, int $namespaceId, $errorCount
|
|
|
|
) {
|
2021-04-07 19:33:16 +00:00
|
|
|
$manyLintErrors = [];
|
|
|
|
for ( $i = 0; $i < $errorCount; $i++ ) {
|
2022-08-03 18:48:32 +00:00
|
|
|
$templateName = "Template:Echo";
|
2021-04-07 19:33:16 +00:00
|
|
|
$manyLintErrors[] = new LintError(
|
2022-08-03 18:48:32 +00:00
|
|
|
'obsolete-tag', [ 15, 20 + $i ], [ 'name' => 'big',
|
|
|
|
"templateInfo" => [ "name" => $templateName ] ]
|
2021-04-07 19:33:16 +00:00
|
|
|
);
|
|
|
|
}
|
2024-04-10 20:52:53 +00:00
|
|
|
$lintDb->setForPage( $pageId, $namespaceId, $manyLintErrors );
|
2021-04-07 19:33:16 +00:00
|
|
|
}
|
|
|
|
|
2016-12-01 05:17:18 +00:00
|
|
|
public function testSetForPage() {
|
2024-04-10 20:52:53 +00:00
|
|
|
$pageId = 5;
|
|
|
|
$namespaceId = 0;
|
2024-04-11 01:20:43 +00:00
|
|
|
$lintDb = $this->getDatabase();
|
2016-12-01 05:17:18 +00:00
|
|
|
$dummyErrors = $this->getDummyLintErrors();
|
2024-04-10 20:52:53 +00:00
|
|
|
|
|
|
|
$result = $lintDb->setForPage( $pageId, $namespaceId, $dummyErrors );
|
2017-04-28 20:04:45 +00:00
|
|
|
$this->assertSetForPageResult( $result, [], [ 'fostered' => 1, 'obsolete-tag' => 1 ] );
|
2024-04-10 20:52:53 +00:00
|
|
|
$this->assertLintErrorsEqual( $dummyErrors, $lintDb->getForPage( $pageId ) );
|
2016-12-01 05:17:18 +00:00
|
|
|
|
2021-04-07 19:33:16 +00:00
|
|
|
// Accurate low error count values should match for both methods
|
2024-04-10 20:52:53 +00:00
|
|
|
$resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2021-04-07 19:33:16 +00:00
|
|
|
$resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
$this->assertEquals( $resultTotals, $resultEstimatedTotals );
|
|
|
|
|
2016-12-01 05:17:18 +00:00
|
|
|
// Should delete the second error
|
2024-04-10 20:52:53 +00:00
|
|
|
$result2 = $lintDb->setForPage( $pageId, $namespaceId, [ $dummyErrors[0] ] );
|
2017-04-28 20:04:45 +00:00
|
|
|
$this->assertSetForPageResult( $result2, [ 'obsolete-tag' => 1 ], [] );
|
2024-04-10 20:52:53 +00:00
|
|
|
$this->assertLintErrorsEqual( [ $dummyErrors[0] ], $lintDb->getForPage( $pageId ) );
|
2016-12-01 05:17:18 +00:00
|
|
|
|
2021-04-07 19:33:16 +00:00
|
|
|
// Accurate low error count values should match for both methods
|
2024-04-10 20:52:53 +00:00
|
|
|
$resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2021-04-07 19:33:16 +00:00
|
|
|
$resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
$this->assertEquals( $resultTotals, $resultEstimatedTotals );
|
|
|
|
|
2016-12-01 05:17:18 +00:00
|
|
|
// Insert the second error, delete the first
|
2024-04-10 20:52:53 +00:00
|
|
|
$result3 = $lintDb->setForPage( $pageId, $namespaceId, [ $dummyErrors[1] ] );
|
2017-04-28 20:04:45 +00:00
|
|
|
$this->assertSetForPageResult( $result3, [ 'fostered' => 1 ], [ 'obsolete-tag' => 1 ] );
|
2024-04-10 20:52:53 +00:00
|
|
|
$this->assertLintErrorsEqual( [ $dummyErrors[1] ], $lintDb->getForPage( $pageId ) );
|
2016-12-01 05:17:18 +00:00
|
|
|
|
|
|
|
// Delete the second (only) error
|
2024-04-10 20:52:53 +00:00
|
|
|
$result4 = $lintDb->setForPage( $pageId, $namespaceId, [] );
|
2017-04-28 20:04:45 +00:00
|
|
|
$this->assertSetForPageResult( $result4, [ 'obsolete-tag' => 1 ], [] );
|
2024-04-10 20:52:53 +00:00
|
|
|
$this->assertLintErrorsEqual( [], $lintDb->getForPage( $pageId ) );
|
2021-04-07 19:33:16 +00:00
|
|
|
|
|
|
|
// Accurate low error count values should match for both methods
|
2024-04-10 20:52:53 +00:00
|
|
|
$resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2021-04-07 19:33:16 +00:00
|
|
|
$resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
$this->assertEquals( $resultTotals, $resultEstimatedTotals );
|
|
|
|
|
2021-08-06 19:32:07 +00:00
|
|
|
// For error counts <= MAX_ACCURATE_COUNT, both error
|
2021-04-07 19:33:16 +00:00
|
|
|
// count methods should return the same count.
|
2024-04-10 20:52:53 +00:00
|
|
|
$this->createManyLintErrors( $lintDb, $pageId, $namespaceId, Database::MAX_ACCURATE_COUNT );
|
|
|
|
$resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2021-04-07 19:33:16 +00:00
|
|
|
$resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
$this->assertEquals( $resultTotals, $resultEstimatedTotals );
|
|
|
|
|
2022-08-04 16:11:38 +00:00
|
|
|
// FIXME: These tests seem to be making false assumptions about
|
|
|
|
// `estimateRowCount()`. "EXPLAIN" is just going to give an estimate of
|
|
|
|
// the row count, it doesn't seem like there's any guarantee that it'll
|
|
|
|
// be higher or lower.
|
|
|
|
//
|
|
|
|
// // For error counts greater than MAX_ACCURATE_COUNT, both error
|
|
|
|
// // count methods should NOT return the same count in this test scenario
|
|
|
|
// // because previously added and deleted records will be included
|
|
|
|
// // in the estimated count which is normal.
|
2024-04-10 20:52:53 +00:00
|
|
|
// $this->createManyLintErrors( $lintDb, $pageId, $namespaceId, Database::MAX_ACCURATE_COUNT + 1 );
|
|
|
|
// $resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2022-08-04 16:11:38 +00:00
|
|
|
// $resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
// $this->assertNotEquals( $resultTotals, $resultEstimatedTotals );
|
|
|
|
//
|
|
|
|
// // For error counts greatly above the MAX_ACCURATE_COUNT, the estimated
|
|
|
|
// // count method should return a greater count in this test scenario
|
|
|
|
// // because previously added and deleted records will be included
|
|
|
|
// // in the estimated count which is normal.
|
2024-04-10 20:52:53 +00:00
|
|
|
// $this->createManyLintErrors( $lintDb, $pageId, $namespaceId, Database::MAX_ACCURATE_COUNT * 10 );
|
|
|
|
// $resultTotals = $lintDb->getTotalsForPage( $pageId );
|
2022-08-04 16:11:38 +00:00
|
|
|
// $resultEstimatedTotals = $lintDb->getTotals();
|
|
|
|
// $this->assertGreaterThan( $resultTotals, $resultEstimatedTotals );
|
2016-12-01 05:17:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|