Commit graph

74 commits

Author SHA1 Message Date
Kunal Mehta f6ce2760fa build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment

Change-Id: Ie0c09ed8f75a93efcbd9668860b2e8f246957882
2017-06-25 13:42:06 +00:00
Siebrand Mazeland 884cb06122 Use mediawiki-codesniffer 0.6.0
Change-Id: I26c08d608da64a41fb9910598e4197692d119bc6
2016-03-18 14:46:17 -07:00
Siebrand Mazeland 8a62e6dfbd Replace deprecated method
Change-Id: Ief734bf89aea0c26a7121c687d930e91e3ac5611
2016-03-18 14:46:12 -07:00
Siebrand Mazeland 1ca07ef130 Fix name case mismatches
Change-Id: I0b0fcbfe3a00d4d4409b21c72f15dddb1ef5f985
2016-03-07 15:38:27 +01:00
Siebrand Mazeland 78dc23cc6f Declare functions with access modifiers
Change-Id: Ib7180f15a1c7c4a40cea9c2eedc318ed26f1edab
2016-03-07 15:38:25 +01:00
Siebrand Mazeland 3a31d027e8 Replace deprecated tag tt with code
Change-Id: I13552b15e79cbb36a01ca8463b6fbf48fdcc6371
2016-03-07 15:38:23 +01:00
Siebrand Mazeland cb068cd10c Use ternary
Change-Id: Ia803f27c86453fa03f76025c0e6f65bbeb9007b7
2016-03-07 15:37:14 +01:00
Siebrand Mazeland d6bc4712b6 Merge nested positive if()s
Change-Id: Iad54183b44b9e23dba975fcc8c14355395eb934e
2016-03-07 14:32:05 +00:00
Siebrand Mazeland 18b04e3035 Remove useless return
Change-Id: I95871913b146210164be76eb0b5e057a168a5bf0
2016-03-07 14:31:08 +00:00
Siebrand Mazeland c935dff562 Perform cheaper checks first
Change-Id: I54808896efdd302558f11b7d6ec6d01622657b92
2016-03-07 14:30:52 +00:00
Siebrand Mazeland ae1779b0e0 Suppress static code analysis check for a missing break
Change-Id: Id4079c1ff89ba26c5fc67f929699b624a231fa22
2016-03-07 14:30:20 +00:00
Aaron Schulz 07cde06f01 Define doesWrites() for SpecialPage classes
Bug: T123589
Change-Id: I44b9b03205b61aba3c542ef4221fcabc566e16d4
2016-01-15 13:53:45 -08:00
Alex Monk 143f6e7e0c List Special:Interwiki/add as a subpage in prefixsearch
Change-Id: I015877002952acef300ef86423e099665ec6bb8c
2015-12-28 21:58:31 +00:00
Paladox 2c50919476 Add php code sniffer
Also fix the single remaining sniffer warning.

Change-Id: I47b03d3947aac00e6396a01c1b8536559b06be2c
2015-09-28 18:19:43 +02:00
Kunal Mehta ac0107c79f Add missing global $wgInterwikiViewOnly declaration
Change-Id: Id36a124d9b99dd5ebb5e9f30a595a55733fa718a
2015-07-02 14:12:21 -07:00
zhuyifei1999 b9f76892a0 Special:Interwiki: Remove "View log" link when $wgInterwikiViewOnly is not set to false
Using same logic as in hooks.

Bug: T103353
Change-Id: I337f136441be299d2c36dc19b7464998c915a87a
2015-06-30 14:07:01 +00:00
Alex Monk 0445c65f9d chmod 644 Interwiki_body.php
Bug: T104040
Change-Id: I76d516d9d72b8ced57c3e191260144497e7c3f19
2015-06-27 19:04:39 +01:00
umherirrender 53cd67a722 Replace deprecated $wgSpecialPageGroups
$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I512120e9cf7245dbe2225c6bc5cc20549745ef04
2015-05-15 22:21:23 +02:00
Aaron Schulz c59acecce0 Use InterWiki::invalidateCache instead of DIY
Bug: T91815
Change-Id: Ifc6236791a2c5bc46a0dfc8f6779ceef962f0358
2015-04-30 01:32:00 +00:00
Bryan Davis 1beaee90bf Guard dereference of iwPrefix['iw_trans'] and iwPrefix['iw_local']
Ensure that array indices exist before access to avoid PHP interpreter
undefined index warnings.

Patch also includes trivial whitespace fixes to correct codesniff failures.

Change-Id: I87021a358a85eb3adf7a222fbaee70623dfd8770
2014-12-15 18:51:31 -07:00
Niklas Laxström e6bb22b81c Fix PHP notice
Found alias defined for Log when searching for special page aliases for log

Bug: 71870
Change-Id: I00c512fb5ae0d89164673f566adfd7047e41e56a
2014-11-21 07:12:04 +00:00
Reedy 22497b4aeb Fix file permissions
Bug: 71937
Change-Id: I9fb7e981daad73a29928e9d939abe881fe0e7e39
2014-10-14 18:13:20 +01:00
isarra 5812a662c2 Cleanup special:interwiki intro
* Move all the legend container stuff into the system message and added a
  header to the table.
* Merge interwiki_intro and interwiki_intro_footer into a single message,
  rewrite the content to be more useful, and also show it all to
  non-privileged users.
* Move the log link into its own message.
* Move the add new link above the legend as well, directly underneath the log
  link.

Change-Id: I184182d3171f362f2e8470008f4ea7cda6629f80
2014-09-15 17:42:13 +00:00
isarra ca46fc0350 Add support for enabling and displaying global interwikis
This effectively merges Extension:ShoutWikiInterwikiMagic into Interwiki
to add support for global interwikis, allowing sysadmins to set
$wgInterwikiCentralDB to a central wiki database from which to pull global
interwikis, which will be used alongside any locally-defined prefixes.

It also separates out the display of global, local, and language
interwikis into their own sections, improving the display even for
local-only projects.

Bug: 68241
Change-Id: I54c072c65f10dd0ad5f815c2649e7ce9ed1e7b58
2014-09-12 21:10:27 +00:00
isarra a8778ec2eb Make legend easier to read
Moves the legend table into a system message for easier editing, and reformats
the overall layout as well as changing some of the individual explanations.

Change-Id: I744dce4bbfb9d8623fc4df83def3860626482330
2014-08-23 22:10:42 +00:00
isarra 6fa8bf15df Remove hardcoded lime colour and reimplement colour-coding with class
This way it can be overridden by skins and stuff. Also, not lime.

Change-Id: I4f788a4c1c70928b9afb55598ebad031b4466e31
2014-07-18 21:38:40 +00:00
Kunal Mehta 3bfec2ffa9 Replace usage of SpecialPage::getTitle with getPageTitle
Was deprecated in 1.23, see Icdcf5d5295ef5e7f08b1d403e0c123f78738fd40

Change-Id: I1afffae3c772af6e2d7f8a285e7cf7265f568dd9
2013-12-30 12:26:07 +00:00
Siebrand Mazeland bcf15ec04c Fix CodeSniffer errors and warnings
Change-Id: I442b4e55521089ab64b049c8087985af202515dd
2013-08-02 16:33:29 +02:00
Ryan Finnie 22f2ee1ad5 Remove extraneous table close tag
The table this was intended to close is constructed by Html::rawElement
with a content parameter, which automatically closes the tag.

Change-Id: Ib87311c7143e0ad86fdd43a936b8231d5a42cf52
2013-01-21 12:20:32 -08:00
amire80 dc302f109f (bug 30600) Fix regression - show prefix on edit page
Patch by drzraf.

Change-Id: I868521faca8d0700014bd96836bb1cdeedb385b0
2012-09-14 06:04:21 -07:00
Amir E. Aharoni a94f2148d4 (bug 30600) Simple URL validation
Also changed the URL for the edit submit button, because it would
show an empty prefix in the error message.

Change-Id: Id18401447c08e9ea763ac08d75d6a8d0319dae31
2012-09-05 20:38:11 +03:00
Siebrand Mazeland f32b40b2b8 Replace deprecated User::editToken with User::getEditToken
Change-Id: I3382a27ee788eb5dc6b7b033987326ce1ab1dc91
2012-08-30 14:57:43 +02:00
Siebrand Mazeland 8931c47baf Interwiki maintenance.
* Make addInfoRow private and non-static, so local context can be used for messaging.
* Change <i> to <em>.
* Add .idea to .gitignore.

Change-Id: Icc2eb5bb9d5925683b94bdfc5b06306fb009caf4
2012-08-16 00:52:05 +02:00
Amir E. Aharoni bbc4c629b2 (Bug 30599) Filter problematic prefix characters
Change-Id: Icf0058407c51a314583907a54257cb10fa4826e5
2012-08-01 21:47:16 +03:00
robin 2b7e4575f7 Fix output of form
Let showForm() add the form to the output instead of execute(), because showForm() is also called in doSubmit() when there is an error, in which case it didn't actually show the form, so now it does. This was in fact a regression of r92636.

Change-Id: Ib6f0df50ce8e0c45e32817c70e4e1bc649cdf177
2012-05-26 01:56:05 +02:00
Reedy 1935444338 Add/update parameter docs
Remove unused array key

Return a string instead of ''

Change-Id: I17776667240b3a2f1a2dd2defb56ad24ec88f49c
2012-05-22 18:59:27 +01:00
Siebrand Mazeland c67fe8aff9 Make legend table collapsed.
Change-Id: Ic545b20a51e2a039225e99ea178c099ab2db012b
2012-05-21 17:54:26 +02:00
Siebrand Mazeland fb086e7c22 Fix bug in I688a51b3.
Change-Id: Id2a55721594d8de5045dd224837fdf9cafa1fdbf
2012-05-21 13:24:59 +02:00
Siebrand Mazeland a633ab1122 Green background for cells with "yes".
Comments added and updated.

Change-Id: I688a51b3b4a242d767a3ac8f81a6d3dddf0eaf49
2012-05-21 13:19:59 +02:00
Amir E. Aharoni 5f632390a8 (bug 36900) Message functions fixing
* Improving comments.
* Improving message escaping.

Change-Id: Iacda23bb46569022f317474e7fa8cfddd8d2da8c
2012-05-21 00:44:27 +03:00
Amir E. Aharoni e7a62478da (bug 36900) Partial cleanup
This commit includes simple minor cleanups for Bug 36900 and a few
other issues that I found.

A fix for the message escaping will be committed separately.

* Little punctuation cleanup in English messages.
* Minor CSS cleanup for RTL.
* Changed == to ===.
* Adding .gitignore.

Change-Id: I9d1be93b10173caa54ae56fb1b0733533a3687e2
2012-05-18 13:10:05 +03:00
Niklas Laxström 1789144003 Whitespace fix
Change-Id: Ic76a6afa50720485f4229581a98a536ed313ba14
2012-05-16 09:43:25 +00:00
csteipp 377a2ba09c (bug 30598) Escape html when displaying url in Log
Add htmlspecialchars escaping to the Interwiki url when displaying in the
logs. Fixes a potential xss.

Change-Id: I3cdf8a4f6c1b1f66a4229c8d9d00c1fc12506dd6
2012-05-02 09:42:37 -07:00
Siebrand Mazeland 0f2b905f6f Move 'interwiki_intro_footer' into "canModify" condition reducing information volume. 2012-04-25 10:31:31 +00:00
Siebrand Mazeland d3d033a361 Use local context to get messages. 2012-04-25 10:08:42 +00:00
Siebrand Mazeland 40a15e578c Coding style and whitespace updates. 2012-04-25 10:02:50 +00:00
Siebrand Mazeland 2bee90d311 Whitespace updates. 2012-04-25 08:53:49 +00:00
Platonides ec8665002a Purge the cached value from memcached.
This fixes issues such as the one reported in 
 http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/60769
That thread is about negative results (added in r98109),
but the memcached caching layer had been there since the 
conception of interwiki table in r1589 (3002e1d).
2012-04-15 20:00:42 +00:00
Robin Pepermans 914dca1d1c fix copy-paste error in r92529 (oops) 2011-12-10 12:54:44 +00:00
Robin Pepermans b81a0b4240 (bug 32075) Always add lowercase interwikis. Patch by Vitaliy Filippov. 2011-12-01 20:23:04 +00:00