Commit graph

27 commits

Author SHA1 Message Date
Sam Reed 71e04c06a0 Another big cull on unused variables and such 2010-10-29 21:55:29 +00:00
Sam Reed 0200023513 More deprecated method call removals and updates 2010-10-29 15:32:44 +00:00
Sam Reed fbe7fb6395 Start removing/fixing calls to deprecated methods in WMF used extensions 2010-10-29 15:14:44 +00:00
Aryeh Gregor a1c4503226 Remove most named character references from output
Recommit of r66254 to trunk.  This was just

find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives.  The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html>.
I cleared it with Tim and Brion on IRC before committing.  It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files.  I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

This should get rid of all named entities everywhere except messages.  I
skipped a few things like &nbsp that I noticed in manual inspection,
because they weren't well-formed XML anyway.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you.  Die.
2010-05-30 17:33:59 +00:00
Chad Horohoe 8f51920bac Revert r66934 (Removing wfLoadExtensionMessages() from everything). I disagree on principle...we branch extensions for this very reason. But people want trunk extensions compatible for several versions back, meh. 2010-05-27 15:56:53 +00:00
Chad Horohoe 7d30faca78 Large commit. Removed 800+ references to no-op wfLoadExtensionMessages() 2010-05-26 22:25:32 +00:00
Tobias 77107c56a7 Adding nosummary as option for newsection-comment 2010-03-31 12:33:11 +00:00
Tim Starling 6bdcff7eaf Validate background colour to avoid arbitrary style attribute injection. Leads to XSS in versions of IE that support dynamic properties (IE<8, and IE 8 in quirks mode). 2010-03-30 03:59:15 +00:00
Happy-melon c30239bf87 (bug 6640) add a prefix= parameter to creation inputboxes; using a intercept/munge/redirect method stolen from Wikia. 2010-03-18 19:11:12 +00:00
Chad Horohoe f48730b7fd (bug 11777) Multiple inputboxes make page invalid due to repetitive similar id. Let users specify an ID like we do for the search box, otherwise omit it entirely 2009-12-15 11:23:43 +00:00
Aaron Schulz 6bd9e5192e (bug 17161) Make 'enter' work right on IE for fulltext type 2009-02-26 20:15:49 +00:00
X! 967e55e56c (bug 17002) Add minor and summary parameters to InputBox 2009-01-13 02:18:30 +00:00
Raimond Spekking 2ad7747074 Add a space between input field and button. Looks smarter :) 2009-01-01 13:29:46 +00:00
Robert Stojnić ecbb8ed97c (bug 5552) add a fulltext-only search mode to inputbox
Reuse getSearchForm() for both 'search' and 'fulltext' type, IMO it should also be used for 'search2' (exact-match only), but since 'search2' is kindof strange and ignores some params (like 'break') for which I'm not sure if it's bug or feature, leaving 'search2' as separate function.
2009-01-01 00:55:18 +00:00
Brion Vibber 424e0fecf6 Revert r45213 "(bug 5552) add a fulltext-only search mode to inputbox"
"hidego" sounds kind of icky to me; perhaps type="fulltext" would be better?
2008-12-31 22:18:32 +00:00
Robert Stojnić 161f75f454 Send 'prefix' GET param if one is defined in the inputbox. This will be handled by Special:Search 2008-12-31 03:31:41 +00:00
Robert Stojnić ff6f2e6407 (bug 5552) add a fulltext-only search mode to inputbox 2008-12-31 02:53:33 +00:00
Aryeh Gregor 6ca784f7f3 Improve ugly interface for Sanitizer::escapeId()
Calling it with no extra arguments will now assume that you're escaping
a whole id, not an id fragment, which is safer.  Also, instead of ugly
bitfield-based options, I've changed the options to use an array of
strings.  I fixed all callers in trunk.  Out-of-tree callers that were
using Sanitizer::NONE will get correct behavior, while those that were
calling it with no arguments will get slightly changed behavior (an x
will be prepended).  I think this is harmless enough that we can skip
back-compat cruft here.

This should cause no visible changes.  No parser test regressions.
2008-12-30 00:22:14 +00:00
Alex Z. 7f746a908a Fix parsing of labeltext on the "search2" form, make sure labels are correctly associated with an input. 2008-11-29 04:07:46 +00:00
X! 80c1798b7b Add hidden parameter 2008-11-17 21:54:38 +00:00
Aaron Schulz 7563919a8f Cleanup for r42696: use class defaults 2008-11-13 08:50:13 +00:00
Alex Z. 7a6e480645 *Fix some variable typos
*Use <label>s with the search namespace checkboxes
*Remove extra htmlspecialchars(), XML::element() does this for us.
2008-10-28 01:56:15 +00:00
X! 49729f5d46 (bug 13262) Add preloadtitle option to InputBox, allowing users to specify the title of the sectionin the text field. 2008-10-28 00:08:08 +00:00
Trevor Parscal 97020945cb Added default values for parameters. 2008-10-27 22:52:05 +00:00
Trevor Parscal fe52f15a5b Changed member names to match naming conventions. 2008-10-27 21:35:00 +00:00
Siebrand Mazeland ad5afe34a7 Maintenance updates:
* remove trailing whitespace
* update indentation
* stylize.php
* eol-style:native svn props
2008-10-27 20:56:23 +00:00
Trevor Parscal c3c2456b06 2008-10-27 20:33:18 +00:00