wikimedia/mediawiki-extensions-InputBox
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/InputBox synced 2024-11-23 14:46:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Display namespace name instead of its ID in checkboxes' labels"

Browse source
This commit is contained in:
jenkins-bot 2024-05-05 20:59:36 +00:00 committed by Gerrit Code Review
parent bcdc4375e1 dc5c785212
commit cb20941335
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/InputBox.php
View file

@ -292,7 +292,7 @@ class InputBox {
} else {
// Checkbox
$htmlOut .= $this->buildCheckboxInput(
'ns' . $i, 'mw-inputbox-ns' . $i . $idRandStr, "1", $checked
$name, 'ns' . $i, 'mw-inputbox-ns' . $i . $idRandStr, "1", $checked
);
}
}
@ -762,13 +762,14 @@ REGEX;
/**
* Factory method to help build checkbox input.
*
* @param string $label text displayed next to checkbox (label)
* @param string $name name of input
* @param string $id id of input
* @param string $value value of input
* @param array $defaultAttr (optional)
* @return string
*/
private function buildCheckboxInput( $name, $id, $value, $defaultAttr = [] ) {
private function buildCheckboxInput( $label, $name, $id, $value, $defaultAttr = [] ) {
$htmlOut = ' <div class="mw-inputbox-element mw-ui-checkbox">';
$htmlOut .= Xml::element( 'input',
[
@ -779,7 +780,7 @@ REGEX;
] + $defaultAttr
);
// Label
$htmlOut .= Xml::label( $name, $id );
$htmlOut .= Xml::label( $label, $id );
$htmlOut .= '</div> ';
return $htmlOut;
}