From 4fb8d2d05009476f63a8a686f51a4b51ba3ed5fb Mon Sep 17 00:00:00 2001 From: Jon Robson Date: Thu, 11 Jul 2024 15:13:37 -0700 Subject: [PATCH] InputBox should not trigger lint warnings Bug: T369619 Change-Id: I0af233bfb49dd1da9eeee8cc324e91e24200bff5 --- includes/InputBox.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/InputBox.php b/includes/InputBox.php index f9b2b6e3..bae0db88 100644 --- a/includes/InputBox.php +++ b/includes/InputBox.php @@ -821,7 +821,11 @@ REGEX; private function bgColorStyle() { if ( $this->mBGColor !== 'transparent' ) { - return 'background-color: ' . $this->mBGColor . ';'; + // Define color to avoid flagging linting warnings. + // https://phabricator.wikimedia.org/T369619 + // Editor is assumed to know what they are doing here, + // and choosing a color compatible with dark and light themes... + return 'background-color: ' . $this->mBGColor . '; color: inherit;'; } return ''; }