wikimedia/mediawiki-extensions-InputBox
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/InputBox synced 2024-11-24 15:13:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix capitalization and tests of $this->mId.

Browse source 
Property name is $mID, certain parts were testing $mId, and then
using isset to (presumably) hide the undefined property warnings.

Change-Id: I0c2d29fbdb8314aa0c04bea387364a7307e68b9b
This commit is contained in:
Brian Wolff 2014-04-05 20:55:09 -03:00
parent f14419180a
commit 048a97e560
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
InputBox.classes.php
View file

@ -331,8 +331,8 @@ class InputBox {
'action' => $wgScript, 'action' => $wgScript,
'method' => 'get' 'method' => 'get'
); );
if( isset( $this->mId ) ) { if( $this->mID !== '' ) {
$createBoxParams['id'] = Sanitizer::escapeId( $this->mId ); $createBoxParams['id'] = Sanitizer::escapeId( $this->mID );
} }
$htmlOut .= Xml::openElement( 'form', $createBoxParams ); $htmlOut .= Xml::openElement( 'form', $createBoxParams );
$htmlOut .= Xml::openElement( 'input', $htmlOut .= Xml::openElement( 'input',
@ -441,8 +441,8 @@ class InputBox {
'action' => $wgScript, 'action' => $wgScript,
'method' => 'get' 'method' => 'get'
); );
if( isset( $this->mId ) ) { if( $this->mID !== '' ) {
$commentFormParams['id'] = Sanitizer::escapeId( $this->mId ); $commentFormParams['id'] = Sanitizer::escapeId( $this->mID );
} }
$htmlOut .= Xml::openElement( 'form', $commentFormParams ); $htmlOut .= Xml::openElement( 'form', $commentFormParams );
$htmlOut .= Xml::openElement( 'input', $htmlOut .= Xml::openElement( 'input',