mediawiki-extensions-InputBox/.eslintrc.json

{
	"root": true,
	"extends": [
		"wikimedia",
		"wikimedia/mediawiki"
	],
	"env": {
		"browser": true
	},
	"globals": {
		"mw": false,
		"$": false
	}
}
Switch from jshint to eslint Change-Id: I4401103dce2ee1558365f46b62a86689521c58a9 2018-08-28 18:58:49 +00:00			`{`
build: Set "root": true, in .eslintrc.json This ensures that each repository's "npm test" command is fully independent of wherever it might be in the filesystem. Bug: T206485 Change-Id: I7ec8bcdbd17475857bc24e6181453d2ddaf6bd8f 2018-12-18 02:55:53 +00:00			`"root": true,`
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate * MediaWiki.Commenting.PropertyDocumentation.WrongStyle Additional changes: * Dropped .inc files from .phpcs.xml (T200956). * Added the `wikimedia/mediawiki` profile in .eslintrc.json (T262222). Change-Id: Ic7e903cc97b3766fcff467b382caf2a5a6bc5089 2020-11-04 02:06:20 +00:00			`"extends": [`
			`"wikimedia",`
			`"wikimedia/mediawiki"`
			`],`
Switch from jshint to eslint Change-Id: I4401103dce2ee1558365f46b62a86689521c58a9 2018-08-28 18:58:49 +00:00			`"env": {`
Use native <input required> instead of JS-based disabled toggling Remove the JavaScript module and its logic to toggle the disabled state on the submit button. Instead, let the browser handle this natively by setting the `required` attribute, which naturally prevents early submissions. Retain the current styling for 99% of cases by using the :required:invalid selector to target the submit button to make it appear disabled. This slight duplication of styles is needed because, despite the form effectively being disabled natively, the core mediawiki-ui styles only account for :disabled on the button directly and not e.g. inherited via form:invalid. It is also unclear whether we would want that, since there is some value to be had from having the form give a consistent look with a progressive button that can be submitted even at the wrong time to yield an assistive message to the required field, so hence handling this locally for now instead of with a generalised approach. In order to use the required true/false idiom, I have switched the generating of the HTML string from the old Xml::element method to Html::element. This means there is no need to store it in an array first and conditionally set it since true/false will result in absence or required="" as needed. As side-effect from this, redundant attributes like value="" and type="text" are ommitted from the output, just as MediaWiki core does more generally. Bug: T283303 Change-Id: I2c75e09dd3f89fa11fca311b4e1f8133946b01b1 2021-05-21 02:03:06 +00:00			`"browser": true`
Switch from jshint to eslint Change-Id: I4401103dce2ee1558365f46b62a86689521c58a9 2018-08-28 18:58:49 +00:00			`},`
			`"globals": {`
Use native <input required> instead of JS-based disabled toggling Remove the JavaScript module and its logic to toggle the disabled state on the submit button. Instead, let the browser handle this natively by setting the `required` attribute, which naturally prevents early submissions. Retain the current styling for 99% of cases by using the :required:invalid selector to target the submit button to make it appear disabled. This slight duplication of styles is needed because, despite the form effectively being disabled natively, the core mediawiki-ui styles only account for :disabled on the button directly and not e.g. inherited via form:invalid. It is also unclear whether we would want that, since there is some value to be had from having the form give a consistent look with a progressive button that can be submitted even at the wrong time to yield an assistive message to the required field, so hence handling this locally for now instead of with a generalised approach. In order to use the required true/false idiom, I have switched the generating of the HTML string from the old Xml::element method to Html::element. This means there is no need to store it in an array first and conditionally set it since true/false will result in absence or required="" as needed. As side-effect from this, redundant attributes like value="" and type="text" are ommitted from the output, just as MediaWiki core does more generally. Bug: T283303 Change-Id: I2c75e09dd3f89fa11fca311b4e1f8133946b01b1 2021-05-21 02:03:06 +00:00			`"mw": false,`
			`"$": false`
Switch from jshint to eslint Change-Id: I4401103dce2ee1558365f46b62a86689521c58a9 2018-08-28 18:58:49 +00:00			`}`
			`}`