Thiemo Kreuz
826f5f6ffb
Modernize ImageMap implementation a bit
...
Notable:
* Use strict === for string comparisons.
* Use ?? instead of isset(), where it makes sense.
* Avoid expensive recursiveTagParse() with empty strings.
* Add strict Parser type hint. Note this would have failed anyway
because the code below just assumes this is a Parser.
* Use the actual $lineNum from the loop instead of manually counting.
Note the loop is 0-based, while $lineNum is meant to be 1-based.
Therefor the ++.
Change-Id: I907b6c9ce3eef404dc7f048c14c4707dd1d0d98a
2020-05-20 08:48:52 +02:00
Thiemo Kreuz
da2838adfc
Remove unused $id property
...
Unused since Ia906b46 (March 2019, not linked to a Phabricator
ticket).
Change-Id: Ie57b9da09a840eacac3eff2f7794fa9e352f28da
2020-05-20 08:32:04 +02:00
DannyS712
c765a86777
Fix PSR12.Properties.ConstantVisibility.NotFound
...
Bug: T253169
Change-Id: I44a288dc7f754af13991f949cfc180c19da782ec
2020-05-19 23:21:15 +00:00
Reedy
74bcec0dd7
Convert to manifest_version 2
...
Bug: T252470
Change-Id: Iac1afb426fcc662fa9f2edd4c960878869f202ea
2020-05-12 00:02:53 +01:00
libraryupgrader
7c250466b4
build: Updating dependencies
...
composer:
* mediawiki/mediawiki-codesniffer: 29.0.0 → 30.0.0
npm:
* eslint-config-wikimedia: 0.15.0 → 0.15.3
Change-Id: I790addf985be19421aa4b67e878f5e8ebf59db29
2020-04-22 12:35:59 +00:00
Translation updater bot
58b7383d63
Localisation updates from https://translatewiki.net .
...
Change-Id: I9b82d7780561ab5d317c27a16113b89b3d865d0d
2020-04-20 08:41:50 +02:00
jenkins-bot
7962306684
Merge "Namespace extension"
2020-04-20 02:07:31 +00:00
libraryupgrader
739f94f34f
build: Updating grunt-banana-checker to 0.9.0
...
Change-Id: I6d8254aea70b7d45506e83075b12b50a3cc712d3
2020-04-19 08:52:46 +00:00
Reedy
9e45ad3f6f
Namespace extension
...
Change-Id: Ifbbb52819789bf5ad3e35dd56f6e1f48f1d85aba
2020-04-19 01:18:57 +00:00
Translation updater bot
6d401c4c2f
Localisation updates from https://translatewiki.net .
...
Change-Id: Icb53ed5b3dcdc246e4b8426deffc38a12dabd78f
2020-04-07 08:42:39 +02:00
jenkins-bot
25bc9d8700
Merge "Fix imagemap_invalid_coord message"
2020-04-06 19:01:19 +00:00
Arlo Breault
edb47bb2d4
Fix imagemap_invalid_coord message
...
Looks like this was introduced in 28bb0b5
Change-Id: Ic51accc74006fe64df80bb2ff58e4fd7b0274936
2020-04-06 12:29:06 -04:00
Translation updater bot
48342f8ad3
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie8ac6ce6f53249f0464c8c6ab6727e8f6f4831d6
2020-04-06 09:02:08 +02:00
C. Scott Ananian
86e2a3a971
Update parserTests to v2 (tidy by default)
...
Mostly cleaning up close tags for empty elements.
Bug: T249136
Change-Id: Ifb13838c32748b1d52612da0cdb0e0a44c6e0689
2020-04-01 20:09:52 +00:00
C. Scott Ananian
6b4e6becb5
Use Parser::getTitle(), not @internal $parser->mTitle field
...
Change-Id: I45b9f4a22e89ee7729ecf51f2cd452556f629205
2020-03-30 13:14:12 -04:00
Translation updater bot
1d94b8679b
Localisation updates from https://translatewiki.net .
...
Change-Id: I05ca1a8c4fb1152be87e899a6b92c6f122f5572b
2020-03-23 09:03:26 +01:00
libraryupgrader
05c4d0829f
build: Updating mkdirp to 0.5.3
...
* https://npmjs.com/advisories/1179
Change-Id: I6f32c3493e2718ed8f55caf72ab5c16fd7e9aff7
2020-03-21 01:42:30 +00:00
libraryupgrader
23d87e0733
build: Updating minimist to 1.2.5
...
* https://npmjs.com/advisories/1179
Change-Id: I522fca8c38d060c5cc11f47405ca2b7340eba3fa
2020-03-18 15:02:16 +00:00
Umherirrender
313fba8175
Use MediaWikiServices::getBadFileLookup
...
This required MediaWiki 1.34 (already set in extension.json)
Change-Id: I6a7e51fed5718c33de67a530ce032f8725e0bfcc
2020-03-14 21:14:32 +01:00
Umherirrender
c6a8e7fefe
Use MediaWikiServices::getRepoGroup
...
This required MediaWiki 1.34
Change-Id: I4c0887e2d9fc8882805292d7ea5dbc0a68ce34a8
2020-03-14 14:36:27 +01:00
Translation updater bot
0ede99be53
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib7c2c9cc864b170cfe6f5683ae18bd2cb0702468
2020-03-12 08:42:52 +01:00
DannyS712
b37c0818f9
extension.json - don't use array syntax when hooks only have 1 handler
...
Change-Id: I0a5ccdd509da237de95772514acd0ac56566499f
2020-03-11 09:40:30 +00:00
libraryupgrader
65151430ef
build: Updating acorn to 7.1.1
...
* https://npmjs.com/advisories/1488
Change-Id: I778336a3a2baf6cbbf1ff14786ce123ae2c5254c
2020-03-08 07:27:31 +00:00
jenkins-bot
e4cb912940
Merge "build: Updating composer dependencies"
2020-02-19 19:41:31 +00:00
libraryupgrader
a2b3060bce
build: Updating composer dependencies
...
* jakub-onderka/php-console-highlighter: 0.3.2 → 0.4.0
* mediawiki/minus-x: 0.3.2 → 1.0.0
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.2
Change-Id: I8141f11390205d00a11b819de03e796e08cc8f88
2020-02-19 19:21:15 +00:00
Translation updater bot
b1c5f2df96
Localisation updates from https://translatewiki.net .
...
Change-Id: I86660cf08dac6cb610c01d69a57be38169b9e6ae
2020-02-19 08:24:43 +01:00
Translation updater bot
3b1485b2c3
Localisation updates from https://translatewiki.net .
...
Change-Id: Icef69aaf13ddfd113842786319fa667fd4da4b40
2020-02-17 08:46:39 +01:00
libraryupgrader
4fb2612a0c
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
...
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.
Change-Id: Ibf8a07b82fd03c38f1a07eef445c751c8a7a273b
2020-01-14 05:57:36 +00:00
libraryupgrader
bebe23cf97
build: Updating npm dependencies
...
* grunt-eslint: 21.0.0 → 22.0.0
* eslint-config-wikimedia: 0.12.0 → 0.15.0
Additional changes:
* Removing manual reportUnusedDisableDirectives for eslint.
Change-Id: I78ad86df1fff32fd401be82e76e99c0659c24c5a
2020-01-09 15:09:19 +00:00
libraryupgrader
bbe82f0371
build: Updating mediawiki/mediawiki-phan-config to 0.9.0
...
Additional changes:
* Added .eslintcache to .gitignore.
Change-Id: I9e04f1ed8c96fcd92d8232f39b169ae3d0dff029
2019-12-27 19:03:37 +00:00
libraryupgrader
9dda262ee3
build: Updating dependencies
...
composer:
* mediawiki/minus-x: 0.3.1 → 0.3.2
npm:
* grunt-banana-checker: 0.6.0 → 0.8.1
Additional changes:
* Added .eslintcache to .gitignore.
Change-Id: I8597785a0f704e4b8267e866ade859f6b2406e71
2019-12-17 00:26:55 +00:00
Max Semenik
f5427d519d
Stop passing objects by reference
...
Bug: T193950
Change-Id: Iefb9848806d5e73fdebe0e31d16b362e101347a1
2019-11-14 23:42:52 -08:00
Umherirrender
ec67a99636
build: Updating mediawiki/mediawiki-phan-config to 0.8.0
...
Bug: T235049
Change-Id: Ia78ec291259d77a75aeed4af3982ddbe0d1e34dc
2019-11-03 18:36:48 +01:00
Translation updater bot
7364545e3d
Localisation updates from https://translatewiki.net .
...
Change-Id: I6cc7bab4cb2f78aa2343ec16add1467b2a1f73e5
2019-10-16 20:39:43 +02:00
Ed Sanders
28bb0b502f
Rewrite tokenizeCoords to use a while loop, and use it for 'poly'
...
This provides consistent token validation for
'poly', 'rect' & 'circle'.
Change-Id: I2f558b57dbd93b3bf8ed1762d10ba94772f48a15
2019-10-11 21:00:23 +00:00
James D. Forrester
c67a1f30c6
build: Upgrade mediawiki-codesniffer to v28.0.0
...
Change-Id: Ibfa7685b068d02309c1eac7e00b3b347e11550a8
2019-10-11 10:21:44 -07:00
Ed Sanders
b024fddb4d
Make mapName deterministic so it can be tested
...
Change-Id: Ia906b46fbe8d84ae1482f8efaeb609d08c53bfa8
2019-08-30 17:43:37 +01:00
libraryupgrader
d7f715635e
build: Updating eslint-utils to 1.4.2
...
* https://npmjs.com/advisories/1118
Additional changes:
* Added .eslintcache to .gitignore.
Change-Id: Iedd885fbd677668adf0e9cfa71bc284c53dd22a4
2019-08-24 09:52:13 +00:00
libraryupgrader
e02f538987
build: Updating mediawiki/mediawiki-codesniffer to 26.0.0
...
Additional changes:
* Committed package-lock.json (T179229) too.
Change-Id: Ie0e761bedc2d7c33d1bce9be0be763514e3805fc
2019-07-14 12:25:21 +00:00
James D. Forrester
bdaa94075d
build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
...
Change-Id: I9f24f657b830d5cd6552198c6760e82793e690fb
2019-07-09 14:07:44 -07:00
libraryupgrader
772bb0fa4a
build: Updating mediawiki/mediawiki-phan-config to 0.6.1
...
Change-Id: I7586acd1b80ea1278ef5f4f0bb6c56a8c6f09e1b
2019-06-10 08:25:18 +00:00
Reedy
23d34a68ad
Remove PHP entry point
...
Bug: T140007
Change-Id: I47cebade3de70a94d291285c94dbefec01e9ce59
2019-06-06 15:09:20 +01:00
James D. Forrester
8d795f2e00
build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
...
Change-Id: Id1a8797f07f4c401c8db3b83c73f8e8bd2cc6ee9
2019-05-19 13:20:12 +02:00
James D. Forrester
fd9ffc3341
build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
...
Change-Id: I0cd5446441358c52844ce556cbdad00520c173fa
2019-05-06 16:19:30 -07:00
James D. Forrester
164bb62246
build: Install eslint
...
Change-Id: I3d2aed1e6cd8935e151e0ae2175b1283b4a408b0
2019-05-06 16:18:51 -07:00
Alex Ezell
9f962fbad1
Allow negative coordinates in poly image maps
...
Previous attempts to clean this up followed similar logic to the
circle and rect types of imagemaps. However, in reality, we have
many image maps in our content that have negative values for poly
coordinates. While this isn't logical, breaking them so loudly
in the page isn't desirable.
This change then removes the check for positive value and passes
along the negative coordinate.
Bug: T217087
Change-Id: I0ee84f059dacde79a7e4fb0a172ac6937360d864
2019-04-11 09:23:14 -04:00
Translation updater bot
223b87c5c4
Localisation updates from https://translatewiki.net .
...
Change-Id: Ief2de4aa5c24d361cf284345470c3fe78c765c7a
2019-04-10 09:23:08 +02:00
Ed Sanders
fb20685b48
Use is_numeric instead of ctype_digit for 'poly' validation
...
Duplicates the logic from tokenizeCoords which is used by
'rect' & 'circle'.
Bug: T217087
Change-Id: I7c59bb9ea410bae8800922356829bca669d2e69c
2019-03-31 00:21:43 +00:00
Alex Ezell
70a6b723c7
Warn user about invalid coordinates
...
If a user provides a non-numeric coordinate in an image map, it
results in an unhandled exception. This change detects the incorrect
coordinate and warns the user with an error message.
This also cleans up a type casting that was old fashioned.
Bug: T217087
Change-Id: Ic1254dd0fe41d0499f71140466277fb58d1d194c
2019-03-22 15:20:22 -04:00
Arlo Breault
f2c607e101
Update tests to match parser changes
...
Bug: T208070
Depends-On: I3da235cb83efa424f0cf1cf4fc7233240fcdf6b2
Change-Id: Ie70e1915c172d2d67b3b8b90eb35f753b800f61e
2019-03-15 18:24:51 +00:00