Commit graph

782 commits

Author SHA1 Message Date
James D. Forrester 164bb62246 build: Install eslint
Change-Id: I3d2aed1e6cd8935e151e0ae2175b1283b4a408b0
2019-05-06 16:18:51 -07:00
Alex Ezell 9f962fbad1 Allow negative coordinates in poly image maps
Previous attempts to clean this up followed similar logic to the
circle and rect types of imagemaps. However, in reality, we have
many image maps in our content that have negative values for poly
coordinates. While this isn't logical, breaking them so loudly
in the page isn't desirable.

This change then removes the check for positive value and passes
along the negative coordinate.

Bug: T217087
Change-Id: I0ee84f059dacde79a7e4fb0a172ac6937360d864
2019-04-11 09:23:14 -04:00
Translation updater bot 223b87c5c4 Localisation updates from https://translatewiki.net.
Change-Id: Ief2de4aa5c24d361cf284345470c3fe78c765c7a
2019-04-10 09:23:08 +02:00
Ed Sanders fb20685b48 Use is_numeric instead of ctype_digit for 'poly' validation
Duplicates the logic from tokenizeCoords which is used by
'rect' & 'circle'.

Bug: T217087
Change-Id: I7c59bb9ea410bae8800922356829bca669d2e69c
2019-03-31 00:21:43 +00:00
Alex Ezell 70a6b723c7 Warn user about invalid coordinates
If a user provides a non-numeric coordinate in an image map, it
results in an unhandled exception. This change detects the incorrect
coordinate and warns the user with an error message.

This also cleans up a type casting that was old fashioned.

Bug: T217087
Change-Id: Ic1254dd0fe41d0499f71140466277fb58d1d194c
2019-03-22 15:20:22 -04:00
Arlo Breault f2c607e101 Update tests to match parser changes
Bug: T208070
Depends-On: I3da235cb83efa424f0cf1cf4fc7233240fcdf6b2
Change-Id: Ie70e1915c172d2d67b3b8b90eb35f753b800f61e
2019-03-15 18:24:51 +00:00
zoranzoki21 eadde54449 Upgrade ImageMap extension to use newer phan
Bug: T216921
Change-Id: I6bb5c8e855a191cae7bddbf8a5f23da5c033045f
2019-03-11 19:46:47 +00:00
Umherirrender c0eb4fdb18 Declare local vars set on first run of foreach
PhanUndeclaredVariable is reported, because the vars are not declared
outside of the loop and only conditional inside the loop.
The condition is run on first loop, so it is always run and the old code
works.
Declare the vars to make them visible before the loop

Change-Id: Ic33170fcb0e5b7e02b7269c83f27120989a6ca10
2019-03-11 20:15:07 +01:00
zoranzoki21 b0b5b63fd9 Move images in resources directory
Change-Id: Id76a292e75c1ef82410439235b6d25eb0cff4284
2019-03-02 22:06:50 +01:00
Translation updater bot a6a561d72d Localisation updates from https://translatewiki.net.
Change-Id: I14a272e285a751dae6c83b846bd81104505a9aa5
2019-02-28 22:24:59 +01:00
Reedy f0355fab4c Update MediaWiki namespaced AtEase global functions
Change-Id: Ic1342ad266084bd1ad6ae89e31020afef825870d
2019-02-13 05:29:51 +00:00
libraryupgrader 2fca9d627a build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: Ic2cfc48df23ef445cf9cfea2941a0d1039e6c9a0
2019-02-06 17:47:03 +00:00
Thiemo Kreuz 0c36a0b9a7 Fix parser test by adding decoding="async" parameter
As far as I can see this was introduced via I3d738eb in December 2018,
but never applied to this codebase.

Bug: T212124
Change-Id: I5d986b23fdd52ebc207405f8d7dfcdc208e55f3f
2019-01-15 15:45:31 +01:00
Translation updater bot 6bb802c59b Localisation updates from https://translatewiki.net.
Change-Id: I609bcec363c5864ff09c9127f6d1185ee09cb5e2
2019-01-08 22:29:47 +01:00
libraryupgrader 4e96c0f046 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: Iab80ecfc6f5ad79d0368f82cc393d3e751bef542
2018-11-16 02:57:41 +00:00
Umherirrender b9f43bd8f1 Add method scope visibility
Change-Id: I5ac480fe2af502645d539e0e05b6872d3854168a
2018-10-31 23:37:19 +01:00
Kunal Mehta 02770ad7ec Warn if legacy PHP entry point is used
Bug: T140851
Change-Id: Iee67d0da5534e7941c0041e30ce2e1526e40ace9
2018-10-16 11:29:57 -07:00
libraryupgrader 564d053485 build: Updating npm dependencies for security issues
* Updated grunt to 1.0.3, addressing:
  * https://npmjs.com/advisories/577
  * CVE-2018-3721

Change-Id: I0b59b1b84e369cac6c2df1887346dc80a414517c
2018-10-11 08:12:15 +00:00
Translation updater bot ee33e8e42e Localisation updates from https://translatewiki.net.
Change-Id: I7b3a42a7228a62ddc3441efbf05aef5135e6dcd7
2018-09-22 10:03:37 +02:00
libraryupgrader 772891c1de build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: Ic32179cb3980c9cb881d7cbaf09c41aa22ab5bcf
2018-09-08 02:19:29 +00:00
libraryupgrader af5f17d58a build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: Iedd6c22f03504f6f0a2e223f58ee480116e5e29d
2018-09-03 04:04:51 +00:00
libraryupgrader bc921a3a95 build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I02fdbab33644be8f18d649ecc8970e9875f3787b
2018-09-01 09:54:22 +00:00
libraryupgrader 4cc60e3543 build: Updating mediawiki/phan-taint-check-plugin to 1.3.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: I9a1e9a4916c28c9d6da91e328938120d5df5bc84
2018-08-19 13:29:02 +00:00
Translation updater bot 4c440a6e14 Localisation updates from https://translatewiki.net.
Change-Id: I894081846dfc69108182b1266494014d202bb0a9
2018-08-09 22:23:50 +02:00
libraryupgrader d0e0ba4fbd build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
Change-Id: I8bff1d64b29d76cea2075115d711ee5071fc5cb0
2018-07-27 07:20:29 +00:00
libraryupgrader c6ebc2961e build: Updating mediawiki/mediawiki-phan-config to 0.3.0
Change-Id: Idead032f5e0860c8d1679f0456ed9c6b559e2d3e
2018-06-08 07:14:09 +00:00
libraryupgrader 19a1919d1c build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Ie5d7d5b195950f694857635fbb643b2b29cd1662
2018-05-26 03:46:22 +00:00
Brian Wolff 08909bdffa Bump phan-taint-check 1.1.0->1.2.0
Bug: T193909
Change-Id: I1bf4d64e68bff516b5f8b6266d85f670200084df
2018-05-04 20:39:19 +00:00
libraryupgrader f559507ad6 build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
Change-Id: I90472946e519962ce6a61d20d3fafa1fb1aa3e2a
2018-04-14 02:53:41 +00:00
Jayprakash12345 a6cb086374 Update extensions to take advantage of parser test autodiscovery
Bug: T170037
Change-Id: I8eae59053930f7621c812c754d5f4fa5314087e1
2018-04-13 15:23:25 +00:00
Kunal Mehta 91b148624e build: Updating mediawiki/mediawiki-phan-config to 0.2.0
Change-Id: Ic5d7e1bc992a5954c5d7c938fae2066ac078068c
2018-04-05 13:27:40 -07:00
libraryupgrader dc24bcea71 build: Updating mediawiki/mediawiki-codesniffer to 17.0.0
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment

Change-Id: Ie537d9ad3f322e685a5609dd5e54a1cccdb72edb
2018-03-29 03:00:53 +00:00
Translation updater bot db29b8adca Localisation updates from https://translatewiki.net.
Change-Id: I12e7860e8dec49931946d84c9a490c80e7bd0879
2018-03-12 22:25:08 +01:00
libraryupgrader bc0cc30a91 build: Updating jakub-onderka/php-parallel-lint to 1.0.0
Change-Id: I47caf9cde98797c0705ca40a8c1f92e0c75635a8
2018-03-09 12:43:36 +00:00
libraryupgrader aa829b1441 build: Updating mediawiki/mediawiki-codesniffer to 16.0.1
Change-Id: I4aab9229dce7447cb0b9be0eb01292382e243617
2018-02-25 08:55:59 +00:00
Kunal Mehta e9208739b6 Add phan configuration
Change-Id: Ie8aee5326c4217e151dee816bc5a3d6b71bf6aa2
2018-02-24 13:33:36 -08:00
Kunal Mehta 3297749b56 Move classes into includes/
Change-Id: I390b0e09406e61c19e2e3eb9a115327cf013ad3a
2018-02-24 13:10:38 -08:00
Kunal Mehta e94bcd06f0 Don't autoload ImageMap class via composer
There's no need for this since the class is loaded via MediaWiki's
autoloader.

Change-Id: Ia790f4afef22bf3c5a0dbb0b34e33b65277efc15
2018-02-24 13:10:24 -08:00
James D. Forrester 9e5270df22 build: Bump devDependencies to latest
grunt                 1.0.1  →  1.0.2
 grunt-banana-checker  0.4.0  →  0.6.0
 grunt-jsonlint        1.0.7  →  1.1.0

Change-Id: If82d0109e77f4b49b8cb102e067233102f898504
2018-02-23 17:50:35 -08:00
Translation updater bot 6dacfc7787 Localisation updates from https://translatewiki.net.
Change-Id: Ib870a84ad39781292aed8533e73d61ed10bc46f5
2018-02-18 22:40:42 +01:00
libraryupgrader 849cbb2e2d build: Updating mediawiki/minus-x to 0.3.1
Change-Id: If7d4857d0e125bc0c5d3792bf4654ee7aa827b9f
2018-02-17 23:14:58 +00:00
Kunal Mehta 10a7e397a5 Set phan-taint-check-plugin version in composer.json
We cannot set this in the normal "require-dev" because the plugin
depends on exactly PHP 7.0, preventing running tests on any other PHP
version.

Instead, CI will read the version number out of the "extra" field to
figure out what version to install.

Bug: T187497
Change-Id: I5053e8059eb986d5be4b6cd0b0cc4488353d98c5
2018-02-16 13:40:52 -08:00
Brian Wolff b5a5613a3a Do not use raw html i18n messages for errors.
The i18n Error messages should be properly escaped. This is not an
XSS as the none of the parameters to the error message were user
controlled (outside of MW namespace)

This fixes the outstanding errors from phan-taint-check

Change-Id: I0b4d6b5eb3e210a131937e65268091ec83f0b434
2018-02-15 13:47:30 +00:00
libraryupgrader 613872b9ca build: Updating mediawiki/mediawiki-codesniffer to 16.0.0
Change-Id: If14cb5cc50601778b1dd859a43607345e3a08092
2018-02-15 11:58:49 +00:00
Kunal Mehta 8420a0ee09 Use SPDX 3.0 license identifier
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: I0b4d6b5eb3e210a131937e65268091ec83f0b46c
2018-01-31 23:12:14 -08:00
libraryupgrader 74ab34edcb build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing

Change-Id: Ib541fdecc690d18bb78cdfd255041988e4c94921
2017-12-30 00:55:18 +00:00
Translation updater bot 6ccee81f38 Localisation updates from https://translatewiki.net.
Change-Id: I3cecd48af9ee214655afb889cff99ae6c2dfebc9
2017-12-29 10:06:29 +01:00
Translation updater bot 9251dcb6bd Localisation updates from https://translatewiki.net.
Change-Id: I06dca910bd7932a6089de10345d195e93ec68e89
2017-12-23 22:26:58 +01:00
Translation updater bot 8fa1348f25 Localisation updates from https://translatewiki.net.
Change-Id: I7231332d6221de1def3ebe7adc92228714ee5a80
2017-12-18 23:06:33 +01:00
libraryupgrader ed6333dfd4 build: Updating mediawiki/minus-x to 0.2.1
Change-Id: If3d791528dc92bcc640c898df0a19177fd6d86c5
2017-12-10 22:30:47 +00:00