wikimedia/mediawiki-extensions-ImageMap

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ImageMap synced 2024-11-12 00:48:17 +00:00

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	c8c8b9c735	Avoid Phan PhanUndeclaredMethod false positives The insertBefore() and appendChild() methods return their first argument, but Phan only knows that they return a DOMNode, even though we passed in a DOMElement. Rearrange slightly to avoid this pattern. Change-Id: I04c58458e1ba0d728374ead756afb6facf970766	2022-11-25 18:37:02 +00:00
Bartosz Dziewoński	2cc6549898	Use Parsoid's HTML5-compliant helpers for HTML transformations Previously XML parsing and serialization was used, causing `<br>` to be disallowed and `<br />` to turn into `<br></br>`. Also update some uses of XPath to use querySelector() helper. Bug: T113791 Change-Id: Ic2069015b4cbb5d05a72eb383052319048111623	2022-11-25 17:05:24 +00:00
zoranzoki21	eadde54449	Upgrade ImageMap extension to use newer phan Bug: T216921 Change-Id: I6bb5c8e855a191cae7bddbf8a5f23da5c033045f	2019-03-11 19:46:47 +00:00

Author

SHA1

Message

Date

Bartosz Dziewoński

c8c8b9c735

Avoid Phan PhanUndeclaredMethod false positives

The insertBefore() and appendChild() methods return their first
argument, but Phan only knows that they return a DOMNode, even though
we passed in a DOMElement. Rearrange slightly to avoid this pattern.

Change-Id: I04c58458e1ba0d728374ead756afb6facf970766

2022-11-25 18:37:02 +00:00

Bartosz Dziewoński

2cc6549898

Use Parsoid's HTML5-compliant helpers for HTML transformations

Previously XML parsing and serialization was used, causing `<br>`
to be disallowed and `<br />` to turn into `<br></br>`.

Also update some uses of XPath to use querySelector() helper.

Bug: T113791
Change-Id: Ic2069015b4cbb5d05a72eb383052319048111623

2022-11-25 17:05:24 +00:00

zoranzoki21

eadde54449

Upgrade ImageMap extension to use newer phan

Bug: T216921
Change-Id: I6bb5c8e855a191cae7bddbf8a5f23da5c033045f

2019-03-11 19:46:47 +00:00

3 commits