Commit graph

49 commits

Author SHA1 Message Date
C. Scott Ananian 1e8aacfa27 Re-enable temporarily disabled data-mw-i18n tests
Depends-On: I84296d802382131b47fda097878df43e2f6f46ff
Depends-On: I4293e4003d2447a074a900905114d6d118d6276e
Change-Id: Iab7b89c83d0868f4dd52ae9b56aff4863d32dc09
2024-10-28 17:13:43 +00:00
C. Scott Ananian 37bbc1c96b Update data-mw-i18n tests and temporarily disable them
The useless `"params":null` parameter will be removed by
I84296d802382131b47fda097878df43e2f6f46ff.

Change-Id: I7168a46dbfdf7fbebd376aaac6da574291eb7a88
2024-06-15 11:11:31 -04:00
Subramanya Sastry 118a50dfc1 Update Parsoid test output to reflect changes in Parsoid
Depends-On: I2a61e78171bd892f1835acf585259ce11e68d81d
Change-Id: Ia1d1c9df80bd1374eb927cc7465e9dade13a725b
2024-06-07 17:58:27 -04:00
Arlo Breault 87bbbeeda0 Temporarily disable tests involving i18n output
Until I2c36b9ae9e13f7a21cec35a47404a62bff69090b makes it into vendor.

Change-Id: Ie586ab2cba0427a6e4ed71f2077fee9afd837947
2024-06-07 17:48:18 -04:00
Arlo Breault 0c88ab1abd Use Parsoid's extension API's getExternalLinkAttribs
Depends-On: I31a8c6a9bb2741899d5445c3457fd424e283397b
Change-Id: Iaf8531a37e8d9d3ce1bece9ab3086e5967dca08f
2024-03-04 18:00:04 -05:00
Arlo Breault 4d19d19f1d Fix matching external link rel
Introduced in I8d7bdf1bccc869b4dc17058a5822ef34968471e6

Change-Id: I52a8a993fbdd4058d40f4aeac3df37e90e686f3e
2024-02-15 21:24:59 -05:00
jenkins-bot 927a41a770 Merge "Temporarily disable tests involving data-mw-i18n output" 2023-10-17 21:27:36 +00:00
Subramanya Sastry 66ec96d6b1 ParsoidImageMap: use wfMessage to localize description types
* The previously failing Parsoid test now passes.

Bug: T311523
Depends-On: Id7d9e82ee4ff20a79ba1a5b2433fa29bc5f76e68
Change-Id: I03115b91fd781b72f0bf2c66cb6c18963a772dab
2023-10-09 12:21:35 -05:00
Subramanya Sastry be9aed5e13 Add a test to verify correct behavior of localized desc types
* Parsoid currently fails this and the failing test has been
  added to the known failure list. A follow-up patch will fix it.

Change-Id: Ic788340ec073b401e3e921339250a2678ea038da
2023-10-09 12:20:08 -05:00
C. Scott Ananian 5deb04029e Temporarily disable tests involving data-mw-i18n output
These will be updated in I84296d802382131b47fda097878df43e2f6f46ff
but we need to break a cyclic dependency.

Change-Id: I1842447492361fd9eb870b2573eaa50c51cf24fc
2023-10-06 12:58:18 -04:00
Subramanya Sastry 04c293d759 Enable Parsoid integrated tests
* This replaces the standalone tests that we ran for the Parsoid
  implementation while it lived in the Parsoid repo.

* There is no benefit running html2wt (and hence html2html) tests
  at this point since html2wt simply uses data-mw information.

Change-Id: I9435267f654eb07bcb1b5733986667a8617f1fbd
2023-09-27 12:46:00 -05:00
Subramanya Sastry 7a2d263b39 Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit d76d47b9b1accf2548dc1645c812c309dd84540e

Change-Id: I63ea3d08e8dd2727dec89878f0d8f5f27d9c0de1
2023-09-19 15:29:50 -05:00
Arlo Breault 1a8f86e41b Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit db0772cd77d89ea166bf6ea162f9d223264a6f50

Change-Id: I263043f284542ff866f633ad8177ab3d072ca679
2023-05-25 13:52:17 -04:00
Arlo Breault 96c60d44ca Add resource for thumb magnify links
Bug: T329413
Depends-On: Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37
Change-Id: Idec1b8dc1c742ca6ea3b24f3b14738c2d1f5b01d
2023-05-25 16:09:06 +00:00
Arlo Breault b2113e0154 Add back description links when !$wgParserEnableLegacyMediaDOM
The approach taken here is the same as in core for magnify links on
thumbs in Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37

The gist is that resource attributes are added on the mw-file-element so
that the necessary url is present in the html.  A class is also added to
the wrapper element that designates where the link should be positioned.
Finally, a script adds the link which styles in appropriately.

Bug: T329364
Depends-On: Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37
Change-Id: I20130fd39135dfd5074590ee9c2b6e01693384e4
2023-05-22 15:22:42 +00:00
Arlo Breault 6d83c5bc21 Fix adding titles when caption isn't visible
This was added in Ic0169d3914c5ce442b063f4bbbb6493966dbb302 and it
looks wrong on a few levels: the format isn't captured, and only
mw:File is emitted now.

Change-Id: I5aff7b53348696c485ef5683f6aab7aaafac4973
2023-04-27 13:34:16 +00:00
Arlo Breault 5f132d85a8 Update parsertests with new media classes
Depends-On: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: I771296865ec101d4af05f4dbbe194f01df3d72a6
2023-04-26 13:15:07 -04:00
Arlo Breault f3f0aa89ea Disable tests to break circular dependency
Needed-By: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: Ifc17fdf530af515b066de706ca5e69e118fd1c5b
2023-04-20 16:30:55 -04:00
C. Scott Ananian a4d5daa43f Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit 15cf6010f1342a67282d0e6ace4b1ef1eb2bbc47

Change-Id: Id096a272733cc2452d41a7f4b8cb230b8cfc6f62
2023-03-13 13:53:31 -04:00
Arlo Breault 08b48fd551 Re-enable tests
Follow-Up: I7b1f07190e8eaca5cbda38d9ce366aa60041ab81
Depends-On: If1e55feb86ce8b32f772e3b78bc9d29f122f4d58
Change-Id: I2a7b255f2783fad6b2e7e1478e5b020f396a486b
2023-02-09 10:25:10 -05:00
Arlo Breault 9f55b88fe9 Disable tests for CI
Needed-By: If1e55feb86ce8b32f772e3b78bc9d29f122f4d58
Change-Id: I7b1f07190e8eaca5cbda38d9ce366aa60041ab81
2023-02-09 10:21:51 -05:00
Arlo Breault 015a318a05 Re-enable tests
Follow-Up: Id6ad0b922f8384f2bbf08e1032b0197aa3136233
Depends-On: I8d059852f472b40b4f4f80a8fa12230f6f4f13ad
Change-Id: I1e5796f768649df466a768f81f2165e601940b8f
2023-02-08 16:20:18 -05:00
Arlo Breault 8d8e95e081 Disable tests for CI
Needed-By: I8d059852f472b40b4f4f80a8fa12230f6f4f13ad
Change-Id: Id6ad0b922f8384f2bbf08e1032b0197aa3136233
2023-02-08 16:17:56 -05:00
Bartosz Dziewoński 2cc6549898 Use Parsoid's HTML5-compliant helpers for HTML transformations
Previously XML parsing and serialization was used, causing `<br>`
to be disallowed and `<br />` to turn into `<br></br>`.

Also update some uses of XPath to use querySelector() helper.

Bug: T113791
Change-Id: Ic2069015b4cbb5d05a72eb383052319048111623
2022-11-25 17:05:24 +00:00
C. Scott Ananian 8890a38c96 Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit 5c6d948979bba6b58db13790cf3afcc883fe4ff6

Change-Id: Ie17011479274950758bce690d1d874d9e5f001a3
2022-10-12 14:52:11 -04:00
Arlo Breault bc5f7f7f3f Sync up with Parsoid imageMapParserTests.txt
This now aligns with Parsoid commit 4eb378d8c7cbdc9d6a939d6068f1c13e94e2b0ac

Change-Id: I83cd0c78abb6ef4313113b22bca486fc7453dcd7
2022-05-27 12:21:24 -04:00
Arlo Breault d132c60c6e Update typeofs to mw:File
Bug: T273505
Depends-On: I719a367622b3887cfea3032582a767c2c38d0f87
Change-Id: Ifa957e3b0e437447cdc1a60b2f387440a9ef9a88
2022-05-19 17:21:55 -04:00
Arlo Breault 011323524f Disable tests to avoid circular dependency
Bug: T273505
Change-Id: I9f36ef8bc3023195dd31e52f04e8f0f0f792d311
2022-05-19 17:19:44 -04:00
Arlo Breault 75f95fbc1e Place tooltips if caption isn't visible
Matches Parsoid commit Icbc36b6e9aa1b9f4f27c23f4833c626a725cc154

Bug: T297443
Bug: T108380
Depends-On: I30eba0fb226971ddeda4eb240929e89ef7e5f45f
Change-Id: Ic0169d3914c5ce442b063f4bbbb6493966dbb302
2022-05-16 19:22:03 -04:00
Arlo Breault 04ce450e68 Disable test temporarily
To break circular dependency.

For I30eba0fb226971ddeda4eb240929e89ef7e5f45f

Bug: T297443
Bug: T108380
Change-Id: I896e2af2e8a712a36eb23a25cad08f53574fc044
2022-05-16 17:54:56 -04:00
Arlo Breault 375570b616 Account for strtok boolean return type
This has been around for 16 years (since 284a684c) but throws when
strict_types are enforced.

Ternary is fine here since "0" doesn't seem like a legitimate type.

Bug: T302093
Change-Id: I1d2087ba28496e26c2718387cd735541698351f0
2022-02-25 18:53:47 -05:00
Arlo Breault 6b15f9b4b4 Re-enable tests that were disabled to break circular dep
Depends-On: Id4e8d16344ce0f420bfd3e0d5833c67d1cf85fd8
Change-Id: I9307a9fe09433ee0d552f4032b9505418ed8763b
2022-02-18 19:43:10 -05:00
Arlo Breault d0800e1f8d Revert "Add "resource" attribute to img tags"
For Id4e8d16344ce0f420bfd3e0d5833c67d1cf85fd8

Tests are disabled to avoid the circular dependency dance.

This reverts commit 8c9dfdf91f.

Change-Id: I261887a3b2d15130894b947d18a2e85537d50a1f
2022-02-18 19:41:11 -05:00
Arlo Breault 8c9dfdf91f Add "resource" attribute to img tags
Bug: T292657
Depends-On: Ia94138383ebdbfc2feef75fdf651b969085a72b1
Change-Id: Idb60e418f79dcb6a121de2a11e6e0ed0b31fd3ff
2021-12-15 19:16:09 -05:00
Arlo Breault 124cff0cb2 Handle link= file option
This only crashed the legacy output.

Bug: T294467
Change-Id: I4c44c0d04a0726c88d4ec9a7efbfd5e0a49d4437
2021-11-24 18:00:23 -05:00
Arlo Breault c3d9df4c40 Sync up with Parsoid imageMapParserTests.txt
This now aligns with Parsoid commit 1be0459b35fc39054f9ad74819409c127919fb0d

Change-Id: I34c936506b4d43f6b860003e2a70eec80a4f532c
2021-11-22 16:00:05 -05:00
Arlo Breault ee3e717a52 Force block imagemaps when !$enableLegacyMediaDOM
Matches the implementation in Idb576004a58f0949b824a46d26dab7d715268ca4

Bug: T290044
Change-Id: I3971471dd4f56d9df9246dc571a4c42cfe424867
2021-09-08 20:08:13 -04:00
Arlo Breault 66cc306cbe Update ImageMap for new media structure
Bug: T272186
Change-Id: I5544b7274316248773f191eb7ecd08088473fcd9
2021-08-12 19:00:19 -04:00
Arlo Breault 0ffd3ef783 Sync up with Parsoid imageMapParserTests.txt
This now aligns with Parsoid commit 77c2f005e3b3fdca6b4ff850066170b31390951d

Change-Id: Ic2fc228c959f273a005451ff8eb1f6830de5cf6b
2021-08-12 18:38:49 -04:00
Arlo Breault 7663297861 Sync up with Parsoid imageMapParserTests.txt
This now aligns with Parsoid commit 10b44f6c0b6a38fb129a0deb39b98b196508ebe3

Change-Id: I29b89066e666dd0e552a2d30315a116153b58d5f
2021-07-15 15:39:35 -04:00
C. Scott Ananian 86e2a3a971 Update parserTests to v2 (tidy by default)
Mostly cleaning up close tags for empty elements.

Bug: T249136
Change-Id: Ifb13838c32748b1d52612da0cdb0e0a44c6e0689
2020-04-01 20:09:52 +00:00
Ed Sanders b024fddb4d Make mapName deterministic so it can be tested
Change-Id: Ia906b46fbe8d84ae1482f8efaeb609d08c53bfa8
2019-08-30 17:43:37 +01:00
Arlo Breault f2c607e101 Update tests to match parser changes
Bug: T208070
Depends-On: I3da235cb83efa424f0cf1cf4fc7233240fcdf6b2
Change-Id: Ie70e1915c172d2d67b3b8b90eb35f753b800f61e
2019-03-15 18:24:51 +00:00
zoranzoki21 eadde54449 Upgrade ImageMap extension to use newer phan
Bug: T216921
Change-Id: I6bb5c8e855a191cae7bddbf8a5f23da5c033045f
2019-03-11 19:46:47 +00:00
zoranzoki21 b0b5b63fd9 Move images in resources directory
Change-Id: Id76a292e75c1ef82410439235b6d25eb0cff4284
2019-03-02 22:06:50 +01:00
Thiemo Kreuz 0c36a0b9a7 Fix parser test by adding decoding="async" parameter
As far as I can see this was introduced via I3d738eb in December 2018,
but never applied to this codebase.

Bug: T212124
Change-Id: I5d986b23fdd52ebc207405f8d7dfcdc208e55f3f
2019-01-15 15:45:31 +01:00
Jayprakash12345 a6cb086374 Update extensions to take advantage of parser test autodiscovery
Bug: T170037
Change-Id: I8eae59053930f7621c812c754d5f4fa5314087e1
2018-04-13 15:23:25 +00:00
Kunal Mehta 91b148624e build: Updating mediawiki/mediawiki-phan-config to 0.2.0
Change-Id: Ic5d7e1bc992a5954c5d7c938fae2066ac078068c
2018-04-05 13:27:40 -07:00
Kunal Mehta e9208739b6 Add phan configuration
Change-Id: Ie8aee5326c4217e151dee816bc5a3d6b71bf6aa2
2018-02-24 13:33:36 -08:00